From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A03BC3F374 for ; Thu, 27 Feb 2020 14:06:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC7AD20801 for ; Thu, 27 Feb 2020 14:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582812418; bh=SG+w3XEZEe1qhjFJHmDkXqxudXX4yoxpPZ91qTpBJyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BUh2KKRWlZJHizcQVzpFy5Oqk6eOjoWBNfdNA9NILhOSwlS6KC1OAMzNGI+Oi15f5 xlJ2VcOBTi59tQVD+OimJ4qx4l/4jSDKLt5N3aEk2/PdTrrxL1mAQ8YIzHoSwKZpbw Si6/AdTELfY4Xy5wRL2eXTum6de5hKyqj9FdPSGw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388002AbgB0OG5 (ORCPT ); Thu, 27 Feb 2020 09:06:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:44122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733251AbgB0OGu (ORCPT ); Thu, 27 Feb 2020 09:06:50 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3601620801; Thu, 27 Feb 2020 14:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582812409; bh=SG+w3XEZEe1qhjFJHmDkXqxudXX4yoxpPZ91qTpBJyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J6Ml0PMuyIHPgMzS6n29aeaZdxhdx/CIzG/Ayh59spKAcCueOZqMD6CSAXBM7vz+k NYlVgWKqxT7PbrzrqxzcJRJ8auzKv9ZYaobwWepi4y/7fWuP9zcZ/FnSEm6CqnVvJ1 Rzwy2qWkXNkp5XoHYy8cFVinDlMI618VNs8XNNXQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Kara , Theodore Tso , stable@kernel.org Subject: [PATCH 4.19 68/97] ext4: fix mount failure with quota configured as module Date: Thu, 27 Feb 2020 14:37:16 +0100 Message-Id: <20200227132225.574960751@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132214.553656188@linuxfoundation.org> References: <20200227132214.553656188@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Kara commit 9db176bceb5c5df4990486709da386edadc6bd1d upstream. When CONFIG_QFMT_V2 is configured as a module, the test in ext4_feature_set_ok() fails and so mount of filesystems with quota or project features fails. Fix the test to use IS_ENABLED macro which works properly even for modules. Link: https://lore.kernel.org/r/20200221100835.9332-1-jack@suse.cz Fixes: d65d87a07476 ("ext4: improve explanation of a mount failure caused by a misconfigured kernel") Signed-off-by: Jan Kara Signed-off-by: Theodore Ts'o Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2948,7 +2948,7 @@ static int ext4_feature_set_ok(struct su return 0; } -#if !defined(CONFIG_QUOTA) || !defined(CONFIG_QFMT_V2) +#if !IS_ENABLED(CONFIG_QUOTA) || !IS_ENABLED(CONFIG_QFMT_V2) if (!readonly && (ext4_has_feature_quota(sb) || ext4_has_feature_project(sb))) { ext4_msg(sb, KERN_ERR,