From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E0CDC761A6 for ; Thu, 27 Feb 2020 14:22:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C6B724656 for ; Thu, 27 Feb 2020 14:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582813378; bh=M+3C6Vfw8tIQOCDP4th63PzilReHvAapp2Moe3ZV2mg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DQC38YZpbLw2MCX+TS0j2fz2I3+OOXbZqRRaQk2iHre8SYxMg/LIQ8PnkDsh8kCqO vcmxBV6+qrZDXa+mXGR0C7GLnBV36MCTZyWPKJtvhXDiHEE3gjSIzc3KLtTxnG8m6M mfNyNHbkqflAPKiIqA2CY/XEA01E7ndM/d8VXo8o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388970AbgB0OPY (ORCPT ); Thu, 27 Feb 2020 09:15:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:54920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389055AbgB0OPU (ORCPT ); Thu, 27 Feb 2020 09:15:20 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 280BB20801; Thu, 27 Feb 2020 14:15:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582812919; bh=M+3C6Vfw8tIQOCDP4th63PzilReHvAapp2Moe3ZV2mg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q+uXaDNjjW5KQS1s1v0dWyLaUJPBqgi2Eliha/uMgMdgA/9urLSCeKK/PWiTaOXC7 VK9hgTKB8+Xuzfb6hh+tuZUUGMfWGcONJRtvZCyaRCKqZwTX6QdgSv4mdVhAaafIvm zSBMZnOSXePbhGLMxgNVBpX+jSNh32w3opACPggE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Malcolm Priestley Subject: [PATCH 5.5 030/150] staging: vt6656: fix sign of rx_dbm to bb_pre_ed_rssi. Date: Thu, 27 Feb 2020 14:36:07 +0100 Message-Id: <20200227132237.280889676@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132232.815448360@linuxfoundation.org> References: <20200227132232.815448360@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Malcolm Priestley commit 93134df520f23f4e9998c425b8987edca7016817 upstream. bb_pre_ed_rssi is an u8 rx_dm always returns negative signed values add minus operator to always yield positive. fixes issue where rx sensitivity is always set to maximum because the unsigned numbers were always greater then 100. Fixes: 63b9907f58f1 ("staging: vt6656: mac80211 conversion: create rx function.") Cc: stable Signed-off-by: Malcolm Priestley Link: https://lore.kernel.org/r/aceac98c-6e69-3ce1-dfec-2bf27b980221@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6656/dpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/vt6656/dpc.c +++ b/drivers/staging/vt6656/dpc.c @@ -130,7 +130,7 @@ int vnt_rx_data(struct vnt_private *priv vnt_rf_rssi_to_dbm(priv, *rssi, &rx_dbm); - priv->bb_pre_ed_rssi = (u8)rx_dbm + 1; + priv->bb_pre_ed_rssi = (u8)-rx_dbm + 1; priv->current_rssi = priv->bb_pre_ed_rssi; skb_pull(skb, 8);