From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11968C52D54 for ; Thu, 27 Feb 2020 14:17:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA60C246A9 for ; Thu, 27 Feb 2020 14:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582813070; bh=/tyTvlOefgejlw1qNqg4s5MKur21O+cVuaR95mSgyx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ea+AWIEd5kQCXk5Vvg2mJ1TnaeEE9T3vkeWbmrgUxwXyVpuT8QbEkPiCrek2j+msD 1xjcxjcvVKj4fmMpCecHDQDmfJbqmXvMsbmqy2+8fn++4mRl4qB/5B9wprr62aJj2o +7HqCkPW87J88o4GE6nyOd9G1YdvebLx+i7kbEAk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389783AbgB0ORt (ORCPT ); Thu, 27 Feb 2020 09:17:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:58276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389773AbgB0ORr (ORCPT ); Thu, 27 Feb 2020 09:17:47 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACB6D20801; Thu, 27 Feb 2020 14:17:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582813067; bh=/tyTvlOefgejlw1qNqg4s5MKur21O+cVuaR95mSgyx0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H2r1LzNOWuVIR98ecNbc7SkqRfSShI5l/3tCcg5Ag0N6XMYmOag+zpOj5TZQgdU0v /sFk6EdeH+Rdw2aFedp1ktuaxnx9t3KOlThHDPI6zFwIvXVWmcHPcr24gL+XAUultk +G/yw7g16yQCdIZrxU/z5EH8twqkcXho9rn8CX94= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Viresh Kumar , Vaibhav Agarwal Subject: [PATCH 5.5 124/150] staging: greybus: use after free in gb_audio_manager_remove_all() Date: Thu, 27 Feb 2020 14:37:41 +0100 Message-Id: <20200227132250.977362549@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132232.815448360@linuxfoundation.org> References: <20200227132232.815448360@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter commit b7db58105b80fa9232719c8329b995b3addfab55 upstream. When we call kobject_put() and it's the last reference to the kobject then it calls gb_audio_module_release() and frees module. We dereference "module" on the next line which is a use after free. Fixes: c77f85bbc91a ("greybus: audio: Fix incorrect counting of 'ida'") Signed-off-by: Dan Carpenter Acked-by: Viresh Kumar Reviewed-by: Vaibhav Agarwal Link: https://lore.kernel.org/r/20200205123217.jreendkyxulqsool@kili.mountain Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/audio_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -92,8 +92,8 @@ void gb_audio_manager_remove_all(void) list_for_each_entry_safe(module, next, &modules_list, list) { list_del(&module->list); - kobject_put(&module->kobj); ida_simple_remove(&module_id, module->id); + kobject_put(&module->kobj); } is_empty = list_empty(&modules_list);