From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A1C9C3F349 for ; Thu, 27 Feb 2020 13:53:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6818D2084E for ; Thu, 27 Feb 2020 13:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582811633; bh=AQplWEyobcRF4s720xyq8eoSi5AdIApMI5oGAFcpNkE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TCXKRfAWF1DH3gNXdwUseWmJzaI5FxwGjhEKv1Omj8buEpXrouCquhsasmoax7JCJ 1hdfJGw1fkQVHX1Q5TIhnpRDc4dFJfwMJkT3Rm6CE7aleyo6ZaaDGZZr7Byw6k2QKG 9Z6Dai4AInpVdia5kiA0+pEqA0JZHQ5YNDdh17Ak= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731591AbgB0Nxw (ORCPT ); Thu, 27 Feb 2020 08:53:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:53770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731767AbgB0Nxu (ORCPT ); Thu, 27 Feb 2020 08:53:50 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A54620578; Thu, 27 Feb 2020 13:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582811629; bh=AQplWEyobcRF4s720xyq8eoSi5AdIApMI5oGAFcpNkE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hV3+LAfIMEsm7jZlB+e3uyTY/7CtIXiNcjEsRVQ7ovY+6Lys4tNU9bNxFBqEtmqDo 8Hnb/IkIGDr8nbwcI8pZgAPT6oOR95zu8Ioo/qMv8UYDt0SUq3y6omrpIYswCPBKDG bB/noUva1kImppSpzYx8z/3OujR/cW6q3vM++50I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Franky Lin , Kalle Valo , Sasha Levin Subject: [PATCH 4.14 041/237] brcmfmac: Fix use after free in brcmf_sdio_readframes() Date: Thu, 27 Feb 2020 14:34:15 +0100 Message-Id: <20200227132259.742020177@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132255.285644406@linuxfoundation.org> References: <20200227132255.285644406@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 216b44000ada87a63891a8214c347e05a4aea8fe ] The brcmu_pkt_buf_free_skb() function frees "pkt" so it leads to a static checker warning: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1974 brcmf_sdio_readframes() error: dereferencing freed memory 'pkt' It looks like there was supposed to be a continue after we free "pkt". Fixes: 4754fceeb9a6 ("brcmfmac: streamline SDIO read frame routine") Signed-off-by: Dan Carpenter Acked-by: Franky Lin Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index 4c28b04ea6053..d198a8780b966 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -1932,6 +1932,7 @@ static uint brcmf_sdio_readframes(struct brcmf_sdio *bus, uint maxframes) BRCMF_SDIO_FT_NORMAL)) { rd->len = 0; brcmu_pkt_buf_free_skb(pkt); + continue; } bus->sdcnt.rx_readahead_cnt++; if (rd->len != roundup(rd_new.len, 16)) { -- 2.20.1