From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1794EC52D36 for ; Thu, 27 Feb 2020 14:33:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D6C9A24656 for ; Thu, 27 Feb 2020 14:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582814007; bh=LbvWt1qaaoHgw126FlvXqbzf1tcad1g/Bm2OGES6oUk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tEbIgePLsew9g43XP+AW7pZJYy+qRMt/mCLj4zW1ktcmL9ljdJs1cg87xEwAr66bj V4G5rXQcAzsFmt4NETJ+YSlh+u8P3HzsN+aBiDGrP0BGQDj9MD1Y82J1ve5E7KjMyE 7FPBB8BEsDWdM++hvkcW4cybLU1Y9eS9C4EJyVa0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387459AbgB0Od0 (ORCPT ); Thu, 27 Feb 2020 09:33:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:33962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732752AbgB0OAc (ORCPT ); Thu, 27 Feb 2020 09:00:32 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D6222073D; Thu, 27 Feb 2020 14:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582812031; bh=LbvWt1qaaoHgw126FlvXqbzf1tcad1g/Bm2OGES6oUk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pjokvk3eZi/wpL1Nwn1f/i4/2T5nCHZwhjGNsYHu/dfLsiDofWCaDG1V3MbNxvZ8g 4iG/lbymjRWqdfJ9sHsq8UJ9LZW3S0wSNe7OoduJird8V/+36g1gmEtew6ykXIsjuw v/29TpTJtTmOWaQipFncCI+CW0ToD2zs7tj0wugQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yunfeng Ye , zhengbin , Hu Shiyuan , Feilong Lin , Jan Kara , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.14 157/237] reiserfs: prevent NULL pointer dereference in reiserfs_insert_item() Date: Thu, 27 Feb 2020 14:36:11 +0100 Message-Id: <20200227132308.089075940@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200227132255.285644406@linuxfoundation.org> References: <20200227132255.285644406@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yunfeng Ye [ Upstream commit aacee5446a2a1aa35d0a49dab289552578657fb4 ] The variable inode may be NULL in reiserfs_insert_item(), but there is no check before accessing the member of inode. Fix this by adding NULL pointer check before calling reiserfs_debug(). Link: http://lkml.kernel.org/r/79c5135d-ff25-1cc9-4e99-9f572b88cc00@huawei.com Signed-off-by: Yunfeng Ye Cc: zhengbin Cc: Hu Shiyuan Cc: Feilong Lin Cc: Jan Kara Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/reiserfs/stree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c index 0037aea97d39a..2946713cb00d6 100644 --- a/fs/reiserfs/stree.c +++ b/fs/reiserfs/stree.c @@ -2250,7 +2250,8 @@ error_out: /* also releases the path */ unfix_nodes(&s_ins_balance); #ifdef REISERQUOTA_DEBUG - reiserfs_debug(th->t_super, REISERFS_DEBUG_CODE, + if (inode) + reiserfs_debug(th->t_super, REISERFS_DEBUG_CODE, "reiserquota insert_item(): freeing %u id=%u type=%c", quota_bytes, inode->i_uid, head2type(ih)); #endif -- 2.20.1