From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Julia Lawall <julia.lawall-MZpvjPyXg2s@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
Linux Memory Management List
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings
Date: Thu, 27 Feb 2020 19:14:13 +0100 [thread overview]
Message-ID: <20200227181413.GB1114616@ulmo> (raw)
In-Reply-To: <b3e3a337-08f3-81b4-6b01-65fbdce72b36-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]
On Thu, Feb 27, 2020 at 05:50:19PM +0300, Dmitry Osipenko wrote:
> 27.02.2020 13:35, Julia Lawall пишет:
> > From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >
> > Remove dev_err() messages after platform_get_irq*() failures.
> > platform_get_irq() already prints an error.
> >
> > Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> >
> > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
> > CC: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Julia Lawall <julia.lawall-MZpvjPyXg2s@public.gmane.org>
> > ---
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
> > commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST
> > :::::: branch date: 17 hours ago
> > :::::: commit date: 2 days ago
> >
> > Please take the patch only if it's a positive warning. Thanks!
> >
> > tegra20-apb-dma.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > --- a/drivers/dma/tegra20-apb-dma.c
> > +++ b/drivers/dma/tegra20-apb-dma.c
> > @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
> > irq = platform_get_irq(pdev, i);
> > if (irq < 0) {
> > ret = irq;
> > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
> > goto err_pm_disable;
> > }
> >
>
> Reviewed-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Julia Lawall <julia.lawall@inria.fr>,
Andrew Morton <akpm@linux-foundation.org>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings
Date: Thu, 27 Feb 2020 19:14:13 +0100 [thread overview]
Message-ID: <20200227181413.GB1114616@ulmo> (raw)
In-Reply-To: <b3e3a337-08f3-81b4-6b01-65fbdce72b36@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]
On Thu, Feb 27, 2020 at 05:50:19PM +0300, Dmitry Osipenko wrote:
> 27.02.2020 13:35, Julia Lawall пишет:
> > From: kbuild test robot <lkp@intel.com>
> >
> > Remove dev_err() messages after platform_get_irq*() failures.
> > platform_get_irq() already prints an error.
> >
> > Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> >
> > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
> > CC: Dmitry Osipenko <digetx@gmail.com>
> > Signed-off-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> > ---
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
> > commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST
> > :::::: branch date: 17 hours ago
> > :::::: commit date: 2 days ago
> >
> > Please take the patch only if it's a positive warning. Thanks!
> >
> > tegra20-apb-dma.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > --- a/drivers/dma/tegra20-apb-dma.c
> > +++ b/drivers/dma/tegra20-apb-dma.c
> > @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
> > irq = platform_get_irq(pdev, i);
> > if (irq < 0) {
> > ret = irq;
> > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
> > goto err_pm_disable;
> > }
> >
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings
Date: Thu, 27 Feb 2020 19:14:13 +0100 [thread overview]
Message-ID: <20200227181413.GB1114616@ulmo> (raw)
In-Reply-To: <b3e3a337-08f3-81b4-6b01-65fbdce72b36@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]
On Thu, Feb 27, 2020 at 05:50:19PM +0300, Dmitry Osipenko wrote:
> 27.02.2020 13:35, Julia Lawall пишет:
> > From: kbuild test robot <lkp@intel.com>
> >
> > Remove dev_err() messages after platform_get_irq*() failures.
> > platform_get_irq() already prints an error.
> >
> > Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> >
> > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
> > CC: Dmitry Osipenko <digetx@gmail.com>
> > Signed-off-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> > ---
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
> > commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST
> > :::::: branch date: 17 hours ago
> > :::::: commit date: 2 days ago
> >
> > Please take the patch only if it's a positive warning. Thanks!
> >
> > tegra20-apb-dma.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > --- a/drivers/dma/tegra20-apb-dma.c
> > +++ b/drivers/dma/tegra20-apb-dma.c
> > @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
> > irq = platform_get_irq(pdev, i);
> > if (irq < 0) {
> > ret = irq;
> > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
> > goto err_pm_disable;
> > }
> >
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-02-27 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 10:35 [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings Julia Lawall
2020-02-27 10:35 ` Julia Lawall
2020-02-27 14:50 ` Dmitry Osipenko
2020-02-27 14:50 ` Dmitry Osipenko
[not found] ` <b3e3a337-08f3-81b4-6b01-65fbdce72b36-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-27 18:14 ` Thierry Reding [this message]
2020-02-27 18:14 ` Thierry Reding
2020-02-27 18:14 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227181413.GB1114616@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=julia.lawall-MZpvjPyXg2s@public.gmane.org \
--cc=kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.