From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings Date: Thu, 27 Feb 2020 19:14:13 +0100 Message-ID: <20200227181413.GB1114616@ulmo> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mxv5cy4qt+RJ9ypb" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Julia Lawall , Andrew Morton , kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Linux Memory Management List , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jon Hunter List-Id: linux-tegra@vger.kernel.org --mxv5cy4qt+RJ9ypb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 27, 2020 at 05:50:19PM +0300, Dmitry Osipenko wrote: > 27.02.2020 13:35, Julia Lawall =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > From: kbuild test robot > >=20 > > Remove dev_err() messages after platform_get_irq*() failures. > > platform_get_irq() already prints an error. > >=20 > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > >=20 > > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST") > > CC: Dmitry Osipenko > > Signed-off-by: kbuild test robot > > Signed-off-by: Julia Lawall > > --- > >=20 > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= =2Egit master > > head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8 > > commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine:= tegra-apb: Support COMPILE_TEST > > :::::: branch date: 17 hours ago > > :::::: commit date: 2 days ago > >=20 > > Please take the patch only if it's a positive warning. Thanks! > >=20 > > tegra20-apb-dma.c | 1 - > > 1 file changed, 1 deletion(-) > >=20 > > --- a/drivers/dma/tegra20-apb-dma.c > > +++ b/drivers/dma/tegra20-apb-dma.c > > @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo > > irq =3D platform_get_irq(pdev, i); > > if (irq < 0) { > > ret =3D irq; > > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i); > > goto err_pm_disable; > > } > >=20 >=20 > Reviewed-by: Dmitry Osipenko Acked-by: Thierry Reding --mxv5cy4qt+RJ9ypb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl5YBvIACgkQ3SOs138+ s6Fcvw/9HVltfggbT9wrk+m7pkvTajave6B5wHAJfsxT6SogdNQcPuZfoKVfGGYV JdtPtISVsw1vy3wJA0FGjd5TUFxLuG+z3VYVZvfdGcoQbccoNaM1wW1EDbGDp+0S DyzY5hUqYKXSK/Q8tHhNfmXtaP5MjbvU0dWiZLBjCIPeMBlWqp5MmJd5tVDiN+dW /GFWMLowRTKSgfRapfoMYRTN+UEdli3SWm0PaT+Cxg+zC3A0RAm9Z4PZlFyaHLfh xtWwvzGvsJEYkyA1q35c+Sb7hjnpy4hf6X6kC8glUAXHXbSn3ZOgkg4meL3mLtGV 4CqbraDiCRX3mbHHniSGlWX8PEkoYBUsyqPtfim8snmjuVUF4CodEeZ4fHbPBV7n JkfKWLtQkx/hVXOTVWB+5nhnNU0U7aaBbbZ5TmXZTPeO6vELo5msO6gXww7gHXMW +0IXUZai7/jnq5nZXYwDk8teaD85eadpL0j+avBp72e1yBdUkb42Pa9ihMC9KOpK XakS+UyWlFrkuxw/7rUPCO2EnikLZETCo3Prg5phDjzbyLBf2XBi69Ldi32GhYGo hlmTeS/TqH9AdGqda10UApdssBPAFpmwHRderqzfLud6swzuTJErc1FewZO6T6TF EBu8uMKEioKK7dp5JwxLLFepNiyb95Wc4xh7ZLIkGdFxjlCiWXw= =JmSm -----END PGP SIGNATURE----- --mxv5cy4qt+RJ9ypb-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88449C11D3D for ; Thu, 27 Feb 2020 18:14:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4971D246B2 for ; Thu, 27 Feb 2020 18:14:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hRebITCg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4971D246B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E8A006B0007; Thu, 27 Feb 2020 13:14:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E10AE6B0008; Thu, 27 Feb 2020 13:14:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD9996B000A; Thu, 27 Feb 2020 13:14:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id B197F6B0007 for ; Thu, 27 Feb 2020 13:14:18 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 80E568E72 for ; Thu, 27 Feb 2020 18:14:18 +0000 (UTC) X-FDA: 76536706596.30.berry37_258e101306c23 X-HE-Tag: berry37_258e101306c23 X-Filterd-Recvd-Size: 5959 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Feb 2020 18:14:17 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id t23so436747wmi.1 for ; Thu, 27 Feb 2020 10:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=V/eXwxbc1yyKrifVUp+YnPA01U8Yl+fqqtvmUUcbPSU=; b=hRebITCgWe8CzAd5RJv7oqAKBjYT95y7CdfyxW2KYnvBChw+uco5U3x9uzO0+b+7aw fe4wwqfkyhMsPyHmiBp7vJ9Tmj00wayttGWQuUFL4y6r8XUOdWw7TR6dUQewFxuPkJrB +ifEGx9s15GsWEIi7wJR6Nhx99XFHmjuXqPQDnU7qbFsnD81qIpnQgdb0vKRC/NvLECU WzCBfxb4XKrb7elhumxRuwGlwCXb1PwVg9dnR+EoGxzdOTQw1LpWoHo3cN3AQtCxgAwu qd1nkAkh8xtuUftMybyEIHfJL6XQzABAUPcLIzIMi2vjylISjns7QT7j3S3MOijkZeo3 lsoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=V/eXwxbc1yyKrifVUp+YnPA01U8Yl+fqqtvmUUcbPSU=; b=FKBoX2RZljN/1d6MbsapmIg7K/7Pb9JSasCEaGsysDEolb792sd7mdUkZE5q1ME+KA Sio5zMqrI+lOjtnWYH/OjPo3RMIL5dGJZyB64zfcj0HGJySJ58UmxaIu+PtObGe2YN9v 4GNuS4+9KxdJ1kShNKDVtYxmTp4yLOHyGsmcTKhUx+OjPLmx1qyPIsT2Lyue62rB83gp o8Ms+iJyM+Pq1gKkIU+4Wv7Jihliy2g1NBbbJyVhrAjv7f68EbOTu2LXYAieWDLVjPJm FcfRRJEQwyeoWy/GTWmsMFmk03AZhJorunQx2Gbb5LU0XWahGcOrgYB5F/K6mcZRkAVQ dA2A== X-Gm-Message-State: APjAAAW3D/TcCoQDd+/ov2Tr3kNX4gOsOsGGESIi/C8GVJ9fPI4YH4lT +27dL2Q1cCLjtUofpO1GWsM= X-Google-Smtp-Source: APXvYqwlvBNXajG7n/paFXNEoR61iytNaYaMBLABTaWzB/7urQeIY07Ht/Upmp/fL+6SWtFPvS5jrg== X-Received: by 2002:a05:600c:230d:: with SMTP id 13mr23178wmo.11.1582827256657; Thu, 27 Feb 2020 10:14:16 -0800 (PST) Received: from localhost (pD9E516A9.dip0.t-ipconnect.de. [217.229.22.169]) by smtp.gmail.com with ESMTPSA id v16sm8726202wml.11.2020.02.27.10.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 10:14:15 -0800 (PST) Date: Thu, 27 Feb 2020 19:14:13 +0100 From: Thierry Reding To: Dmitry Osipenko Cc: Julia Lawall , Andrew Morton , kbuild-all@lists.01.org, Linux Memory Management List , "linux-tegra@vger.kernel.org" , Jon Hunter Subject: Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings Message-ID: <20200227181413.GB1114616@ulmo> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mxv5cy4qt+RJ9ypb" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.13.1 (2019-12-14) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --mxv5cy4qt+RJ9ypb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 27, 2020 at 05:50:19PM +0300, Dmitry Osipenko wrote: > 27.02.2020 13:35, Julia Lawall =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > From: kbuild test robot > >=20 > > Remove dev_err() messages after platform_get_irq*() failures. > > platform_get_irq() already prints an error. > >=20 > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > >=20 > > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST") > > CC: Dmitry Osipenko > > Signed-off-by: kbuild test robot > > Signed-off-by: Julia Lawall > > --- > >=20 > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= =2Egit master > > head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8 > > commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine:= tegra-apb: Support COMPILE_TEST > > :::::: branch date: 17 hours ago > > :::::: commit date: 2 days ago > >=20 > > Please take the patch only if it's a positive warning. Thanks! > >=20 > > tegra20-apb-dma.c | 1 - > > 1 file changed, 1 deletion(-) > >=20 > > --- a/drivers/dma/tegra20-apb-dma.c > > +++ b/drivers/dma/tegra20-apb-dma.c > > @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo > > irq =3D platform_get_irq(pdev, i); > > if (irq < 0) { > > ret =3D irq; > > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i); > > goto err_pm_disable; > > } > >=20 >=20 > Reviewed-by: Dmitry Osipenko Acked-by: Thierry Reding --mxv5cy4qt+RJ9ypb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl5YBvIACgkQ3SOs138+ s6Fcvw/9HVltfggbT9wrk+m7pkvTajave6B5wHAJfsxT6SogdNQcPuZfoKVfGGYV JdtPtISVsw1vy3wJA0FGjd5TUFxLuG+z3VYVZvfdGcoQbccoNaM1wW1EDbGDp+0S DyzY5hUqYKXSK/Q8tHhNfmXtaP5MjbvU0dWiZLBjCIPeMBlWqp5MmJd5tVDiN+dW /GFWMLowRTKSgfRapfoMYRTN+UEdli3SWm0PaT+Cxg+zC3A0RAm9Z4PZlFyaHLfh xtWwvzGvsJEYkyA1q35c+Sb7hjnpy4hf6X6kC8glUAXHXbSn3ZOgkg4meL3mLtGV 4CqbraDiCRX3mbHHniSGlWX8PEkoYBUsyqPtfim8snmjuVUF4CodEeZ4fHbPBV7n JkfKWLtQkx/hVXOTVWB+5nhnNU0U7aaBbbZ5TmXZTPeO6vELo5msO6gXww7gHXMW +0IXUZai7/jnq5nZXYwDk8teaD85eadpL0j+avBp72e1yBdUkb42Pa9ihMC9KOpK XakS+UyWlFrkuxw/7rUPCO2EnikLZETCo3Prg5phDjzbyLBf2XBi69Ldi32GhYGo hlmTeS/TqH9AdGqda10UApdssBPAFpmwHRderqzfLud6swzuTJErc1FewZO6T6TF EBu8uMKEioKK7dp5JwxLLFepNiyb95Wc4xh7ZLIkGdFxjlCiWXw= =JmSm -----END PGP SIGNATURE----- --mxv5cy4qt+RJ9ypb-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8569483605935721179==" MIME-Version: 1.0 From: Thierry Reding To: kbuild-all@lists.01.org Subject: Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings Date: Thu, 27 Feb 2020 19:14:13 +0100 Message-ID: <20200227181413.GB1114616@ulmo> In-Reply-To: List-Id: --===============8569483605935721179== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Feb 27, 2020 at 05:50:19PM +0300, Dmitry Osipenko wrote: > 27.02.2020 13:35, Julia Lawall =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > From: kbuild test robot > > = > > Remove dev_err() messages after platform_get_irq*() failures. > > platform_get_irq() already prints an error. > > = > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > > = > > Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST") > > CC: Dmitry Osipenko > > Signed-off-by: kbuild test robot > > Signed-off-by: Julia Lawall > > --- > > = > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > > head: f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8 > > commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine:= tegra-apb: Support COMPILE_TEST > > :::::: branch date: 17 hours ago > > :::::: commit date: 2 days ago > > = > > Please take the patch only if it's a positive warning. Thanks! > > = > > tegra20-apb-dma.c | 1 - > > 1 file changed, 1 deletion(-) > > = > > --- a/drivers/dma/tegra20-apb-dma.c > > +++ b/drivers/dma/tegra20-apb-dma.c > > @@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo > > irq =3D platform_get_irq(pdev, i); > > if (irq < 0) { > > ret =3D irq; > > - dev_err(&pdev->dev, "No irq resource for chan %d\n", i); > > goto err_pm_disable; > > } > > = > = > Reviewed-by: Dmitry Osipenko Acked-by: Thierry Reding --===============8569483605935721179== Content-Type: application/pgp-signature MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUFCQ0FBZEZpRUVpT3JEQ0FGSnpQ ZkFqY2lmM1NPczEzOCtzNkVGQWw1WUJ2SUFDZ2tRM1NPczEzOCsKczZGY3Z3LzlIVmx0ZmdnYlQ5 d3JrK203cGt2VGFqYXZlNkI1d0hBSmZzeFQ2U29nZE5RY1B1WmZvS1ZmR0dZVgpKZHRQdElTVnN3 MXZ5M3dKQTBGR2pkNVRVRnhMdUcrejNWWVZadmZkR2NvUWJjY29OYU0xd1cxRURiR0RwKzBTCkR5 elk1aFVxWUtYU0svUTh0SGhOZm1YdGFQNU1qYnZVMGRXaVpMQmpDSVBlTUJsV3FwNU1tSmQ1dFZE aU4rZFcKL0dGV01Mb3dSVEtTZ2ZSYXBmb01ZUlROK1VFZGxpM1NXbTBQYVQrQ3hnK3pDM0EwUkFt OVo0UFpsRnlhSExmaAp4dFd3dnpHdnNKRVlreUExcTM1YytTYjdoam5weTRoZjZYNmtDOGdsVUFY SFhiU24zWk9na2c0bWVMM21MdEdWCjRDcWJyYURpQ1JYM21iSEhuaVNHbFdYOFBFa29ZQlVzeXFQ dGZpbThzbm1qdVZVRjRDb2RFZVo0ZkhiUEJWN24KSmtmS1dMdFFreC9oVlhPVFZXQis1bmhuTlUw VTdhYUJiYlo1VG1YWlRQZU82dkVMbzVtc082Z1h3dzdnSFhNVworMElYVVphaTcvam5xNW5aWFl3 RGs4dGVhRDg1ZWFkcEwwaithdkJwNzJlMXlCZFVrYjQyUGE5aWhNQzlLT3BLClhha1MrVXlXbEZy a3V4dy83clVQQ08yRW5pa0xaRVRDbzNQcmc1cGhEanpieUxCZjJYQmk2OUxkaTMyR2hZR28KaGxt VGVTL1RxSDlBZEdxZGExMFVBcGRzc0JQQUZwbXdIUmRlcnF6Zkx1ZDZzd3p1VEpFcmMxRmV3Wk82 VDZURgpFQnU4dU1LRWlvS0s3ZHA1Snd4TExGZXBOaXliOTVXYzR4aDdaTElrR2RGeGpsQ2lXWHc9 Cj1KbVNtCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============8569483605935721179==--