From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DAA5C3F2C2 for ; Thu, 27 Feb 2020 21:53:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B4C8246A1 for ; Thu, 27 Feb 2020 21:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582840436; bh=/5m83hqrXLbOV9ZphYEfsU4UnROjR8cXYZCUEOkJjhU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CHkT3oOmKRAMqx39/uzwQQIer7lpG8agorB42OuNSlBvzOsKcwwVaR0isZXiq9R+G mUgdYmNboh700A+modmKbVpbhymA/DCTTlt9XTxeoFQ3ZwkjKXBBLsPWcug0Oh1F30 kd75KIw9JcA+MOET+LPvyAdI+YfjPdpvfTG3akIw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730223AbgB0Vxz (ORCPT ); Thu, 27 Feb 2020 16:53:55 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40310 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729773AbgB0Vxy (ORCPT ); Thu, 27 Feb 2020 16:53:54 -0500 Received: by mail-pf1-f194.google.com with SMTP id b185so532119pfb.7 for ; Thu, 27 Feb 2020 13:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7dwQH34KOZabRYRAwZrdnJHMAH3aJ68bic4ZknrTLvQ=; b=mjmOJ66owX0Df96b/m5GC1crg6u5wtB1ayeppKZj6Rh3bevN9Nj/By2G3ScTRQpKn7 l+QLMQJsMBwlF1Zv2iBkFTRR4zrlvvcKN2MrL/R6n5r9pc/SRafnlN/oxqFg3CCvhFkw x3rKHRm5o1xq8zpLmYfzBSkrODdyNgBksE58gfKBjFofl3sAgeX9ZF9lhTfstRzvzgUO vXWIH65KMcmLCNHHgxg6IbeiXN1IFExj7wyNO1eYaAQAjFUveBoFv0WbPqH0pukyHoAN a6tDVZmzsPqplyKO/DIOOkWvoHUxTBq3BZ2DbwpFclx7qXI34rd0ey+jlA1W2Rylis/C pNsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=7dwQH34KOZabRYRAwZrdnJHMAH3aJ68bic4ZknrTLvQ=; b=j5oQTpvaEw14apK6WSurOexJ3O0/lWyCu4BvePLrx/Hv/LeBcgR6w3UnB4wVx0sxY+ xhXuMiV/gPRzCb8W7ZcKbj2EUoaMHx+7yOSY92XO9H83cjERJ0QuZNljebw83v+VeVzW tXmfBpK2R6CTXhA1MNFQ04Cy+aePQyP10YWFQMD7i9Q2dIMNuvX0qidMamk+CN6nmAuy IIc0S954Kwa6xOussD/EX7tBZzAe5XK609hYuNkTr0DJkUed3Tw/0NYa5WR6fuch0vqU 1GsWh4qP61IhkVLOF/oVxTh/fBAFKyOZjzXPRfAPz5rbjPpk35dbvH0Dw57kBp37g73M u5kQ== X-Gm-Message-State: APjAAAUnzl5RAo6xoJA2huMPM2pYWRbgsNgM03n+2x2W8Onht/68z9Ko SM0dbCXZ755LG/ietsEr2Ks= X-Google-Smtp-Source: APXvYqz5QB5KbH7ouKCsYRcBx7vHfkREoBFOhQIyPNHIK9IoBYbDdNs3l1ALOgJ1mlD2tgMMN01Dog== X-Received: by 2002:a63:f13:: with SMTP id e19mr1283835pgl.135.1582840433706; Thu, 27 Feb 2020 13:53:53 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id q4sm8748395pfl.175.2020.02.27.13.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 13:53:52 -0800 (PST) Date: Thu, 27 Feb 2020 13:53:51 -0800 From: Minchan Kim To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Nitin Gupta , Sergey Senozhatsky , Andrew Morton , "open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR" Subject: Re: [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag() Message-ID: <20200227215351.GE215068@google.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> <20200214204741.94112-14-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214204741.94112-14-jbi.octave@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 14, 2020 at 08:47:24PM +0000, Jules Irenge wrote: > Sparse reports a warning at unpin_tag()() > > warning: context imbalance in unpin_tag() - unexpected unlock > > The root cause is the missing annotation at unpin_tag() > Add the missing __releases(bitlock) annotation > > Signed-off-by: Jules Irenge Acked-by: Minchan Kim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7102AC3F2C0 for ; Thu, 27 Feb 2020 21:53:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 24C802469F for ; Thu, 27 Feb 2020 21:53:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mjmOJ66o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24C802469F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CAB106B0005; Thu, 27 Feb 2020 16:53:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5CAF6B0006; Thu, 27 Feb 2020 16:53:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B738F6B000A; Thu, 27 Feb 2020 16:53:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 9F9E56B0005 for ; Thu, 27 Feb 2020 16:53:55 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 733D3181AEF10 for ; Thu, 27 Feb 2020 21:53:55 +0000 (UTC) X-FDA: 76537260030.02.club24_3f4fcda2ff33c X-HE-Tag: club24_3f4fcda2ff33c X-Filterd-Recvd-Size: 3654 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Feb 2020 21:53:54 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id 7so379913pgr.2 for ; Thu, 27 Feb 2020 13:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7dwQH34KOZabRYRAwZrdnJHMAH3aJ68bic4ZknrTLvQ=; b=mjmOJ66owX0Df96b/m5GC1crg6u5wtB1ayeppKZj6Rh3bevN9Nj/By2G3ScTRQpKn7 l+QLMQJsMBwlF1Zv2iBkFTRR4zrlvvcKN2MrL/R6n5r9pc/SRafnlN/oxqFg3CCvhFkw x3rKHRm5o1xq8zpLmYfzBSkrODdyNgBksE58gfKBjFofl3sAgeX9ZF9lhTfstRzvzgUO vXWIH65KMcmLCNHHgxg6IbeiXN1IFExj7wyNO1eYaAQAjFUveBoFv0WbPqH0pukyHoAN a6tDVZmzsPqplyKO/DIOOkWvoHUxTBq3BZ2DbwpFclx7qXI34rd0ey+jlA1W2Rylis/C pNsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=7dwQH34KOZabRYRAwZrdnJHMAH3aJ68bic4ZknrTLvQ=; b=KzArsjZfrsCwsdJ0yjL0xxiBmM70gPVWcflZJAnm+RQOS0D1XupMSjH+Rodtwzq48B Pps8QYUj25il1+s0JZhqzPXjTh2TlWiyB7Bt+YQEh/DzlSX7yW1jbw8mR7n+NGwdi5jS gT3C2NrdPiHSQ8Phb+97dxKbO0BMqM1xI3J7/1uSTDtAufQwUU0qewIk1UjouiY5cn67 hRqD8WYil10z89YwCth8JDUmHAyIJebD7z7fB+TRBQW18raCRB6iyRqm4tDGu4XQGZfY SYeHwOBXSQo72s0TsCYLqnle6nL0jeBbEpkwKlh/47sjQ2Dpm+cHM4y/8msXos50AYgR iltA== X-Gm-Message-State: APjAAAWuaJVwuxNR0IxAK3MEMAzq5DxLdUTQwFk7TnAmvdZhgyXWmY6R b+9wCZKiwwv0NMJQmbQSW2E= X-Google-Smtp-Source: APXvYqz5QB5KbH7ouKCsYRcBx7vHfkREoBFOhQIyPNHIK9IoBYbDdNs3l1ALOgJ1mlD2tgMMN01Dog== X-Received: by 2002:a63:f13:: with SMTP id e19mr1283835pgl.135.1582840433706; Thu, 27 Feb 2020 13:53:53 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id q4sm8748395pfl.175.2020.02.27.13.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 13:53:52 -0800 (PST) Date: Thu, 27 Feb 2020 13:53:51 -0800 From: Minchan Kim To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Nitin Gupta , Sergey Senozhatsky , Andrew Morton , "open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR" Subject: Re: [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag() Message-ID: <20200227215351.GE215068@google.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> <20200214204741.94112-14-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214204741.94112-14-jbi.octave@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 14, 2020 at 08:47:24PM +0000, Jules Irenge wrote: > Sparse reports a warning at unpin_tag()() > > warning: context imbalance in unpin_tag() - unexpected unlock > > The root cause is the missing annotation at unpin_tag() > Add the missing __releases(bitlock) annotation > > Signed-off-by: Jules Irenge Acked-by: Minchan Kim