From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 741A2C3F2CB for ; Thu, 27 Feb 2020 22:42:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A220246A1 for ; Thu, 27 Feb 2020 22:42:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qn+7NLia" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730191AbgB0Wm4 (ORCPT ); Thu, 27 Feb 2020 17:42:56 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:37999 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729722AbgB0Wm4 (ORCPT ); Thu, 27 Feb 2020 17:42:56 -0500 Received: by mail-pg1-f196.google.com with SMTP id d6so432595pgn.5; Thu, 27 Feb 2020 14:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eC6XULGo71DkkbKYMEVa3CebZbR3YIk7hU1LZdfvH4Y=; b=qn+7NLiaVpezukxBzFBwfG+epP+sfl+YlsORRJxCCoojrQj/h+YkBxM3i6YDE0AQJs P7T7DFMTB9R1RXIaeliDZ/dyWhM6CuLv2kO/sytHwO7bES5aZttcq2BrppClH47OLbih 8glkk1PmO0wSymairAZIAQPbdboYTf0jc9+6madbyvW0p84zWN/JxZ4udBJCDn6mRfqt jd9n5MmIClzXAQ9CHp/v1tEiTBrPm4tZ7i/cyZuEmoDelTi8Iz9b5FAUMOXDPMbqEEX7 ODi3nQW4+kEH1AhkrhqS4TXIZWBBmPcmnkuQblEIuHdpsioRqGi/GZZCFJdDdpOtidJT pm8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eC6XULGo71DkkbKYMEVa3CebZbR3YIk7hU1LZdfvH4Y=; b=b7aYEwX4WDGDY/hP/9piEacxS6zPH951CkLkqdCdqtPjMLF8Z/sveErZQhDiyN4Pu0 GntDIpl8+knW/fE40Iy3xPMU/AIW+tCQoVmHhd25uEDmKU5OCsqSid7K4fGPKGkihjxq 3IYN98my5W8Lqx3x0/qbgDfHR8eLkN5mOXw1wJFHop7D2lAyTTxAyjlbsIJgjr/qTFw/ M3736BGPUiPs13Zf+Me7Rpe0WLRe+JLJl6N8ZDxOhVQ+EJdrEhHpe2ydHoMaBgdxw4Xy kL/KwmX8xna482aQSXVtq9Ndl/eBeaelG+6XjSSxqZ9sYLDsKNy3zYRwkgDzbrR4XZ/j wDpw== X-Gm-Message-State: APjAAAUpMUgUFs7Nd8vQej6EzztBlsZWpkMk4gm3FB7//9jSJhYCDA2Y kY2c8FlYcsYmjMxQUTs9OCk= X-Google-Smtp-Source: APXvYqzGTM6O1kzlusq2+UBm7XJw4SAY63lpqMM/UumlDNsXPcBi96eO1OrkgnLHxCGovebuWsNzJg== X-Received: by 2002:a63:990a:: with SMTP id d10mr1562744pge.63.1582843374849; Thu, 27 Feb 2020 14:42:54 -0800 (PST) Received: from taoren-ubuntu-R90MNF91 ([2620:10d:c090:500::4:d8f5]) by smtp.gmail.com with ESMTPSA id a22sm8278610pfk.108.2020.02.27.14.42.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Feb 2020 14:42:54 -0800 (PST) Date: Thu, 27 Feb 2020 14:42:51 -0800 From: Tao Ren To: Rob Herring Cc: Felipe Balbi , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , Benjamin Herrenschmidt , Chunfeng Yun , Colin Ian King , Stephen Boyd , Mark Rutland , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, taoren@fb.com Subject: Re: [PATCH v4 7/7] dt-bindings: usb: add documentation for aspeed usb-vhub Message-ID: <20200227224250.GC29420@taoren-ubuntu-R90MNF91> References: <20200226230346.672-1-rentao.bupt@gmail.com> <20200226230346.672-8-rentao.bupt@gmail.com> <20200227165504.GA26955@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200227165504.GA26955@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Thu, Feb 27, 2020 at 10:55:04AM -0600, Rob Herring wrote: > On Wed, 26 Feb 2020 15:03:46 -0800, rentao.bupt@gmail.com wrote: > > From: Tao Ren > > > > Add device tree binding documentation for aspeed usb-vhub driver. > > > > Signed-off-by: Tao Ren > > --- > > No change in v2/v3/v4: > > - the patch is added to the patch series since v4. > > > > .../bindings/usb/aspeed,usb-vhub.yaml | 71 +++++++++++++++++++ > > 1 file changed, 71 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.example.dt.yaml: usb-vhub@1e6a0000: 'aspeed,vhub-downstream-ports' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.example.dt.yaml: usb-vhub@1e6a0000: 'aspeed,vhub-generic-endpoints' is a required property > > See https://patchwork.ozlabs.org/patch/1245388 > Please check and re-submit. I ran "make dt_binding_check" in my local environment and don't see the failures. The 2 properties are introduced in this patch set and I add the properties in aspeed-g4/5/6 dtsi files (patch #4, #5 and #6): am I missing something? Sorry I forgot to add you when including the dt-binding document to the series v4: will add you and all dt binding maintainers in v5 soon. Cheers, Tao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C5D4C3F2C2 for ; Thu, 27 Feb 2020 22:43:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D02A246A1 for ; Thu, 27 Feb 2020 22:43:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DhxvuArc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qn+7NLia" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D02A246A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ne59MxPUhNKHfG12Hie6kuUegF9BlFsZsm51SKnQrPI=; b=DhxvuArcqdAvIc fcpzSUYrVYIfAaGTdnvVLkLNj88DMoGehjmS1K9ocxv2XiauIn+kX/NlBtYiWDnnho+D3vkqKjnPZ LS3sliXhxDyA47tyD4QjG4rOVYGyZss4dEcNJyRwLOrR70w2MZEkaadQcAPXC4a/yku/Sp2kuo3bB TA5Sox5Xhv0Mzy7X+ONEQMf2FJzw9/ocrQxADHjkn5LSh9Qkm0+T41uEwU+A86sV1FzFhGy/BvEph UlKzkQL+KmwPhTAu6ccEs3mjAeNHWuTTbP3grcnzZYevDgFzGoTxz7m4P4pTJew8HipizQnIe4IHI jEx7254ghwYrK2otgoHg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7Rrv-0007rZ-Ae; Thu, 27 Feb 2020 22:42:59 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7Rrr-0007qz-Px for linux-arm-kernel@lists.infradead.org; Thu, 27 Feb 2020 22:42:57 +0000 Received: by mail-pg1-x542.google.com with SMTP id b1so421655pgm.8 for ; Thu, 27 Feb 2020 14:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eC6XULGo71DkkbKYMEVa3CebZbR3YIk7hU1LZdfvH4Y=; b=qn+7NLiaVpezukxBzFBwfG+epP+sfl+YlsORRJxCCoojrQj/h+YkBxM3i6YDE0AQJs P7T7DFMTB9R1RXIaeliDZ/dyWhM6CuLv2kO/sytHwO7bES5aZttcq2BrppClH47OLbih 8glkk1PmO0wSymairAZIAQPbdboYTf0jc9+6madbyvW0p84zWN/JxZ4udBJCDn6mRfqt jd9n5MmIClzXAQ9CHp/v1tEiTBrPm4tZ7i/cyZuEmoDelTi8Iz9b5FAUMOXDPMbqEEX7 ODi3nQW4+kEH1AhkrhqS4TXIZWBBmPcmnkuQblEIuHdpsioRqGi/GZZCFJdDdpOtidJT pm8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eC6XULGo71DkkbKYMEVa3CebZbR3YIk7hU1LZdfvH4Y=; b=Sbk/Xc5xcZ9WkYjOCOGFNiaTCIIXSGJmwlmJ1k6zKttbt/d0jGuUp+Pxy5jzmFI0vq jO730xqMx2J769Cft74RLpFZNzBLNXeogh4We2f54p/OLQe7/whwBW86LVzm2R+eBVx1 KL2V7P5H13NDlu4cYxLCsoQjvq70WGI+EFBa/MMFlpPFmMb6PaZkvBX/H3sS3A0AFJmR AqPrkq2lE981XqnVUOzu9sk+uCQErLrX8KSGY0Y7mAUnr0JoJQ3eK/Y28zFWIlTEq78x XxHpzduCdGSxce23Z1OFh4wtWSLb/3qryAwFr3Rl6WlIKoT/8vwrMokvmJOi759Uf7HH jLbw== X-Gm-Message-State: APjAAAUui/g0K3AkklIYheiJX+mxCwDuO4RLhYdOY/cl+M1hIGujc9e3 gOdhRNRcUuACRzs0MUsK2LQ= X-Google-Smtp-Source: APXvYqzGTM6O1kzlusq2+UBm7XJw4SAY63lpqMM/UumlDNsXPcBi96eO1OrkgnLHxCGovebuWsNzJg== X-Received: by 2002:a63:990a:: with SMTP id d10mr1562744pge.63.1582843374849; Thu, 27 Feb 2020 14:42:54 -0800 (PST) Received: from taoren-ubuntu-R90MNF91 ([2620:10d:c090:500::4:d8f5]) by smtp.gmail.com with ESMTPSA id a22sm8278610pfk.108.2020.02.27.14.42.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Feb 2020 14:42:54 -0800 (PST) Date: Thu, 27 Feb 2020 14:42:51 -0800 From: Tao Ren To: Rob Herring Subject: Re: [PATCH v4 7/7] dt-bindings: usb: add documentation for aspeed usb-vhub Message-ID: <20200227224250.GC29420@taoren-ubuntu-R90MNF91> References: <20200226230346.672-1-rentao.bupt@gmail.com> <20200226230346.672-8-rentao.bupt@gmail.com> <20200227165504.GA26955@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200227165504.GA26955@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200227_144255_866822_2AE96805 X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Felipe Balbi , linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org, Andrew Jeffery , Benjamin Herrenschmidt , openbmc@lists.ozlabs.org, linux-usb@vger.kernel.org, taoren@fb.com, linux-kernel@vger.kernel.org, Stephen Boyd , Joel Stanley , Greg Kroah-Hartman , Chunfeng Yun , Colin Ian King , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Thu, Feb 27, 2020 at 10:55:04AM -0600, Rob Herring wrote: > On Wed, 26 Feb 2020 15:03:46 -0800, rentao.bupt@gmail.com wrote: > > From: Tao Ren > > > > Add device tree binding documentation for aspeed usb-vhub driver. > > > > Signed-off-by: Tao Ren > > --- > > No change in v2/v3/v4: > > - the patch is added to the patch series since v4. > > > > .../bindings/usb/aspeed,usb-vhub.yaml | 71 +++++++++++++++++++ > > 1 file changed, 71 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.example.dt.yaml: usb-vhub@1e6a0000: 'aspeed,vhub-downstream-ports' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.example.dt.yaml: usb-vhub@1e6a0000: 'aspeed,vhub-generic-endpoints' is a required property > > See https://patchwork.ozlabs.org/patch/1245388 > Please check and re-submit. I ran "make dt_binding_check" in my local environment and don't see the failures. The 2 properties are introduced in this patch set and I add the properties in aspeed-g4/5/6 dtsi files (patch #4, #5 and #6): am I missing something? Sorry I forgot to add you when including the dt-binding document to the series v4: will add you and all dt binding maintainers in v5 soon. Cheers, Tao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel