From: Vadym Kochan <vadym.kochan@plvision.eu>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jiri Pirko <jiri@resnulli.us>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Serhiy Boiko <serhiy.boiko@plvision.eu>,
Andrii Savka <andrii.savka@plvision.eu>,
Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>
Subject: Re: [RFC net-next 1/3] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX325x (AC3x)
Date: Thu, 27 Feb 2020 23:50:58 +0000 [thread overview]
Message-ID: <20200227235048.GA21304@plvision.eu> (raw)
In-Reply-To: <20200227214357.GB29979@lunn.ch>
On Thu, Feb 27, 2020 at 10:43:57PM +0100, Andrew Lunn wrote:
> > > Please be consistent. Make your prefixes, name, filenames the same.
> > > For example:
> > > prestera_driver_kind[] = "prestera";
> > >
> > > Applied to the whole code.
> > >
> > So you suggested to use prestera_ as a prefix, I dont see a problem
> > with that, but why not mvsw_pr_ ? So it has the vendor, device name parts
> > together as a key. Also it is necessary to apply prefix for the static
> > names ?
>
> Although static names don't cause linker issues, you do still see them
> in opps stack traces, etc. It just helps track down where the symbols
> come from, if they all have a prefix.
>
> Andrew
Sure, thanks, makes sense. But is it necessary that prefix should match
filenames too ? Would it be OK to use just 'mvpr_' instead of 'prestera_'
for funcs & types in this particular case ?
Regards,
Vadym Kochan
next prev parent reply other threads:[~2020-02-27 23:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 16:30 [RFC net-next 0/3] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x) Vadym Kochan
2020-02-25 16:30 ` [RFC net-next 1/3] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX325x (AC3x) Vadym Kochan
2020-02-25 22:05 ` Andrew Lunn
2020-02-26 15:54 ` Jiri Pirko
2020-02-27 21:32 ` Vadym Kochan
2020-02-27 21:43 ` Andrew Lunn
2020-02-27 23:50 ` Vadym Kochan [this message]
2020-02-28 6:36 ` Jiri Pirko
2020-02-28 14:03 ` Andrew Lunn
2020-02-28 6:34 ` Jiri Pirko
2020-02-28 9:44 ` Vadym Kochan
2020-02-28 10:59 ` Jiri Pirko
2020-02-27 14:22 ` Jiri Pirko
2020-02-28 8:06 ` Vadym Kochan
2020-02-28 11:03 ` Jiri Pirko
2020-02-28 4:22 ` Florian Fainelli
2020-02-28 8:17 ` Vadym Kochan
2020-03-05 14:49 ` Ido Schimmel
2020-05-02 15:20 ` Vadym Kochan
2020-05-05 4:01 ` Vadym Kochan
2020-02-25 16:30 ` [RFC net-next 2/3] net: marvell: prestera: Add PCI interface support Vadym Kochan
2020-02-25 20:49 ` Andrew Lunn
2020-02-27 11:05 ` Jiri Pirko
2020-02-28 16:54 ` Vadym Kochan
2020-02-29 7:58 ` Jiri Pirko
2020-03-01 2:12 ` Jakub Kicinski
2020-03-09 19:44 ` kbuild test robot
2020-02-25 16:30 ` [RFC net-next 3/3] dt-bindings: marvell,prestera: Add address mapping for Prestera Switchdev PCIe driver Vadym Kochan
2020-02-28 4:24 ` Florian Fainelli
2020-02-25 22:12 ` [RFC net-next 0/3] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x) Andrew Lunn
2020-02-25 22:45 ` Chris Packham
2020-02-28 16:50 ` Vadym Kochan
2020-02-26 15:44 ` Jiri Pirko
2020-02-26 16:38 ` Roopa Prabhu
2020-03-05 15:01 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227235048.GA21304@plvision.eu \
--to=vadym.kochan@plvision.eu \
--cc=andrew@lunn.ch \
--cc=andrii.savka@plvision.eu \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=serhiy.boiko@plvision.eu \
--cc=serhiy.pshyk@plvision.eu \
--cc=taras.chornyi@plvision.eu \
--cc=volodymyr.mytnyk@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.