All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/4] lib: Check also flags for tst_res()
Date: Fri, 28 Feb 2020 08:05:06 +0100	[thread overview]
Message-ID: <20200228070506.GA23156@dell5510> (raw)
In-Reply-To: <CAEemH2fTYf91KP6_Kf343taLmoGeTuOvNJWVr1qf5C-02+CZpQ@mail.gmail.com>

Hi Li,

> Thanks for your work on this!
Thanks for your review!

...
> > +++ b/include/tst_common.h
> > @@ -77,4 +77,7 @@
> >  #define TST_BRK_SUPPORTS_ONLY_TCONF_TBROK(condition) \
> >         do { ((void)sizeof(char[1 - 2 * !!(condition)])); } while (0)

> > +#define TST_RES_SUPPORTS_TCONF_TFAIL_TINFO_TPASS_TWARN(condition) \
> > +       TST_BRK_SUPPORTS_ONLY_TCONF_TBROK(condition)


> To be honest, this looks verbose and confusing a little. I'm thinking can
> we just add a prefix TST_ to the kernel macro and use it directly?

> e.g

> #define TST_BUILD_BUG_ON(condition) \
>         do { ((void)sizeof(char[1 - 2 * !!(condition)])); } while (0)
Yep, I was also thinking to get back to the original name BUILD_BUG_ON().
TST_BUILD_BUG_ON() is even better (although I considered TST_ as part of public
API, this is internal implementation).

Kind regards,
Petr

  reply	other threads:[~2020-02-28  7:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 16:39 [LTP] [PATCH 1/4] Avoid using tst_res(TBROK) Petr Vorel
2020-02-27 16:39 ` [LTP] [PATCH 2/4] lib: Check also flags for tst_res() Petr Vorel
2020-02-28  7:00   ` Li Wang
2020-02-28  7:05     ` Petr Vorel [this message]
2020-02-28 12:13     ` Cyril Hrubis
2020-02-28 13:17       ` Petr Vorel
2020-02-28 14:17         ` Petr Vorel
2020-02-27 16:39 ` [LTP] [PATCH 3/4] doc: Improve flags info Petr Vorel
2020-02-27 16:39 ` [LTP] [PATCH 4/4] doc: Update style guide to new API Petr Vorel
2020-02-28  7:24   ` Li Wang
2020-02-28  8:42     ` Petr Vorel
2020-02-28  9:22       ` Jan Stancek
2020-02-28  9:55         ` Petr Vorel
2020-03-04 11:38           ` Petr Vorel
2020-02-28  7:47 ` [LTP] [PATCH 1/4] Avoid using tst_res(TBROK) Li Wang
2020-02-28  8:46   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200228070506.GA23156@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.