From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99128C3F2D3 for ; Fri, 28 Feb 2020 11:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70164246AA for ; Fri, 28 Feb 2020 11:48:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="dy1vhT7N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726413AbgB1LsK (ORCPT ); Fri, 28 Feb 2020 06:48:10 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:54054 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgB1LsK (ORCPT ); Fri, 28 Feb 2020 06:48:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=c9KhOrq2gOTbKBSsUSPBlkMn2esfMi/WqxI3fnMTFQg=; b=dy1vhT7N6x24wF1cdMc4yum7a KBsbReBNpWhyqcP0/rRJ9UdD8EiqChUIycgPqz5T/fn0nB1cU90Qb4bth45mMhCAXctL/C+vWTw9Y rAvoZHxXT+mvZjkI0K5MNetrYDbGk5IiY5jgzh507kStUsf7OvZ2fmzNEQzRenm/X3+zv/JBGQ2W2 7nFOH8xQozhgS98rljsazB4RWAQonUg3AK/qS6hdmtV04psfu0TzMtQJpvO6nUWFgblp8IrnvEJaq R6nAZZ9QQFmmbqN0p/jsqPuDTnEuhN2PMC0HyszetcRuFTJhmWzhpEXqfl/KremAV5sxieUuNOvUs hbYUoIlJQ==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:46392) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j7e7Y-0003aI-Rb; Fri, 28 Feb 2020 11:47:57 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j7e7V-0001xQ-Ew; Fri, 28 Feb 2020 11:47:53 +0000 Date: Fri, 28 Feb 2020 11:47:53 +0000 From: Russell King - ARM Linux admin To: Oleksij Rempel Cc: Chris Snook , Jay Cliburn , Pengutronix Kernel Team , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, Vivien Didelot Subject: Re: [PATCH v8 1/1] net: ag71xx: port to phylink Message-ID: <20200228114753.GN18808@shell.armlinux.org.uk> References: <20200226054624.14199-1-o.rempel@pengutronix.de> <20200226092138.GV25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226092138.GV25745@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 26, 2020 at 09:21:38AM +0000, Russell King - ARM Linux admin wrote: > On Wed, Feb 26, 2020 at 06:46:24AM +0100, Oleksij Rempel wrote: > > The port to phylink was done as close as possible to initial > > functionality. > > > > Signed-off-by: Oleksij Rempel > > --- > > changes v8: > > - set the autoneg bit > > - provide implementations for the mac_pcs_get_state and mac_an_restart > > methods > > - do phylink_disconnect_phy() on _stop() > > - rename ag71xx_phy_setup() to ag71xx_phylink_setup() > > There will be one more change required; I'm changing the prototype for > the mac_link_up() function, and I suggest as you don't support in-band > AN that most of the setup for speed and duplex gets moved out of your > mac_config() implementation to mac_link_up(). > > The patches have been available on netdev for just over a week now. The patches are now in net-next. Please respin your patch against these changes, which basically means the code which programs the speed and duplex in ag71xx_mac_config() needs to be moved to ag71xx_mac_link_up(). Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up