From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B00C3F2CD for ; Fri, 28 Feb 2020 13:56:58 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64431246AE for ; Fri, 28 Feb 2020 13:56:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NOpNE0o8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64431246AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 390B4857C2; Fri, 28 Feb 2020 13:56:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7vAiS4ReiGAg; Fri, 28 Feb 2020 13:56:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 454388550D; Fri, 28 Feb 2020 13:56:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3F91FC1D84; Fri, 28 Feb 2020 13:56:57 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2F387C0177 for ; Fri, 28 Feb 2020 13:56:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1C1C7861C7 for ; Fri, 28 Feb 2020 13:56:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vV-DonAyz_m1 for ; Fri, 28 Feb 2020 13:56:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 02BBB86141 for ; Fri, 28 Feb 2020 13:56:55 +0000 (UTC) Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA55C2051A; Fri, 28 Feb 2020 13:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582898214; bh=ZU+rG3/lVhcg+pzaISBduhlJvAnXlVfNLTn4KsAAEvI=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=NOpNE0o8IqHzcn4zf7Hcc4rLX+FV3gUR9JYfhPZ9Dgmhfts7krwNn5vBEKSRpVnMH pOxmn7l2Z/IwWJCMCv5A23jEa5s72VvrzsKIdshJASdp5Vu5Z8yesDUFJ0w25cXf7c g0GsPssS4RoBQhqEqTMmDP2ISV9YKFSX+M2yE36E= Date: Fri, 28 Feb 2020 13:56:46 +0000 From: Will Deacon To: Andre Przywara Subject: Re: [RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk Message-ID: <20200228135645.GA4745@willie-the-truck> References: <20200218171321.30990-1-robh@kernel.org> <20200218171321.30990-7-robh@kernel.org> <20200218172000.GF1133@willie-the-truck> <20200228100446.GA2395@willie-the-truck> <20200228102556.1dde016e@donnerap.cambridge.arm.com> <20200228105024.GC2395@willie-the-truck> <20200228134254.03fc5e1b@donnerap.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200228134254.03fc5e1b@donnerap.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: Cc: Mark Langsdorf , kvm@vger.kernel.org, Viresh Kumar , "open list:LIBATA SUBSYSTEM \(Serial and Parallel ATA drivers\)" , linux-clk , Rob Herring , soc@kernel.org, Daniel Lezcano , devicetree@vger.kernel.org, Jon Loeliger , "open list:THERMAL" , Alex Williamson , Tony Luck , Alexander Graf , Mauro Carvalho Chehab , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-edac , Jens Axboe , Matthias Brugger , Stephen Boyd , netdev , Cornelia Huck , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Linux IOMMU , Robert Richter , James Morse , Borislav Petkov , Robin Murphy , "David S. Miller" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Feb 28, 2020 at 01:42:54PM +0000, Andre Przywara wrote: > On Fri, 28 Feb 2020 10:50:25 +0000 > Will Deacon wrote: > > On Fri, Feb 28, 2020 at 10:25:56AM +0000, Andre Przywara wrote: > > > > On Tue, Feb 25, 2020 at 04:01:54PM -0600, Rob Herring wrote: > > > > > Seems we're leaving the platform support for now, but I think we never > > > > > actually enabled SMMU support. It's not in the dts either in mainline > > > > > nor the version I have which should be close to what shipped in > > > > > firmware. So as long as Andre agrees, this one is good to apply. > > > > > > > > Andre? Can I queue this one for 5.7, please? > > > > > > I was wondering how much of a pain it is to keep it in? AFAICS there are > > > other users of the "impl" indirection. If those goes away, I would be > > > happy to let Calxeda go. > > > > The impl stuff is new, so we'll keep it around. The concern is more about > > testing (see below). > > > > > But Eric had the magic DT nodes to get the SMMU working, and I used that > > > before, with updating the DT either on flash or dynamically via U-Boot. > > > > What did you actually use the SMMU for, though? The > > 'arm_iommu_create_mapping()' interface isn't widely used and, given that > > highbank doesn't support KVM, the use-cases for VFIO are pretty limited > > too. > > AFAIK Highbank doesn't have the SMMU, probably mostly for that reason. > I have a DT snippet for Midway, and that puts the MMIO base at ~36GB, which is not possible on Highbank. > So I think that the quirk is really meant and needed for Midway. Sorry, but I don't follow your reasoning here. The MMIO base has nothing to do with the quirk, although doing some digging it looks like your conclusion about this applying to Midway (ecx-2000?) is correct: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-January/226095.html > > > So I don't know exactly *how* desperate you are with removing this, or if > > > there are other reasons than "negative diffstat", but if possible I would > > > like to keep it in. > > > > It's more that we *do* make quite a lot of changes to the arm-smmu driver > > and it's never tested with this quirk. If you're stepping up to run smmu > > tests on my queue for each release on highbank, then great, but otherwise > > I'd rather not carry the code for fun. The change in diffstat is minimal > > (we're going to need to hooks for nvidia, who broke things in a different > > way). > > I am about to set up some more sophisticated testing, and will include > some SMMU bits in it. Yes, please. Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78074C3F2D2 for ; Fri, 28 Feb 2020 13:57:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB0DB246AC for ; Fri, 28 Feb 2020 13:57:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qPbZewXI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NOpNE0o8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB0DB246AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EAOL9h/jF2pJXHnP2pMRJVs5u1mxxZcx/I9DtjkLLHA=; b=qPbZewXIElri+K kj22Axi1GR3AhcvLbszgyWhi6/NtJQCYeUHlGUNnQR44xQt+6oReAnf2k7ulOkE2qW15G4hzPxxXW Sz6KbWt+TeXg5W6/rCVz/0MGb38VvhUeLsGNofxiqhlQ0M25tpRmhxufNAwYmfgI2JKOn0kCjeuX4 n12dMpnwjY/VBgnrqd2/5O76MlpaoTWuVW3k7Lz6QTEO/wVfe5j6j76ot5bKdzhwYiDa82c5LgS7e heOR168wR5u3fYzfOmK1Fmj0Nir9WsXnxT0Mvs9d85U7wM8LFs02sa6ALWjkI56MJNopZBCQWp8BY Gedf0mvS5JFjV4QHYOxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7g8S-0000IL-Cy; Fri, 28 Feb 2020 13:57:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j7g8N-0000Cn-Jc for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2020 13:56:57 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA55C2051A; Fri, 28 Feb 2020 13:56:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582898214; bh=ZU+rG3/lVhcg+pzaISBduhlJvAnXlVfNLTn4KsAAEvI=; h=Date:From:To:List-Id:Cc:Subject:References:In-Reply-To:From; b=NOpNE0o8IqHzcn4zf7Hcc4rLX+FV3gUR9JYfhPZ9Dgmhfts7krwNn5vBEKSRpVnMH pOxmn7l2Z/IwWJCMCv5A23jEa5s72VvrzsKIdshJASdp5Vu5Z8yesDUFJ0w25cXf7c g0GsPssS4RoBQhqEqTMmDP2ISV9YKFSX+M2yE36E= Date: Fri, 28 Feb 2020 13:56:46 +0000 From: Will Deacon To: Andre Przywara Subject: Re: [RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk Message-ID: <20200228135645.GA4745@willie-the-truck> References: <20200218171321.30990-1-robh@kernel.org> <20200218171321.30990-7-robh@kernel.org> <20200218172000.GF1133@willie-the-truck> <20200228100446.GA2395@willie-the-truck> <20200228102556.1dde016e@donnerap.cambridge.arm.com> <20200228105024.GC2395@willie-the-truck> <20200228134254.03fc5e1b@donnerap.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200228134254.03fc5e1b@donnerap.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200228_055655_691516_06D9BEC0 X-CRM114-Status: GOOD ( 29.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: Mark Langsdorf , kvm@vger.kernel.org, Viresh Kumar , "open list:LIBATA SUBSYSTEM \(Serial and Parallel ATA drivers\)" , linux-clk , Rob Herring , soc@kernel.org, Joerg Roedel , Daniel Lezcano , devicetree@vger.kernel.org, Jon Loeliger , "open list:THERMAL" , Eric Auger , Alex Williamson , Tony Luck , Alexander Graf , Mauro Carvalho Chehab , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-edac , Jens Axboe , Matthias Brugger , Stephen Boyd , netdev , Cornelia Huck , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Linux IOMMU , Robert Richter , James Morse , Borislav Petkov , Robin Murphy , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 28, 2020 at 01:42:54PM +0000, Andre Przywara wrote: > On Fri, 28 Feb 2020 10:50:25 +0000 > Will Deacon wrote: > > On Fri, Feb 28, 2020 at 10:25:56AM +0000, Andre Przywara wrote: > > > > On Tue, Feb 25, 2020 at 04:01:54PM -0600, Rob Herring wrote: > > > > > Seems we're leaving the platform support for now, but I think we never > > > > > actually enabled SMMU support. It's not in the dts either in mainline > > > > > nor the version I have which should be close to what shipped in > > > > > firmware. So as long as Andre agrees, this one is good to apply. > > > > > > > > Andre? Can I queue this one for 5.7, please? > > > > > > I was wondering how much of a pain it is to keep it in? AFAICS there are > > > other users of the "impl" indirection. If those goes away, I would be > > > happy to let Calxeda go. > > > > The impl stuff is new, so we'll keep it around. The concern is more about > > testing (see below). > > > > > But Eric had the magic DT nodes to get the SMMU working, and I used that > > > before, with updating the DT either on flash or dynamically via U-Boot. > > > > What did you actually use the SMMU for, though? The > > 'arm_iommu_create_mapping()' interface isn't widely used and, given that > > highbank doesn't support KVM, the use-cases for VFIO are pretty limited > > too. > > AFAIK Highbank doesn't have the SMMU, probably mostly for that reason. > I have a DT snippet for Midway, and that puts the MMIO base at ~36GB, which is not possible on Highbank. > So I think that the quirk is really meant and needed for Midway. Sorry, but I don't follow your reasoning here. The MMIO base has nothing to do with the quirk, although doing some digging it looks like your conclusion about this applying to Midway (ecx-2000?) is correct: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-January/226095.html > > > So I don't know exactly *how* desperate you are with removing this, or if > > > there are other reasons than "negative diffstat", but if possible I would > > > like to keep it in. > > > > It's more that we *do* make quite a lot of changes to the arm-smmu driver > > and it's never tested with this quirk. If you're stepping up to run smmu > > tests on my queue for each release on highbank, then great, but otherwise > > I'd rather not carry the code for fun. The change in diffstat is minimal > > (we're going to need to hooks for nvidia, who broke things in a different > > way). > > I am about to set up some more sophisticated testing, and will include > some SMMU bits in it. Yes, please. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel