From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: a.hajda@samsung.com, jonas@kwiboo.se, jernej.skrabec@siol.net,
boris.brezillon@collabora.com, linux-amlogic@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 06/11] drm/meson: venc: make drm_display_mode const
Date: Mon, 2 Mar 2020 11:59:02 +0200 [thread overview]
Message-ID: <20200302095902.GA16626@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200206191834.6125-7-narmstrong@baylibre.com>
Hi Neil,
Thank you for the patch.
On Thu, Feb 06, 2020 at 08:18:29PM +0100, Neil Armstrong wrote:
> Before switching to bridge funcs, make sure drm_display_mode is passed
> as const to the venc functions.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/meson/meson_venc.c | 2 +-
> drivers/gpu/drm/meson/meson_venc.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 4efd7864d5bf..a9ab78970bfe 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -946,7 +946,7 @@ bool meson_venc_hdmi_venc_repeat(int vic)
> EXPORT_SYMBOL_GPL(meson_venc_hdmi_venc_repeat);
>
> void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
> - struct drm_display_mode *mode)
> + const struct drm_display_mode *mode)
> {
> union meson_hdmi_venc_mode *vmode = NULL;
> union meson_hdmi_venc_mode vmode_dmt;
> diff --git a/drivers/gpu/drm/meson/meson_venc.h b/drivers/gpu/drm/meson/meson_venc.h
> index 576768bdd08d..1abdcbdf51c0 100644
> --- a/drivers/gpu/drm/meson/meson_venc.h
> +++ b/drivers/gpu/drm/meson/meson_venc.h
> @@ -60,7 +60,7 @@ extern struct meson_cvbs_enci_mode meson_cvbs_enci_ntsc;
> void meson_venci_cvbs_mode_set(struct meson_drm *priv,
> struct meson_cvbs_enci_mode *mode);
> void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
> - struct drm_display_mode *mode);
> + const struct drm_display_mode *mode);
> unsigned int meson_venci_get_field(struct meson_drm *priv);
>
> void meson_venc_enable_vsync(struct meson_drm *priv);
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: jernej.skrabec@siol.net, jonas@kwiboo.se,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
a.hajda@samsung.com, boris.brezillon@collabora.com,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v4 06/11] drm/meson: venc: make drm_display_mode const
Date: Mon, 2 Mar 2020 11:59:02 +0200 [thread overview]
Message-ID: <20200302095902.GA16626@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200206191834.6125-7-narmstrong@baylibre.com>
Hi Neil,
Thank you for the patch.
On Thu, Feb 06, 2020 at 08:18:29PM +0100, Neil Armstrong wrote:
> Before switching to bridge funcs, make sure drm_display_mode is passed
> as const to the venc functions.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/meson/meson_venc.c | 2 +-
> drivers/gpu/drm/meson/meson_venc.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 4efd7864d5bf..a9ab78970bfe 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -946,7 +946,7 @@ bool meson_venc_hdmi_venc_repeat(int vic)
> EXPORT_SYMBOL_GPL(meson_venc_hdmi_venc_repeat);
>
> void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
> - struct drm_display_mode *mode)
> + const struct drm_display_mode *mode)
> {
> union meson_hdmi_venc_mode *vmode = NULL;
> union meson_hdmi_venc_mode vmode_dmt;
> diff --git a/drivers/gpu/drm/meson/meson_venc.h b/drivers/gpu/drm/meson/meson_venc.h
> index 576768bdd08d..1abdcbdf51c0 100644
> --- a/drivers/gpu/drm/meson/meson_venc.h
> +++ b/drivers/gpu/drm/meson/meson_venc.h
> @@ -60,7 +60,7 @@ extern struct meson_cvbs_enci_mode meson_cvbs_enci_ntsc;
> void meson_venci_cvbs_mode_set(struct meson_drm *priv,
> struct meson_cvbs_enci_mode *mode);
> void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
> - struct drm_display_mode *mode);
> + const struct drm_display_mode *mode);
> unsigned int meson_venci_get_field(struct meson_drm *priv);
>
> void meson_venc_enable_vsync(struct meson_drm *priv);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: jernej.skrabec@siol.net, jonas@kwiboo.se,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
a.hajda@samsung.com, boris.brezillon@collabora.com,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v4 06/11] drm/meson: venc: make drm_display_mode const
Date: Mon, 2 Mar 2020 11:59:02 +0200 [thread overview]
Message-ID: <20200302095902.GA16626@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200206191834.6125-7-narmstrong@baylibre.com>
Hi Neil,
Thank you for the patch.
On Thu, Feb 06, 2020 at 08:18:29PM +0100, Neil Armstrong wrote:
> Before switching to bridge funcs, make sure drm_display_mode is passed
> as const to the venc functions.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/meson/meson_venc.c | 2 +-
> drivers/gpu/drm/meson/meson_venc.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 4efd7864d5bf..a9ab78970bfe 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -946,7 +946,7 @@ bool meson_venc_hdmi_venc_repeat(int vic)
> EXPORT_SYMBOL_GPL(meson_venc_hdmi_venc_repeat);
>
> void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
> - struct drm_display_mode *mode)
> + const struct drm_display_mode *mode)
> {
> union meson_hdmi_venc_mode *vmode = NULL;
> union meson_hdmi_venc_mode vmode_dmt;
> diff --git a/drivers/gpu/drm/meson/meson_venc.h b/drivers/gpu/drm/meson/meson_venc.h
> index 576768bdd08d..1abdcbdf51c0 100644
> --- a/drivers/gpu/drm/meson/meson_venc.h
> +++ b/drivers/gpu/drm/meson/meson_venc.h
> @@ -60,7 +60,7 @@ extern struct meson_cvbs_enci_mode meson_cvbs_enci_ntsc;
> void meson_venci_cvbs_mode_set(struct meson_drm *priv,
> struct meson_cvbs_enci_mode *mode);
> void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
> - struct drm_display_mode *mode);
> + const struct drm_display_mode *mode);
> unsigned int meson_venci_get_field(struct meson_drm *priv);
>
> void meson_venc_enable_vsync(struct meson_drm *priv);
--
Regards,
Laurent Pinchart
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-03-02 9:59 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 19:18 [PATCH v4 00/11] drm/bridge: dw-hdmi: implement bus-format negotiation and YUV420 support Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` [PATCH v4 01/11] drm/bridge: dw-hdmi: set mtmdsclock for deep color Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-03-02 9:05 ` Laurent Pinchart
2020-03-02 9:05 ` Laurent Pinchart
2020-03-02 9:05 ` Laurent Pinchart
2020-03-02 9:21 ` Neil Armstrong
2020-03-02 9:21 ` Neil Armstrong
2020-03-02 9:21 ` Neil Armstrong
2020-03-02 15:54 ` Neil Armstrong
2020-03-02 15:54 ` Neil Armstrong
2020-03-02 15:54 ` Neil Armstrong
2020-03-02 16:01 ` Laurent Pinchart
2020-03-02 16:01 ` Laurent Pinchart
2020-03-02 16:01 ` Laurent Pinchart
2020-02-06 19:18 ` [PATCH v4 02/11] drm/bridge: dw-hdmi: add max bpc connector property Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-17 6:38 ` Jernej Škrabec
2020-02-17 6:38 ` Jernej Škrabec
2020-02-17 6:38 ` Jernej Škrabec
2020-02-21 8:50 ` Neil Armstrong
2020-02-21 8:50 ` Neil Armstrong
2020-02-21 8:50 ` Neil Armstrong
2020-03-02 9:18 ` Laurent Pinchart
2020-03-02 9:18 ` Laurent Pinchart
2020-03-02 9:18 ` Laurent Pinchart
2020-03-02 15:55 ` Neil Armstrong
2020-03-02 15:55 ` Neil Armstrong
2020-03-02 15:55 ` Neil Armstrong
2020-02-06 19:18 ` [PATCH v4 03/11] drm/bridge: dw-hdmi: Plug atomic state hooks to the default implementation Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-07 10:57 ` Boris Brezillon
2020-02-07 10:57 ` Boris Brezillon
2020-02-07 10:57 ` Boris Brezillon
2020-02-09 8:51 ` kbuild test robot
2020-02-09 9:08 ` kbuild test robot
2020-03-02 9:56 ` Laurent Pinchart
2020-03-02 9:56 ` Laurent Pinchart
2020-03-02 9:56 ` Laurent Pinchart
2020-03-02 15:55 ` Neil Armstrong
2020-03-02 15:55 ` Neil Armstrong
2020-03-02 15:55 ` Neil Armstrong
2020-02-06 19:18 ` [PATCH v4 04/11] drm/bridge: synopsys: dw-hdmi: add bus format negociation Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-07 11:02 ` Boris Brezillon
2020-02-07 11:02 ` Boris Brezillon
2020-02-07 11:02 ` Boris Brezillon
2020-02-07 13:36 ` Neil Armstrong
2020-02-07 13:36 ` Neil Armstrong
2020-02-07 13:36 ` Neil Armstrong
2020-02-09 9:32 ` kbuild test robot
2020-02-09 10:01 ` kbuild test robot
2020-02-29 7:42 ` Jernej Škrabec
2020-02-29 7:42 ` Jernej Škrabec
2020-02-29 7:42 ` Jernej Škrabec
2020-02-29 10:09 ` Jonas Karlman
2020-02-29 10:09 ` Jonas Karlman
2020-02-29 10:09 ` Jonas Karlman
2020-02-29 11:07 ` Jernej Škrabec
2020-02-29 11:07 ` Jernej Škrabec
2020-02-29 11:07 ` Jernej Škrabec
2020-02-29 12:15 ` Jonas Karlman
2020-02-29 12:15 ` Jonas Karlman
2020-02-29 12:15 ` Jonas Karlman
2020-02-29 14:42 ` Jernej Škrabec
2020-02-29 14:42 ` Jernej Škrabec
2020-02-29 14:42 ` Jernej Škrabec
2020-03-02 8:08 ` Neil Armstrong
2020-03-02 8:08 ` Neil Armstrong
2020-03-02 8:08 ` Neil Armstrong
2020-03-02 8:04 ` Neil Armstrong
2020-03-02 8:04 ` Neil Armstrong
2020-03-02 8:04 ` Neil Armstrong
2020-03-02 10:18 ` Laurent Pinchart
2020-03-02 10:18 ` Laurent Pinchart
2020-03-02 10:18 ` Laurent Pinchart
2020-03-02 15:57 ` Neil Armstrong
2020-03-02 15:57 ` Neil Armstrong
2020-03-02 15:57 ` Neil Armstrong
2020-02-06 19:18 ` [PATCH v4 05/11] drm/bridge: synopsys: dw-hdmi: allow ycbcr420 modes for >= 0x200a Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-07 13:38 ` Neil Armstrong
2020-02-07 13:38 ` Neil Armstrong
2020-02-07 13:38 ` Neil Armstrong
2020-03-02 10:03 ` Laurent Pinchart
2020-03-02 10:03 ` Laurent Pinchart
2020-03-02 10:03 ` Laurent Pinchart
2020-03-02 15:58 ` Neil Armstrong
2020-03-02 15:58 ` Neil Armstrong
2020-03-02 15:58 ` Neil Armstrong
2020-02-06 19:18 ` [PATCH v4 06/11] drm/meson: venc: make drm_display_mode const Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-07 13:39 ` Neil Armstrong
2020-02-07 13:39 ` Neil Armstrong
2020-02-07 13:39 ` Neil Armstrong
2020-03-02 9:59 ` Laurent Pinchart [this message]
2020-03-02 9:59 ` Laurent Pinchart
2020-03-02 9:59 ` Laurent Pinchart
2020-02-06 19:18 ` [PATCH v4 07/11] drm/meson: meson_dw_hdmi: add bridge and switch to drm_bridge_funcs Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-07 14:57 ` Boris Brezillon
2020-02-07 14:57 ` Boris Brezillon
2020-02-07 14:57 ` Boris Brezillon
2020-02-07 15:36 ` Neil Armstrong
2020-02-07 15:36 ` Neil Armstrong
2020-02-07 15:36 ` Neil Armstrong
2020-02-06 19:18 ` [PATCH v4 08/11] drm/meson: dw-hdmi: stop enforcing input_bus_format Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` [PATCH v4 09/11] drm/meson: venc: add support for YUV420 setup Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` [PATCH v4 10/11] drm/meson: vclk: " Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` [PATCH v4 11/11] drm/meson: Add YUV420 output support Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-06 19:18 ` Neil Armstrong
2020-02-09 13:06 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302095902.GA16626@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.