From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D69C3F2D2 for ; Mon, 2 Mar 2020 14:24:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3849421775 for ; Mon, 2 Mar 2020 14:24:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726988AbgCBOYw (ORCPT ); Mon, 2 Mar 2020 09:24:52 -0500 Received: from mga05.intel.com ([192.55.52.43]:3867 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726969AbgCBOYw (ORCPT ); Mon, 2 Mar 2020 09:24:52 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 06:24:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,507,1574150400"; d="scan'208";a="351551575" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 02 Mar 2020 06:24:46 -0800 Received: by lahna (sSMTP sendmail emulation); Mon, 02 Mar 2020 16:24:46 +0200 Date: Mon, 2 Mar 2020 16:24:45 +0200 From: Mika Westerberg To: Hans de Goede Cc: Andy Shevchenko , Bartosz Golaszewski , Linus Walleij , Marc Lehmann , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 2/4] gpiolib: acpi: Rework honor_wakeup option into an ignore_wake option Message-ID: <20200302142445.GE2667@lahna.fi.intel.com> References: <20200302111225.6641-1-hdegoede@redhat.com> <20200302111225.6641-2-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200302111225.6641-2-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Mar 02, 2020 at 12:12:23PM +0100, Hans de Goede wrote: > Commit aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + > quirk mechanism") was added to deal with spurious wakeups on one specific > model of the HP x2 10 series. > > The approach taken there was to add a bool controlling wakeup support for > all ACPI GPIO events. This was sufficient for the specific HP x2 10 model > the commit was trying to fix, but in the mean time other models have > turned up which need a similar workaround to avoid spurious wakeups from > suspend, but only for one of the pins on which the ACPI tables request > ACPI GPIO events. > > Since the honor_wakeup option was added to be able to ignore wake events, > the name was perhaps not the best, this commit renames it to ignore_wake > and changes it to a string with the following format: > gpiolib_acpi.ignore_wake=controller@pin[,controller@pin[,...]] > > This allows working around spurious wakeup issues on a per pin basis. > > This commit also reworks the existing quirk for the HP x2 10 so that > it functions as before. > > Note: > -This removes the honor_wakeup parameter. This has only been upstream for > a short time and to the best of my knowledge there are no users using > this module parameter. > > -The controller@pin[,controller@pin[,...]] syntax is based on an existing > kernel module parameter using the same controller@pin format. That version > uses ';' as separator, but in practice that is problematic because grub2 > cannot handle this without taking special care to escape the ';', so here > we are using a ',' as separator instead which does not have this issue. > > Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism") > Signed-off-by: Hans de Goede Acked-by: Mika Westerberg