From: Alex Riesen <alexander.riesen@cetitec.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, driverdevel <devel@driverdev.osuosl.org>, Linux Media Mailing List <linux-media@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org> Subject: Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Date: Mon, 2 Mar 2020 17:09:06 +0100 [thread overview] Message-ID: <20200302160906.GC3717@pflmari> (raw) In-Reply-To: <CAMuHMdW21rYXoOSE8azHNqYjng_j41rsL=Fo2bZc=1ULi9+pLw@mail.gmail.com> Hi Geert, Geert Uytterhoeven, Mon, Mar 02, 2020 16:32:32 +0100: > > And this absence of documentation also means that whatever clocks (both input > > in "clocks=" and output in "#clock-cells") listed in a specific .dts are just > > an integration detail? > > No, the absence probably means that any clock-related properties in a .dts > file will just be ignored. > > Looking at the driver source, it indeed has no support related to clocks at all. ... > > Does this below makes more sense, than? > > > > video-receiver@70 { > > compatible = "adi,adv7482"; > > clocks = <&rcar_sound 3>; > > clock-names = "clk-hdmi-video"; > > adv748x_mclk: mclk { > > compatible = "fixed-clock"; > > #clock-cells = <0>; > > /* frequency hard-coded for illustration */ > > clock-frequency = <12288000>; > > clock-output-names = "clk-hdmi-i2s-mclk"; > > }; > > }; > > The #clock-cells should be in the main video-receiver node. > Probably there is more than one clock output, so #clock-cells may be 1? AFAICS, the device can provide only this one clock line (audio master clock for I2S output)... I shall re-check, just in case. > There is no need for a fixed-clock compatible, nor for clock-frequency > and clock-output-names. > > But most important: this should be documented in the adv748x DT bindings, > and implemented in the adv748x driver. So if the driver is to export that clock for the kernel (like in this case), it must implement its support? > > > > Does a "clocks = ..." statement always mean input clocks? > > > > > > Yes it does. > > > If a device has clock outputs and is thus a clock provider, it should > > > have a #clock-cells property, and this should be documented in the bindings. > > > > > > A clock consumer will refer to clocks of a provider using the "clocks" > > > property, specifying a clock specifier (phandle and zero or more indices) > > > for each clock referenced. > > > > Something like this? > > > > &rcar_sound { > > clocks = ..., > > <&adv748x_mclk>, > > <&cpg CPG_CORE CPG_AUDIO_CLK_I>; > > clock-names = ..., > > "clk_c", > > "clk_i"; > > }; > > More or less. > > Might become > > find_a_better_label_choice: video-receiver@70 { > ... > }; > > &rcar_sound { > clock = ..., > <&find_a_better_label_choice 0>, > ... > }; > > as there may be multiple clock outputs on the ADV7482. I see. Working on it. Thanks a lot! Regards, Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Riesen <alexander.riesen@cetitec.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Mark Rutland <mark.rutland@arm.com>, driverdevel <devel@driverdev.osuosl.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Kieran Bingham <kieran.bingham@ideasonboard.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Mauro Carvalho Chehab <mchehab@kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org> Subject: Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Date: Mon, 2 Mar 2020 17:09:06 +0100 [thread overview] Message-ID: <20200302160906.GC3717@pflmari> (raw) In-Reply-To: <CAMuHMdW21rYXoOSE8azHNqYjng_j41rsL=Fo2bZc=1ULi9+pLw@mail.gmail.com> Hi Geert, Geert Uytterhoeven, Mon, Mar 02, 2020 16:32:32 +0100: > > And this absence of documentation also means that whatever clocks (both input > > in "clocks=" and output in "#clock-cells") listed in a specific .dts are just > > an integration detail? > > No, the absence probably means that any clock-related properties in a .dts > file will just be ignored. > > Looking at the driver source, it indeed has no support related to clocks at all. ... > > Does this below makes more sense, than? > > > > video-receiver@70 { > > compatible = "adi,adv7482"; > > clocks = <&rcar_sound 3>; > > clock-names = "clk-hdmi-video"; > > adv748x_mclk: mclk { > > compatible = "fixed-clock"; > > #clock-cells = <0>; > > /* frequency hard-coded for illustration */ > > clock-frequency = <12288000>; > > clock-output-names = "clk-hdmi-i2s-mclk"; > > }; > > }; > > The #clock-cells should be in the main video-receiver node. > Probably there is more than one clock output, so #clock-cells may be 1? AFAICS, the device can provide only this one clock line (audio master clock for I2S output)... I shall re-check, just in case. > There is no need for a fixed-clock compatible, nor for clock-frequency > and clock-output-names. > > But most important: this should be documented in the adv748x DT bindings, > and implemented in the adv748x driver. So if the driver is to export that clock for the kernel (like in this case), it must implement its support? > > > > Does a "clocks = ..." statement always mean input clocks? > > > > > > Yes it does. > > > If a device has clock outputs and is thus a clock provider, it should > > > have a #clock-cells property, and this should be documented in the bindings. > > > > > > A clock consumer will refer to clocks of a provider using the "clocks" > > > property, specifying a clock specifier (phandle and zero or more indices) > > > for each clock referenced. > > > > Something like this? > > > > &rcar_sound { > > clocks = ..., > > <&adv748x_mclk>, > > <&cpg CPG_CORE CPG_AUDIO_CLK_I>; > > clock-names = ..., > > "clk_c", > > "clk_i"; > > }; > > More or less. > > Might become > > find_a_better_label_choice: video-receiver@70 { > ... > }; > > &rcar_sound { > clock = ..., > <&find_a_better_label_choice 0>, > ... > }; > > as there may be multiple clock outputs on the ADV7482. I see. Working on it. Thanks a lot! Regards, Alex _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-02 16:09 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-13 14:19 [PATCH 0/8] media: i2c: adv748x: add support for HDMI audio Alex Riesen 2020-01-13 14:19 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 1/8] media: adv748x: add a device-specific wrapper for register block read Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 2/8] media: adv748x: add audio mute control and output selection ioctls Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-03-13 8:16 ` Hans Verkuil 2020-03-13 8:16 ` Hans Verkuil 2020-03-13 10:26 ` Alex Riesen 2020-03-13 10:26 ` Alex Riesen 2020-03-13 10:52 ` Hans Verkuil 2020-03-13 10:52 ` Hans Verkuil 2020-03-13 11:00 ` Alex Riesen 2020-03-13 11:00 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 3/8] media: adv748x: add log_status ioctl Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 4/8] media: adv748x: reserve space for the audio (I2S) port in the driver structures Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 5/8] media: adv748x: add an ASoC DAI definition to the driver Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 6/8] media: adv748x: reduce amount of code for bitwise modification of device registers Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 7/8] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 22:32 ` Rob Herring 2020-01-13 22:32 ` Rob Herring 2020-01-13 14:15 ` [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-03-02 12:28 ` Geert Uytterhoeven 2020-03-02 12:28 ` Geert Uytterhoeven 2020-03-02 13:40 ` Alex Riesen 2020-03-02 13:40 ` Alex Riesen 2020-03-02 13:47 ` Geert Uytterhoeven 2020-03-02 13:47 ` Geert Uytterhoeven 2020-03-02 15:07 ` Alex Riesen 2020-03-02 15:07 ` Alex Riesen 2020-03-02 15:32 ` Geert Uytterhoeven 2020-03-02 15:32 ` Geert Uytterhoeven 2020-03-02 16:09 ` Alex Riesen [this message] 2020-03-02 16:09 ` Alex Riesen 2020-03-02 16:13 ` Geert Uytterhoeven 2020-03-02 16:13 ` Geert Uytterhoeven 2020-03-05 14:36 ` Alex Riesen 2020-03-05 14:36 ` Alex Riesen 2020-03-06 12:21 ` Geert Uytterhoeven 2020-03-06 12:21 ` Geert Uytterhoeven 2020-03-06 13:16 ` Laurent Pinchart 2020-03-06 13:16 ` Laurent Pinchart 2020-03-06 13:41 ` Alex Riesen 2020-03-06 13:41 ` Alex Riesen 2020-03-06 13:45 ` Laurent Pinchart 2020-03-06 13:45 ` Laurent Pinchart 2020-03-09 1:31 ` Kuninori Morimoto 2020-03-09 1:31 ` Kuninori Morimoto 2020-03-09 11:09 ` Alex Riesen 2020-03-09 11:09 ` Alex Riesen 2020-03-10 1:07 ` Kuninori Morimoto 2020-03-10 1:07 ` Kuninori Morimoto 2020-03-10 8:17 ` Alex Riesen 2020-03-10 8:17 ` Alex Riesen 2020-03-10 10:39 ` Laurent Pinchart 2020-03-10 10:39 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200302160906.GC3717@pflmari \ --to=alexander.riesen@cetitec.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kieran.bingham@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.