From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22315C3F2D1 for ; Mon, 2 Mar 2020 21:47:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDAB821739 for ; Mon, 2 Mar 2020 21:47:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDAB821739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 72FED6E84C; Mon, 2 Mar 2020 21:47:18 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id DFDD06E84C for ; Mon, 2 Mar 2020 21:47:16 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 2BB0580520; Mon, 2 Mar 2020 22:47:14 +0100 (CET) Date: Mon, 2 Mar 2020 22:47:13 +0100 From: Sam Ravnborg To: Ville Syrjala Subject: Re: [PATCH 00/33] drm/panel: Fix dotclocks Message-ID: <20200302214713.GA948@ravnborg.org> References: <20200302203452.17977-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200302203452.17977-1-ville.syrjala@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=8nJEP1OIZ-IA:10 a=QyXUC8HyAAAA:8 a=5xu41AGPb3uHMspi1YcA:9 a=wPNLvfGTeEIA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Ville. On Mon, Mar 02, 2020 at 10:34:19PM +0200, Ville Syrjala wrote: > From: Ville Syrj=E4l=E4 > = > A lot of the panel drivers put bogus looking values into > mode.clock. This series replaces the bogus values with > mode.vrefresh*mode.htotal*mode.vtotal. I think you got it wrong.... The few I sampled I would rather say that the clock specified was the one that was possible with the present HW and the refresh rate was then set to what was attempted. Example: chunghwa_claa101wb01_mode clock is 69300 - which looks like a value you could configure in HW. It not not a nive round value. refresh is 60, which looks like the refresh value that was attempted. So unless there is a big difference between the calcualted refresh (based on the specifed clock), and the specified clock it should be assumed that clock is OK. And it is OK to drop refresh. This is my take on it - but you based your patches on refresh. So maybe you have a better rationale to do so? Also, let's await feedback from the people cc'ed on the pathces. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel