From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4AB9C3F2CD for ; Tue, 3 Mar 2020 08:25:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8472E208C3 for ; Tue, 3 Mar 2020 08:25:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="GwhJyRKT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8472E208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=onstation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 277766E9FC; Tue, 3 Mar 2020 08:24:13 +0000 (UTC) X-Greylist: delayed 516 seconds by postgrey-1.36 at gabe; Tue, 03 Mar 2020 03:22:12 UTC Received: from onstation.org (onstation.org [52.200.56.107]) by gabe.freedesktop.org (Postfix) with ESMTPS id ACCD36E968 for ; Tue, 3 Mar 2020 03:22:12 +0000 (UTC) Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id 04F1D3E914; Tue, 3 Mar 2020 03:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1583205216; bh=YxLgEG32SvLZ5FOCk+grOGoV34kSmiprPCXtmlthnxg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GwhJyRKTA49Ep7t2HcTqflU95CsOWVRBYbSuMt8Lew62xWIBynG7XO7AOu9doOru6 uSNTZiO+ArsIg4tCYO8T9EphvzRZk0cfQtByUKjWGeOsJhcPC9OaSWVTh+QnmsicTX TXTMJsDnXwve8lhS+XoYKcRxUkBfuNJ8GRIdmQ28= Date: Mon, 2 Mar 2020 22:13:35 -0500 From: Brian Masney To: Jonathan Marek Subject: Re: [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7 Message-ID: <20200303031335.GA7208@onstation.org> References: <20200302203452.17977-1-ville.syrjala@linux.intel.com> <20200302203452.17977-34-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Tue, 03 Mar 2020 08:24:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 02, 2020 at 03:48:22PM -0500, Jonathan Marek wrote: > Hi, > = > This is a command mode panel and the the msm/mdp5 driver uses the vrefresh > field for the actual refresh rate, while the dotclock field is used for t= he > DSI clocks. The dotclock needed to be a bit higher than necessary otherwi= se > the panel would not work. > = > If you want to get rid of the separate clock/vrefresh fields there would > need to be some changes to msm driver. > = > (note I hadn't made the patch with upstreaming in mind, the 150000 value = is > likely not optimal, just something that worked, this is something that > should have been checked with the downstream driver) Is this the right clock frequency in the downstream MSM 3.4 kernel that you're talking about? https://github.com/AICP/kernel_lge_hammerhead/blob/n7.1/arch/arm/mach-msm/c= lock-8974.c#L3326 I don't see any obvious clock values in the downstream command mode panel configuration: = https://github.com/AICP/kernel_lge_hammerhead/blob/n7.1/arch/arm/boot/dts/m= sm8974-hammerhead/msm8974-hammerhead-panel.dtsi#L591 Anyways, I tried Ville's patch with the framebuffer, kmscube, and X11 and everything appears to be working fine. You can add my Tested-by if you end up applying this. Tested-by: Brian Masney Brian > On 3/2/20 3:34 PM, Ville Syrjala wrote: > > From: Ville Syrj=E4l=E4 > > = > > The currently listed dotclock disagrees with the currently > > listed vrefresh rate. Change the dotclock to match the vrefresh. > > = > > Someone tell me which (if either) of the dotclock or vreresh is > > correct? > > = > > Cc: Jonathan Marek > > Cc: Brian Masney > > Cc: Linus Walleij > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/panel/panel-simple.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > = > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/pan= el/panel-simple.c > > index b24fdf239440..f958d8dfd760 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -3996,7 +3996,7 @@ static const struct panel_desc_dsi panasonic_vvx1= 0f004b00 =3D { > > }; > > static const struct drm_display_mode lg_acx467akm_7_mode =3D { > > - .clock =3D 150000, > > + .clock =3D 125498, > > .hdisplay =3D 1080, > > .hsync_start =3D 1080 + 2, > > .hsync_end =3D 1080 + 2 + 2, > > = _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel