On Tue, Mar 03, 2020 at 01:55:35PM +0100, Philippe Mathieu-Daudé wrote: > Hi Cleber, > Hi Phil! > On Tue, Mar 3, 2020 at 12:40 AM Philippe Mathieu-Daudé > wrote: > > On 3/2/20 9:58 PM, Aleksandar Markovic wrote: > > >> From: Peter Maydell > > >> Sent: Monday, March 2, 2020 9:26 PM > > >> To: Aleksandar Markovic > > >> Cc: QEMU Developers; Aleksandar Markovic; Philippe Mathieu-Daudé > > >> Subject: [EXTERNAL]Re: [PULL 5/5] tests/acceptance: Count multiple Tux logos displayed on framebuffer > > >> > > >> On Thu, 27 Feb 2020 at 13:28, Aleksandar Markovic > > >> wrote: > > >>> > > >>> From: Philippe Mathieu-Daudé > > >>> > > >>> Add a test that verifies that each core properly displays the Tux > > >>> logo on the framebuffer device. > > >>> > > >>> We simply follow the OpenCV "Template Matching with Multiple Objects" > > >>> tutorial, replacing Lionel Messi by Tux: > > >>> https://docs.opencv.org/4.2.0/d4/dc6/tutorial_py_template_matching.html > > >> > > >> Hi -- this doesn't seem to work on my system: > > >> > > > > > > Thank you for bringing this to our attention. > > > > > > It looks like an honest mistake to me. Too bad > > > none of us tested the case of environment like > > > yours, even though it looked reasonable to test it. > > > > I'm sorry I missed that, I'm pretty sure I tested it as we noticed this > > "bug" in Avocado more than 1 year ago already (bug = class decorator not > > working). > > I see in commit 2fe6f4d9ba you moved the @skip decorators to the setUp() method. > Is this a kind of kludge to not use it on all the test_*() methods? > (since we can not use it on an AvocadoTest class) > Yes, that was a workaround for a previous Avocado limitation. As I said on another thread, on Avocado >= 76.0 it's possible to just decorate the entire class. - Cleber.