All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Ulrich Hecht <uli+renesas@fpond.eu>
Cc: linux-renesas-soc@vger.kernel.org, geert@linux-m68k.org,
	fabrizio.castro@bp.renesas.com,
	ramesh.shanmugasundaram@bp.renesas.com, magnus.damm@gmail.com
Subject: Re: [PATCH 01/11] clk: renesas: cpg-mssr: add support for ignore-unused clocks
Date: Tue, 3 Mar 2020 17:13:54 +0100	[thread overview]
Message-ID: <20200303161354.GB3683@ninjato> (raw)
In-Reply-To: <1582748897-17374-2-git-send-email-uli+renesas@fpond.eu>

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]


> +	for (i = 0; i < info->num_used_mod_clks; i++)

I think the naming of 'used' is a bit unfortunate because the flag is
'unused'. The most readable would be 'ignore_unused_mod_clks' probably?
But this is kinda long. 'kept_mod_clks'? I really don't want to
bikeshed over this, but maybe we can lower the potential confusion here?

> +		if (id == info->used_mod_clks[i]) {
> +			dev_dbg(dev, "MSTP %s setting CLK_IGNORE_UNUSED\n",
> +				mod->name);

Can we remove this? We can check this easily in debugfs/clk. Yes, I know
CLK_CRITICAL has it, too. Maybe we can remove it there, too. Or just
move it to the final dev_dbg before the function leaves?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-03-03 16:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 20:28 [PATCH 00/11] clk: renesas: cpg-mssr: add ignore-unused option Ulrich Hecht
2020-02-26 20:28 ` [PATCH 01/11] clk: renesas: cpg-mssr: add support for ignore-unused clocks Ulrich Hecht
2020-03-03 16:13   ` Wolfram Sang [this message]
2020-02-26 20:28 ` [PATCH 02/11] clk: renesas: r8a7796: mark RWDT clock as ignore-unused Ulrich Hecht
2020-02-26 20:28 ` [PATCH 03/11] clk: renesas: r8a7795: " Ulrich Hecht
2020-02-26 20:28 ` [PATCH 04/11] clk: renesas: r8a77970: " Ulrich Hecht
2020-02-26 20:28 ` [PATCH 05/11] clk: renesas: r8a77980: " Ulrich Hecht
2020-02-26 20:28 ` [PATCH 06/11] clk: renesas: r8a77995: " Ulrich Hecht
2020-02-26 20:28 ` [PATCH 07/11] clk: renesas: r8a774a1: " Ulrich Hecht
2020-02-26 20:28 ` [PATCH 08/11] clk: renesas: r8a774b1: " Ulrich Hecht
2020-02-26 20:28 ` [PATCH 09/11] clk: renesas: r8a774c0: " Ulrich Hecht
2020-02-26 20:28 ` [PATCH 10/11] clk: renesas: r8a77965: " Ulrich Hecht
2020-02-26 20:28 ` [PATCH 11/11] clk: renesas: r8a77990: " Ulrich Hecht
2020-02-27 14:29 ` [PATCH 00/11] clk: renesas: cpg-mssr: add ignore-unused option Geert Uytterhoeven
2020-03-03 16:05 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303161354.GB3683@ninjato \
    --to=wsa@the-dreams.de \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=ramesh.shanmugasundaram@bp.renesas.com \
    --cc=uli+renesas@fpond.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.