From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 154C5C3F2C6 for ; Tue, 3 Mar 2020 17:16:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E003520848 for ; Tue, 3 Mar 2020 17:16:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="eTrzME+b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729198AbgCCRQV (ORCPT ); Tue, 3 Mar 2020 12:16:21 -0500 Received: from onstation.org ([52.200.56.107]:54054 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728783AbgCCRQV (ORCPT ); Tue, 3 Mar 2020 12:16:21 -0500 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id DA9123E8F4; Tue, 3 Mar 2020 17:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1583255780; bh=29MHpfV8HM+m/8mEKfdKSt2XIMIPWgMiQS70SJOaT7c=; h=Date:From:To:Subject:References:In-Reply-To:From; b=eTrzME+buJDC+JQ2iOWHK8a21j41LZUAzuAoD6PU+ExzLiLW0D02gLFI+rEugFT5d qLtSTAP3J8bZ05tZbtTjIix7XtqpPn8DcnG7WEpi9HA0bgAIilMhxpW/g18txdK9Pg oSk6hHunH/xQXWS3OpHcF+4kXqceEaQ3dhsS2yPo= Date: Tue, 3 Mar 2020 12:16:19 -0500 From: Brian Masney To: Jeffrey Hugo , Sam Ravnborg , Sean Paul , DTML , David Airlie , MSM , Sharat Masetty , lkml , "open list:DRM PANEL DRIVERS" , Rob Herring , freedreno Subject: Re: [Freedreno] [PATCH v3 1/2] dt-bindings: display: msm: Convert GMU bindings to YAML Message-ID: <20200303171619.GB11841@onstation.org> References: <1583173424-21832-1-git-send-email-jcrouse@codeaurora.org> <1583173424-21832-2-git-send-email-jcrouse@codeaurora.org> <20200302204906.GA32123@ravnborg.org> <20200303154321.GA24212@jcrouse1-lnx.qualcomm.com> <20200303155405.GA11841@onstation.org> <20200303170159.GA13109@jcrouse1-lnx.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200303170159.GA13109@jcrouse1-lnx.qualcomm.com> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Mar 03, 2020 at 10:01:59AM -0700, Jordan Crouse wrote: > On Tue, Mar 03, 2020 at 10:54:05AM -0500, Brian Masney wrote: > > On Tue, Mar 03, 2020 at 08:50:28AM -0700, Jeffrey Hugo wrote: > > > On Tue, Mar 3, 2020 at 8:43 AM Jordan Crouse wrote: > > > > > > > > On Mon, Mar 02, 2020 at 09:49:06PM +0100, Sam Ravnborg wrote: > > > > > Hi Jordan. > > > > > > > > > > On Mon, Mar 02, 2020 at 11:23:43AM -0700, Jordan Crouse wrote: > > > > > > Convert display/msm/gmu.txt to display/msm/gmu.yaml and remove the old > > > > > > text bindings. > > > > > > > > > > > > Signed-off-by: Jordan Crouse > > > > > > --- > > > > > > > > > > > > .../devicetree/bindings/display/msm/gmu.txt | 116 ------------------- > > > > > > - > > > > > > -Required properties: > > > > > > -- compatible: "qcom,adreno-gmu-XYZ.W", "qcom,adreno-gmu" > > > > > > - for example: "qcom,adreno-gmu-630.2", "qcom,adreno-gmu" > > > > > > - Note that you need to list the less specific "qcom,adreno-gmu" > > > > > > - for generic matches and the more specific identifier to identify > > > > > > - the specific device. > > > > > > -- reg: Physical base address and length of the GMU registers. > > > > > > -- reg-names: Matching names for the register regions > > > > > > - * "gmu" > > > > > > - * "gmu_pdc" > > > > > > - * "gmu_pdc_seg" > > > > > > -- interrupts: The interrupt signals from the GMU. > > > > > > -- interrupt-names: Matching names for the interrupts > > > > > > - * "hfi" > > > > > > - * "gmu" > > > > > > -- clocks: phandles to the device clocks > > > > > > -- clock-names: Matching names for the clocks > > > > > > - * "gmu" > > > > > > - * "cxo" > > > > > > - * "axi" > > > > > > - * "mnoc" > > > > > The new binding - and arch/arm64/boot/dts/qcom/sdm845.dtsi agrees that > > > > > "mnoc" is wrong. > > > > > > > > > > > -- power-domains: should be: > > > > > > - <&clock_gpucc GPU_CX_GDSC> > > > > > > - <&clock_gpucc GPU_GX_GDSC> > > > > > > -- power-domain-names: Matching names for the power domains > > > > > > -- iommus: phandle to the adreno iommu > > > > > > -- operating-points-v2: phandle to the OPP operating points > > > > > > - > > > > > > -Optional properties: > > > > > > -- sram: phandle to the On Chip Memory (OCMEM) that's present on some Snapdragon > > > > > > - SoCs. See Documentation/devicetree/bindings/sram/qcom,ocmem.yaml. > > > > > This property is not included in the new binding. > > > > > > > > Yeah, that guy shouldn't be here. I'm not sure how it got there in the first > > > > place but I'll update the commit log. Thanks for the poke. > > > > > > I thought this was something Brian M added for older targets (A4XX?). > > > Perhaps he should chime in? > > > > Yes, this is needed for older systems with a3xx and a4xx GPUs. > > Okay, this got added to the wrong place. The GMU is a specific entity only > valid for a6xx targets. From the looks of the example the sram should be in the > GPU definition. Do you want to submit a patch to move it or should I (and lets > hope Rob doesn't insist on converting GPU to YAML). I can take care of cleaning this up. I'll do that in a few days. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C844C3F2CD for ; Wed, 4 Mar 2020 07:48:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DC58207FD for ; Wed, 4 Mar 2020 07:48:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="eTrzME+b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DC58207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=onstation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D2B646EAD8; Wed, 4 Mar 2020 07:47:32 +0000 (UTC) Received: from onstation.org (onstation.org [52.200.56.107]) by gabe.freedesktop.org (Postfix) with ESMTPS id 025696EA89; Tue, 3 Mar 2020 17:16:20 +0000 (UTC) Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id DA9123E8F4; Tue, 3 Mar 2020 17:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1583255780; bh=29MHpfV8HM+m/8mEKfdKSt2XIMIPWgMiQS70SJOaT7c=; h=Date:From:To:Subject:References:In-Reply-To:From; b=eTrzME+buJDC+JQ2iOWHK8a21j41LZUAzuAoD6PU+ExzLiLW0D02gLFI+rEugFT5d qLtSTAP3J8bZ05tZbtTjIix7XtqpPn8DcnG7WEpi9HA0bgAIilMhxpW/g18txdK9Pg oSk6hHunH/xQXWS3OpHcF+4kXqceEaQ3dhsS2yPo= Date: Tue, 3 Mar 2020 12:16:19 -0500 From: Brian Masney To: Jeffrey Hugo , Sam Ravnborg , Sean Paul , DTML , David Airlie , MSM , Sharat Masetty , lkml , "open list:DRM PANEL DRIVERS" , Rob Herring , freedreno Subject: Re: [Freedreno] [PATCH v3 1/2] dt-bindings: display: msm: Convert GMU bindings to YAML Message-ID: <20200303171619.GB11841@onstation.org> References: <1583173424-21832-1-git-send-email-jcrouse@codeaurora.org> <1583173424-21832-2-git-send-email-jcrouse@codeaurora.org> <20200302204906.GA32123@ravnborg.org> <20200303154321.GA24212@jcrouse1-lnx.qualcomm.com> <20200303155405.GA11841@onstation.org> <20200303170159.GA13109@jcrouse1-lnx.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200303170159.GA13109@jcrouse1-lnx.qualcomm.com> X-Mailman-Approved-At: Wed, 04 Mar 2020 07:47:28 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 03, 2020 at 10:01:59AM -0700, Jordan Crouse wrote: > On Tue, Mar 03, 2020 at 10:54:05AM -0500, Brian Masney wrote: > > On Tue, Mar 03, 2020 at 08:50:28AM -0700, Jeffrey Hugo wrote: > > > On Tue, Mar 3, 2020 at 8:43 AM Jordan Crouse wrote: > > > > > > > > On Mon, Mar 02, 2020 at 09:49:06PM +0100, Sam Ravnborg wrote: > > > > > Hi Jordan. > > > > > > > > > > On Mon, Mar 02, 2020 at 11:23:43AM -0700, Jordan Crouse wrote: > > > > > > Convert display/msm/gmu.txt to display/msm/gmu.yaml and remove the old > > > > > > text bindings. > > > > > > > > > > > > Signed-off-by: Jordan Crouse > > > > > > --- > > > > > > > > > > > > .../devicetree/bindings/display/msm/gmu.txt | 116 ------------------- > > > > > > - > > > > > > -Required properties: > > > > > > -- compatible: "qcom,adreno-gmu-XYZ.W", "qcom,adreno-gmu" > > > > > > - for example: "qcom,adreno-gmu-630.2", "qcom,adreno-gmu" > > > > > > - Note that you need to list the less specific "qcom,adreno-gmu" > > > > > > - for generic matches and the more specific identifier to identify > > > > > > - the specific device. > > > > > > -- reg: Physical base address and length of the GMU registers. > > > > > > -- reg-names: Matching names for the register regions > > > > > > - * "gmu" > > > > > > - * "gmu_pdc" > > > > > > - * "gmu_pdc_seg" > > > > > > -- interrupts: The interrupt signals from the GMU. > > > > > > -- interrupt-names: Matching names for the interrupts > > > > > > - * "hfi" > > > > > > - * "gmu" > > > > > > -- clocks: phandles to the device clocks > > > > > > -- clock-names: Matching names for the clocks > > > > > > - * "gmu" > > > > > > - * "cxo" > > > > > > - * "axi" > > > > > > - * "mnoc" > > > > > The new binding - and arch/arm64/boot/dts/qcom/sdm845.dtsi agrees that > > > > > "mnoc" is wrong. > > > > > > > > > > > -- power-domains: should be: > > > > > > - <&clock_gpucc GPU_CX_GDSC> > > > > > > - <&clock_gpucc GPU_GX_GDSC> > > > > > > -- power-domain-names: Matching names for the power domains > > > > > > -- iommus: phandle to the adreno iommu > > > > > > -- operating-points-v2: phandle to the OPP operating points > > > > > > - > > > > > > -Optional properties: > > > > > > -- sram: phandle to the On Chip Memory (OCMEM) that's present on some Snapdragon > > > > > > - SoCs. See Documentation/devicetree/bindings/sram/qcom,ocmem.yaml. > > > > > This property is not included in the new binding. > > > > > > > > Yeah, that guy shouldn't be here. I'm not sure how it got there in the first > > > > place but I'll update the commit log. Thanks for the poke. > > > > > > I thought this was something Brian M added for older targets (A4XX?). > > > Perhaps he should chime in? > > > > Yes, this is needed for older systems with a3xx and a4xx GPUs. > > Okay, this got added to the wrong place. The GMU is a specific entity only > valid for a6xx targets. From the looks of the example the sram should be in the > GPU definition. Do you want to submit a patch to move it or should I (and lets > hope Rob doesn't insist on converting GPU to YAML). I can take care of cleaning this up. I'll do that in a few days. Brian _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel