All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: mkubecek@suse.cz, thomas.lendacky@amd.com, benve@cisco.com,
	_govind@gmx.com, pkaustub@cisco.com, peppe.cavallaro@st.com,
	alexandre.torgue@st.com, joabreu@synopsys.com,
	snelson@pensando.io, yisen.zhuang@huawei.com,
	salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com,
	jacob.e.keller@intel.com, alexander.h.duyck@linux.intel.com,
	michael.chan@broadcom.com, saeedm@mellanox.com, leon@kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next 12/12] virtio_net: reject unsupported coalescing params
Date: Tue, 3 Mar 2020 20:07:43 -0800	[thread overview]
Message-ID: <20200303200743.35e188c1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200304035501.628139-13-kuba@kernel.org>

On Tue,  3 Mar 2020 19:55:01 -0800 Jakub Kicinski wrote:
> Set ethtool_ops->coalesce_types to let the core reject
> unsupported coalescing parameters.
> 
> This driver did not previously reject unsupported parameters.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  drivers/net/virtio_net.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 84c0d9581f93..cfca3d134d4e 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2273,6 +2273,7 @@ static void virtnet_update_settings(struct virtnet_info *vi)
>  }
>  
>  static const struct ethtool_ops virtnet_ethtool_ops = {
> +	.coalesce_types = ETHTOOL_COALESCE_TX_MAX_FRAMES,

Ugh, the last minute addition backfired, virtio_net does not support
changing RX settings, but they must be always configured to 1. This
should have been:

	.coalesce_types = ETHTOOL_COALESCE_MAX_FRAMES,

And the driver does in fact check for unsupported parameters.

>  	.get_drvinfo = virtnet_get_drvinfo,
>  	.get_link = ethtool_op_get_link,
>  	.get_ringparam = virtnet_get_ringparam,


      reply	other threads:[~2020-03-04  4:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  3:54 [PATCH net-next 00/12] ethtool: consolidate parameter checking for irq coalescing Jakub Kicinski
2020-03-04  3:54 ` [PATCH net-next 01/12] ethtool: add infrastructure for centralized checking of coalescing parameters Jakub Kicinski
2020-03-04 14:54   ` Andrew Lunn
2020-03-04 15:19     ` Michal Kubecek
2020-03-04 15:22       ` Andrew Lunn
2020-03-04 18:11         ` Jakub Kicinski
2020-03-04  3:54 ` [PATCH net-next 02/12] xgbe: let core reject the unsupported " Jakub Kicinski
2020-03-04  3:54 ` [PATCH net-next 03/12] enic: " Jakub Kicinski
2020-03-04  3:54 ` [PATCH net-next 04/12] stmmac: " Jakub Kicinski
2020-03-04  3:54 ` [PATCH net-next 05/12] nfp: " Jakub Kicinski
2020-03-04  3:54 ` [PATCH net-next 06/12] ionic: " Jakub Kicinski
2020-03-04  4:22   ` Shannon Nelson
2020-03-04  3:54 ` [PATCH net-next 07/12] hisilicon: " Jakub Kicinski
2020-03-04  3:54 ` [PATCH net-next 08/12] ice: " Jakub Kicinski
2020-03-04  4:24   ` Jakub Kicinski
2020-03-04  3:54 ` [PATCH net-next 09/12] bnxt: reject unsupported coalescing params Jakub Kicinski
2020-03-04  3:54 ` [PATCH net-next 10/12] mlx5: " Jakub Kicinski
2020-03-04  3:55 ` [PATCH net-next 11/12] e1000e: " Jakub Kicinski
2020-03-04  3:55 ` [PATCH net-next 12/12] virtio_net: " Jakub Kicinski
2020-03-04  4:07   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303200743.35e188c1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=_govind@gmx.com \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=alexandre.torgue@st.com \
    --cc=benve@cisco.com \
    --cc=davem@davemloft.net \
    --cc=jacob.e.keller@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=joabreu@synopsys.com \
    --cc=leon@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=pkaustub@cisco.com \
    --cc=saeedm@mellanox.com \
    --cc=salil.mehta@huawei.com \
    --cc=snelson@pensando.io \
    --cc=thomas.lendacky@amd.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.