From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E52BC3F2D1 for ; Tue, 3 Mar 2020 20:38:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37D1B20848 for ; Tue, 3 Mar 2020 20:38:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37D1B20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 914256E94D; Tue, 3 Mar 2020 20:38:48 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 997C76E054 for ; Tue, 3 Mar 2020 20:38:46 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 12:38:46 -0800 X-IronPort-AV: E=Sophos;i="5.70,511,1574150400"; d="scan'208";a="386914677" Received: from rdvivi-losangeles.jf.intel.com (HELO intel.com) ([10.165.21.202]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 12:38:45 -0800 Date: Tue, 3 Mar 2020 12:39:35 -0800 From: Rodrigo Vivi To: Lucas De Marchi , Jani Nikula Message-ID: <20200303203935.GF645250@intel.com> References: <20200218230822.66801-1-jose.souza@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl: Remove require_force_probe protection X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 03, 2020 at 12:26:34PM -0800, Lucas De Marchi wrote: > On Tue, Feb 18, 2020 at 3:07 PM Jos=E9 Roberto de Souza > wrote: > > > > We have a few TGL machines in our CI and it is mostly green with > > failures in tests that will not impact future Linux installations. > > Also there is no warnings, errors, flickering or any visual defects > > while doing ordinary tasks like browsing and editing documents in a > > dual monitor setup. > > > > As a reminder i915.require_force_probe was created to protect > > future Linux installation's iso images that might contain a > > kernel from the enabling time of the new platform. Without this > > protection most of linux installation was recommending > > nomodeset option during installation that was getting stick > > there after installation. > > > > Reference: https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-u.html > > Reference: https://intel-gfx-ci.01.org/tree/drm-tip/shard-tglb.html > > Cc: James Ausmus > > Cc: Jani Saarinen > > Cc: Rodrigo Vivi > > Cc: Jani Nikula > > Cc: Joonas Lahtinen > > Signed-off-by: Jos=E9 Roberto de Souza > = > Reviewed-by: Lucas De Marchi > = > Also, I think it would be good to have this in 5.6 rather than 5.7. > Yes, it's late in the merge window, but it falls in the case of "New > device IDs and quirks are also accepted." of the stable kernel rules, > so could as well just go directly to this kernel. Rodrigo, is it > possible? Jani is on charge of the 5.6 so I will defer this decision to him. But in general we always refused to do this because this is a enabling kind of thing and not a fix per say. Okay, you might argue that it is a device ID and that would be accepted on stable so why not also on fixes cycle, but my fear is that we haven't properly validated that on 5.6 without the many changes, fixes and workarounds that are only going towards 5.7 and not 5.6. > = > thanks > Lucas De Marchi > = > > --- > > drivers/gpu/drm/i915/i915_pci.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i91= 5_pci.c > > index 24b1f0ce8743..2146b9a865ba 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -822,7 +822,6 @@ static const struct intel_device_info tgl_info =3D { > > GEN12_FEATURES, > > PLATFORM(INTEL_TIGERLAKE), > > .pipe_mask =3D BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PI= PE_D), > > - .require_force_probe =3D 1, > > .display.has_modular_fia =3D 1, > > .engine_mask =3D > > BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VC= S2), > > -- > > 2.25.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > = > = > -- = > Lucas De Marchi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx