All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>,
	Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: commit 01e99aeca397 causes longer runtime of block/004
Date: Wed, 4 Mar 2020 11:46:44 +0800	[thread overview]
Message-ID: <20200304034644.GA23012@ming.t460p> (raw)
In-Reply-To: <20200304023842.gu37d4mzfbseiscw@shindev.dhcp.fujisawa.hgst.com>

On Wed, Mar 04, 2020 at 02:38:43AM +0000, Shinichiro Kawasaki wrote:
> I noticed that blktests block/004 takes longer runtime with 5.6-rc4 than
> 5.6-rc3, and found that the commit 01e99aeca397 ("blk-mq: insert passthrough
> request into hctx->dispatch directly") triggers it.
> 
> The longer runtime was observed with dm-linear device which maps SATA SMR HDD
> connected via AHCI. It was not observed with dm-linear on SAS/SATA SMR HDDs
> connected via SAS-HBA. Not observed with dm-linear on non-SMR HDDs either.
> 
> Before the commit, block/004 took around 130 seconds. After the commit, it takes
> around 300 seconds. I need to dig in further details to understand why the
> commit makes the test case longer.
> 
> The test case block/004 does "flush intensive workload". Is this longer runtime
> expected?

The following patch might address this issue:

https://lore.kernel.org/linux-block/20200207190416.99928-1-sqazi@google.com/#t

Please test and provide us the result.

thanks,
Ming


  reply	other threads:[~2020-03-04  3:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  2:38 commit 01e99aeca397 causes longer runtime of block/004 Shinichiro Kawasaki
2020-03-04  3:46 ` Ming Lei [this message]
2020-03-04  6:11   ` Shinichiro Kawasaki
2020-03-04  9:53     ` Ming Lei
2020-03-05  1:19       ` Shinichiro Kawasaki
2020-03-05  2:48         ` Ming Lei
2020-03-06  6:06           ` Shinichiro Kawasaki
2020-03-06  8:13             ` Ming Lei
2020-03-07  1:02               ` Shinichiro Kawasaki
2020-03-07  4:13                 ` Ming Lei
2020-03-09  0:07                   ` Shinichiro Kawasaki
2020-03-09 16:14                     ` Ming Lei
2020-03-10  3:07                       ` Damien Le Moal
2020-03-10  5:54                         ` Shinichiro Kawasaki
2020-03-10  6:00                           ` Damien Le Moal
2020-03-10  8:07                           ` Ming Lei
2020-03-10 11:07                             ` Shinichiro Kawasaki
2020-03-10 13:37                               ` Ming Lei
2020-03-10 14:37                                 ` Ming Lei
2020-03-11  4:59                                   ` Shinichiro Kawasaki
2020-03-11  7:54                                     ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200304034644.GA23012@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.