From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD08C3F2D1 for ; Wed, 4 Mar 2020 09:51:28 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C511C20848 for ; Wed, 4 Mar 2020 09:51:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="UmxOkNqV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C511C20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5263486373; Wed, 4 Mar 2020 09:51:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9DaSnIjsEk2q; Wed, 4 Mar 2020 09:51:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 449EF86399; Wed, 4 Mar 2020 09:51:26 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3BC0DC1AE2; Wed, 4 Mar 2020 09:51:26 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 91622C013E for ; Wed, 4 Mar 2020 09:51:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7800384C2C for ; Wed, 4 Mar 2020 09:51:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H6x1r5nOhxGg for ; Wed, 4 Mar 2020 09:51:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 944F284B1C for ; Wed, 4 Mar 2020 09:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=12AiVInoHM1BfAgjjizVtBV97APOB9BN14dykwdMk5M=; b=UmxOkNqV/lBydNtMI1yqHsz60 ve88PELqrwL3sqUA5g0lZMWN0s8n9SHTd55WHyxYowIvg57Vh3zXVXnPfsgdUqL2P6lvpwPK2nUGY jL3SvYeHJ3sKjeiIlBYtl8lMCBo6LKmDKx+MPh+BCfzqmKriQq05PoNO8c1vfBF5/rMG5mzUGcSCY RyDTpbfjhj+y/EXfZJLlVAWvYj1X2lqFSJvAdxo3VxpXXx+zbh+ADW8piUKUeoxrWmavJ7caL5F6O Vf6hmLbB+gTNq7FXLuF7jgJPCnJCMc1JAdaYbLt8ROapsrt+3JnHPvATfuuTYqrCQhYi2F09M0dLh zOj/ymw2Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60232) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j9QgM-0005fZ-ES; Wed, 04 Mar 2020 09:51:14 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j9QgK-0006ox-AX; Wed, 04 Mar 2020 09:51:12 +0000 Date: Wed, 4 Mar 2020 09:51:12 +0000 From: Russell King - ARM Linux admin To: Laurentiu Tudor Subject: Re: [PATCH] iommu: silence iommu group prints Message-ID: <20200304095112.GY25745@shell.armlinux.org.uk> References: <20200228100644.GT25745@shell.armlinux.org.uk> <95af8fc3-d7b1-3b58-afc1-d203d7538b95@arm.com> <20200303154959.GR25745@shell.armlinux.org.uk> <20200303221745.GV25745@shell.armlinux.org.uk> <62b3d48a-af5f-b44b-07cd-83aa7663c45f@nxp.com> <20200304093330.GX25745@shell.armlinux.org.uk> <78f175be-0701-b6cd-8feb-1343f9982d4c@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <78f175be-0701-b6cd-8feb-1343f9982d4c@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Diana Madalina Craciun , iommu@lists.linux-foundation.org, Robin Murphy , Ioana Ciornei X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Mar 04, 2020 at 11:42:16AM +0200, Laurentiu Tudor wrote: > On 04.03.2020 11:33, Russell King - ARM Linux admin wrote: > > On Wed, Mar 04, 2020 at 10:56:06AM +0200, Laurentiu Tudor wrote: > > > > > > On 04.03.2020 00:17, Russell King - ARM Linux admin wrote: > > > > On Tue, Mar 03, 2020 at 05:55:05PM +0200, Laurentiu Tudor wrote: > > > > > From c98dc05cdd45ae923654f2427985bd28bcde4bb2 Mon Sep 17 00:00:00 2001 > > > > > From: Laurentiu Tudor > > > > > Date: Thu, 13 Feb 2020 11:59:12 +0200 > > > > > Subject: [PATCH 1/4] bus: fsl-mc: add custom .dma_configure implementation > > > > > Content-Type: text/plain; charset="us-ascii" > > > > > > > > > > The devices on this bus are not discovered by way of device tree > > > > > but by queries to the firmware. It makes little sense to trick the > > > > > generic of layer into thinking that these devices are of related so > > > > > that we can get our dma configuration. Instead of doing that, add > > > > > our custom dma configuration implementation. > > > > > > > > Firstly, applying this to v5.5 results in a build failure, due to a > > > > missing linux/iommu.h include. > > > > > > > > Secondly, this on its own appears to make the DPAA2 network interfaces > > > > completely disappear. Looking in /sys/bus/fsl-mc/drivers/*, none of > > > > the DPAA2 drivers are bound to anything, and looking in > > > > /sys/bus/fsl-mc/devices/, there is: > > > > > > > > lrwxrwxrwx 1 root root 0 Mar 3 22:06 dprc.1 -> ../../../devices/platform/soc/80c000000.fsl-mc/dprc.1 > > > > > > > > This is booting with u-boot, so using DT rather than ACPI. > > > > > > > > > Signed-off-by: Laurentiu Tudor > > > > > --- > > > > > drivers/bus/fsl-mc/fsl-mc-bus.c | 42 ++++++++++++++++++++++++++++++++- > > > > > 1 file changed, 41 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c > > > > > index 36eb25f82c8e..3df015eedae4 100644 > > > > > --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > > > > > +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > > > > > @@ -132,11 +132,51 @@ static int fsl_mc_bus_uevent(struct device *dev, struct kobj_uevent_env *env) > > > > > static int fsl_mc_dma_configure(struct device *dev) > > > > > { > > > > > struct device *dma_dev = dev; > > > > > + struct iommu_fwspec *fwspec; > > > > > + const struct iommu_ops *iommu_ops; > > > > > + struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev); > > > > > + int ret; > > > > > + u32 icid; > > > > > + > > > > > + /* Skip DMA setup for devices that are not DMA masters */ > > > > > + if (dev->type == &fsl_mc_bus_dpmcp_type || > > > > > + dev->type == &fsl_mc_bus_dpbp_type || > > > > > + dev->type == &fsl_mc_bus_dpcon_type || > > > > > + dev->type == &fsl_mc_bus_dpio_type) > > > > > + return 0; > > > > > while (dev_is_fsl_mc(dma_dev)) > > > > > dma_dev = dma_dev->parent; > > > > > - return of_dma_configure(dev, dma_dev->of_node, 0); > > > > > + fwspec = dev_iommu_fwspec_get(dma_dev); > > > > > + if (!fwspec) > > > > > + return -ENODEV; > > > > > > > > The problem appears to be here - fwspec is NULL for dprc.1. > > > > > > Ok, that's because the iommu config is missing from the DT node that's > > > exposing the MC firmware. I've attached a fresh set of patches that include > > > on top the missing config and a workaround that makes MC work over SMMU. > > > Also added the missing #include, thanks for pointing out. > > > Let me know how it goes. > > > > Shouldn't patch 6 should be first in the series, so that patch 1 does > > not cause a regression and bisectability damage? > > > > Correct, width one comment: both 5 and 6 should go first. Once iommu-map is > added in the device tree the workaround for MC with the > arm-smmu.disable_bypass boot arg will no longer work. So, wouldn't it be reasonable to arrange the patch series like that? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu