From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Ri2p=4V=vger.kernel.org=linux-btrfs-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E4AE6C3F2D8
	for <linux-btrfs@archiver.kernel.org>; Wed,  4 Mar 2020 13:33:10 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id BC41B2166E
	for <linux-btrfs@archiver.kernel.org>; Wed,  4 Mar 2020 13:33:10 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729175AbgCDNdK (ORCPT <rfc822;linux-btrfs@archiver.kernel.org>);
        Wed, 4 Mar 2020 08:33:10 -0500
Received: from mx2.suse.de ([195.135.220.15]:56188 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726275AbgCDNdJ (ORCPT <rfc822;linux-btrfs@vger.kernel.org>);
        Wed, 4 Mar 2020 08:33:09 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx2.suse.de (Postfix) with ESMTP id 7AC73B210;
        Wed,  4 Mar 2020 13:33:07 +0000 (UTC)
Received: by ds.suse.cz (Postfix, from userid 10065)
        id D8F1ADA7B4; Wed,  4 Mar 2020 14:32:44 +0100 (CET)
Date:   Wed, 4 Mar 2020 14:32:44 +0100
From:   David Sterba <dsterba@suse.cz>
To:     Anand Jain <anand.jain@oracle.com>
Cc:     dsterba@suse.cz, David Sterba <dsterba@suse.com>,
        Qu Wenruo <quwenruo.btrfs@gmx.com>,
        linux-btrfs@vger.kernel.org, Nikolay Borisov <nborisov@suse.com>
Subject: Re: [PATCH] btrfs-progs: convert, warn if converting a fs which
 won't mount
Message-ID: <20200304133244.GP2902@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz, Anand Jain <anand.jain@oracle.com>,
        David Sterba <dsterba@suse.com>, Qu Wenruo <quwenruo.btrfs@gmx.com>,
        linux-btrfs@vger.kernel.org, Nikolay Borisov <nborisov@suse.com>
References: <1582877026-5487-1-git-send-email-anand.jain@oracle.com>
 <af69d1ab-4609-d603-980c-b8a6cfb87f43@gmx.com>
 <39c3e381-b49e-a571-d058-a01734b8b4a9@oracle.com>
 <20200303174422.GM2902@twin.jikos.cz>
 <fc02b904-5af5-035f-bb62-a2982409ffbe@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fc02b904-5af5-035f-bb62-a2982409ffbe@oracle.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Sender: linux-btrfs-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-btrfs.vger.kernel.org>
X-Mailing-List: linux-btrfs@vger.kernel.org

On Wed, Mar 04, 2020 at 10:14:20AM +0800, Anand Jain wrote:
> > the conversion.
> > 
> > I've tried mkfs.ext4 with 64k block size and it warns and in the
> > interactive session wants to confirm that by the user:
> > 
> >    $ mkfs.ext4 -b 64k img
> >    Warning: blocksize 65536 not usable on most systems.
> >    mke2fs 1.45.5 (07-Jan-2020)
> >    img contains a ext4 file system
> > 	  created on Tue Mar  3 18:41:46 2020
> >    Proceed anyway? (y,N) y
> >    mkfs.ext4: 65536-byte blocks too big for system (max 4096)
> >    Proceed anyway? (y,N) y
> >    Warning: 65536-byte blocks too big for system (max 4096), forced to continue
> >    Creating filesystem with 32768 64k blocks and 32768 inodes
> > 
> >    Allocating group tables: done
> >    Writing inode tables: done
> >    Creating journal (4096 blocks): done
> >    Writing superblocks and filesystem accounting information: done
> > 
> 
> Just warn is reasonable. But I don't think you meant to introduce
> interactive part similar to mkfs.ext4 in btrfs-convert?

No I haven't meant that. So let's go with the warning.