From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bernard Metzler <bmt@zurich.ibm.com>
Cc: chuck.lever@oracle.com, dledford@redhat.com, leon@kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, parav@mellanox.com,
syzkaller-bugs@googlegroups.com, willy@infradead.org
Subject: Re: [PATCH for-rc] RDMA/siw: Fix passive connection establishment
Date: Wed, 4 Mar 2020 14:24:11 -0400 [thread overview]
Message-ID: <20200304182411.GA1201@ziepe.ca> (raw)
In-Reply-To: <20200228173534.26815-1-bmt@zurich.ibm.com>
On Fri, Feb 28, 2020 at 06:35:34PM +0100, Bernard Metzler wrote:
> Holding the rtnl_lock while iterating a devices interface
> address list potentially causes deadlocks with the
> cma_netdev_callback. While this was implemented to
> limit the scope of a wildcard listen to addresses
> of the current device only, a better solution limits
> the scope of the socket to the device. This completely
> avoiding locking, and also results in significant code
> simplification.
>
> Reported-by: syzbot+55de90ab5f44172b0c90@syzkaller.appspotmail.com
> Suggested-by: Jason Gunthorpe <jgg@ziepe.ca>
> Signed-off-by: Bernard Metzler <bmt@zurich.ibm.com>
> ---
> drivers/infiniband/sw/siw/siw_cm.c | 137 +++++++----------------------
> 1 file changed, 31 insertions(+), 106 deletions(-)
Applied to for-next, the possibility of hitting the locking inversion
found by syzkaller is really remote as you'd have to run siw on top of
bond and then do horrible things to the bond.
Jason
prev parent reply other threads:[~2020-03-04 18:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 17:35 [PATCH for-rc] RDMA/siw: Fix passive connection establishment Bernard Metzler
2020-03-04 18:24 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304182411.GA1201@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bmt@zurich.ibm.com \
--cc=chuck.lever@oracle.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.