From: Josh Triplett <josh@joshtriplett.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org, jlayton@kernel.org
Subject: Re: [PATCH 6/6] io_uring: allow specific fd for IORING_OP_ACCEPT
Date: Wed, 4 Mar 2020 11:02:23 -0800 [thread overview]
Message-ID: <20200304190223.GA16251@localhost> (raw)
In-Reply-To: <20200304180016.28212-7-axboe@kernel.dk>
On Wed, Mar 04, 2020 at 11:00:16AM -0700, Jens Axboe wrote:
> sqe->len can be set to a specific fd we want to use for accept4(), so
> it uses that one instead of just assigning a free unused one.
[...]
> + accept->open_fd = READ_ONCE(sqe->len);
> + if (!accept->open_fd)
> + accept->open_fd = -1;
0 is a valid file descriptor. I realize that it seems unlikely, but I
went to a fair bit of trouble in my patch series to ensure that
userspace could use any valid file descriptor openat2, without a corner
case like "you can't open as file descriptor 0", even though it would
have been more convenient to just say "if you pass a non-zero fd in
open_how". Please consider accepting a flag to determine the validity of
open_fd.
- Josh Triplett
next prev parent reply other threads:[~2020-03-04 19:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 18:00 [PATCHSET v2 0/6] Support selectable file descriptors Jens Axboe
2020-03-04 18:00 ` [PATCH 1/6] fs: openat2: Extend open_how to allow userspace-selected fds Jens Axboe
2020-03-04 18:00 ` [PATCH 2/6] io_uring: move CLOSE req->file checking into handler Jens Axboe
2020-03-04 18:00 ` [PATCH 3/6] io_uring: move read/write side file based prep into op handler Jens Axboe
2020-03-04 18:00 ` [PATCH 4/6] io_uring: support deferred retrival of file from fd Jens Axboe
2020-03-04 18:00 ` [PATCH 5/6] net: allow specific fd selection for __sys_accept4_file() Jens Axboe
2020-03-04 18:00 ` [PATCH 6/6] io_uring: allow specific fd for IORING_OP_ACCEPT Jens Axboe
2020-03-04 19:02 ` Josh Triplett [this message]
2020-03-04 19:09 ` Jens Axboe
2020-03-04 19:51 ` Josh Triplett
2020-03-04 19:03 ` [PATCHSET v2 0/6] Support selectable file descriptors Josh Triplett
2020-03-04 19:10 ` Jens Axboe
2020-03-04 19:28 ` Jeff Layton
2020-03-04 19:50 ` Jens Axboe
2020-03-04 19:56 ` Josh Triplett
2020-03-04 20:00 ` Jens Axboe
2020-03-04 20:09 ` Josh Triplett
2020-03-04 20:14 ` Jens Axboe
2020-03-09 20:33 ` Stefan Metzmacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304190223.GA16251@localhost \
--to=josh@joshtriplett.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=jlayton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.