From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330D5C3F2CE for ; Wed, 4 Mar 2020 21:55:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11CD320732 for ; Wed, 4 Mar 2020 21:55:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388431AbgCDVzm (ORCPT ); Wed, 4 Mar 2020 16:55:42 -0500 Received: from elvis.franken.de ([193.175.24.41]:51174 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728926AbgCDVzm (ORCPT ); Wed, 4 Mar 2020 16:55:42 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1j9bzN-0000mm-00; Wed, 04 Mar 2020 22:55:37 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 832E3C0EF9; Wed, 4 Mar 2020 21:31:44 +0100 (CET) Date: Wed, 4 Mar 2020 21:31:44 +0100 From: Thomas Bogendoerfer To: afzal mohammed Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ralf Baechle , Paul Burton , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, "Maciej W. Rozycki" , Jiaxun Yang , Keguang Zhang , Huacai Chen , John Crispin Subject: Re: [PATCH v3] MIPS: Replace setup_irq() by request_irq() Message-ID: <20200304203144.GA4323@alpha.franken.de> References: <20200304005549.5832-1-afzal.mohd.ma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200304005549.5832-1-afzal.mohd.ma@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 04, 2020 at 06:25:43AM +0530, afzal mohammed wrote: > Hi mips maintainers, > > if okay w/ this change, please consider taking it thr' your tree, else please > let me know. sorry this doesn't even compile for the first platform I've tested: In file included from /home/tbogendoerfer/wip/korg/linux/arch/mips/sni/reset.c:11:0: /home/tbogendoerfer/wip/korg/linux/arch/mips/include/asm/sni.h:242:8: error: unknown type name ‘irqreturn_t’ extern irqreturn_t sni_isa_irq_handler(int dummy, void *p); ~~~~~~~~~~~ Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA14DC3F2D7 for ; Wed, 4 Mar 2020 21:55:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E64420716 for ; Wed, 4 Mar 2020 21:55:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VSxfjtV9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E64420716 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pFjuVVvyjHX2q78NQ2jK/vmBtFoA2TdG1EImZazUPGU=; b=VSxfjtV9xN3wKB sSb4unUS9LTTGl/hYaLFoEeSGM2A+4k3to8hjbpUeDFvyV5PO9XBDEQ2yoH5Q9lQa1GW7FxubIXh0 eXpXexMND4IyCtcrEAm9B6SRcS+1o8b101aWbnde+e1UyMj1UQXGxPCsC9ZhEZGUv7jecukvT+UZ2 52ywcBIx7zpAbIbqpBhN8uz04W11UygyCR8kMSxapXQTxyBA1F5pq7V6P7dDQi/dighBTR/qy32XP PwVOOeLnoQXfobwzbb1L7pLoSftv/8AG3H6ekuXK8bjWbcLwDEkfyTJwxrh4M4vy9ShmOfDG1Unqq Z+dQfAv+MvnUAdsyI6xw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9bzY-0003z5-76; Wed, 04 Mar 2020 21:55:48 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9bzV-0003wb-2B for linux-arm-kernel@lists.infradead.org; Wed, 04 Mar 2020 21:55:46 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1j9bzN-0000mm-00; Wed, 04 Mar 2020 22:55:37 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 832E3C0EF9; Wed, 4 Mar 2020 21:31:44 +0100 (CET) Date: Wed, 4 Mar 2020 21:31:44 +0100 From: Thomas Bogendoerfer To: afzal mohammed Subject: Re: [PATCH v3] MIPS: Replace setup_irq() by request_irq() Message-ID: <20200304203144.GA4323@alpha.franken.de> References: <20200304005549.5832-1-afzal.mohd.ma@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200304005549.5832-1-afzal.mohd.ma@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200304_135545_255002_5523EF98 X-CRM114-Status: UNSURE ( 8.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Paul Burton , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Jiaxun Yang , "Maciej W. Rozycki" , John Crispin , Huacai Chen , Keguang Zhang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXIgMDQsIDIwMjAgYXQgMDY6MjU6NDNBTSArMDUzMCwgYWZ6YWwgbW9oYW1tZWQg d3JvdGU6Cj4gSGkgbWlwcyBtYWludGFpbmVycywKPiAKPiBpZiBva2F5IHcvIHRoaXMgY2hhbmdl LCBwbGVhc2UgY29uc2lkZXIgdGFraW5nIGl0IHRocicgeW91ciB0cmVlLCBlbHNlIHBsZWFzZQo+ IGxldCBtZSBrbm93LgoKc29ycnkgdGhpcyBkb2Vzbid0IGV2ZW4gY29tcGlsZSBmb3IgdGhlIGZp cnN0IHBsYXRmb3JtIEkndmUgdGVzdGVkOgoKSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC9ob21lL3Ri b2dlbmRvZXJmZXIvd2lwL2tvcmcvbGludXgvYXJjaC9taXBzL3NuaS9yZXNldC5jOjExOjA6Ci9o b21lL3Rib2dlbmRvZXJmZXIvd2lwL2tvcmcvbGludXgvYXJjaC9taXBzL2luY2x1ZGUvYXNtL3Nu aS5oOjI0Mjo4OiBlcnJvcjogdW5rbm93biB0eXBlIG5hbWUg4oCYaXJxcmV0dXJuX3TigJkKIGV4 dGVybiBpcnFyZXR1cm5fdCBzbmlfaXNhX2lycV9oYW5kbGVyKGludCBkdW1teSwgdm9pZCAqcCk7 CiAgICAgICAgfn5+fn5+fn5+fn4KClRob21hcy4KCi0tIApDcmFwIGNhbiB3b3JrLiBHaXZlbiBl bm91Z2ggdGhydXN0IHBpZ3Mgd2lsbCBmbHksIGJ1dCBpdCdzIG5vdCBuZWNlc3NhcmlseSBhCmdv b2QgaWRlYS4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBb IFJGQzE5MjUsIDIuMyBdCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==