From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BEEFC3F2D1 for ; Thu, 5 Mar 2020 12:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0181A2146E for ; Thu, 5 Mar 2020 12:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583410594; bh=roosBaQC1wc0P0te4EN646OO0+no/9nDa2qx6cZDWKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PMKmZUAgftqwr2NaTYu+/5268vyoEJbLDuPMTCbc7eJJbzDW+wvkX+t4Ncv+7dAgp 4D6wkvK3wy1+YSMvIg3sppccybqjUMDngDFIQjytilg++xF11VSKB92laO5zU5uIdm Bmr/3OoecxsypGNI1IdqZPr1KgfUDnu7gVrGhTIw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725897AbgCEMQd (ORCPT ); Thu, 5 Mar 2020 07:16:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:47156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725893AbgCEMQd (ORCPT ); Thu, 5 Mar 2020 07:16:33 -0500 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5500520658; Thu, 5 Mar 2020 12:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583410591; bh=roosBaQC1wc0P0te4EN646OO0+no/9nDa2qx6cZDWKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xKYo6xsItyf/qYmZVGkfhatPcSULvvwCGv0Au7U8Hn27a/89scd3ag9WlqjuBzBi4 t4AYDU21U2xbsJ5elhzrdAlnzf3SZm8kf3VobdvWbGd7WSDcOlueO7xX4DT+1hH5a0 d5+lKgYN5wFbT9LrOvrm3Z9q+Il1DDWWv/UFzB10= Date: Thu, 5 Mar 2020 14:16:28 +0200 From: Leon Romanovsky To: Danil Kipnis Cc: Jinpu Wang , Jack Wang , linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Jens Axboe , Christoph Hellwig , Sagi Grimberg , Bart Van Assche , Doug Ledford , Jason Gunthorpe , Roman Penyaev , Pankaj Gupta Subject: Re: [PATCH v9 10/25] RDMA/rtrs: server: main functionality Message-ID: <20200305121628.GD184088@unreal> References: <20200221104721.350-1-jinpuwang@gmail.com> <20200221104721.350-11-jinpuwang@gmail.com> <20200303113740.GM121803@unreal> <20200303165906.GO121803@unreal> <20200305080019.GB184088@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Mar 05, 2020 at 01:01:08PM +0100, Danil Kipnis wrote: > On Thu, 5 Mar 2020, 09:00 Leon Romanovsky, wrote: > > > On Wed, Mar 04, 2020 at 12:03:32PM +0100, Jinpu Wang wrote: > > > On Tue, Mar 3, 2020 at 5:59 PM Leon Romanovsky wrote: > > > > > > > > On Tue, Mar 03, 2020 at 05:41:27PM +0100, Jinpu Wang wrote: > > > > > On Tue, Mar 3, 2020 at 12:37 PM Leon Romanovsky > > wrote: > > > > > > > > > > > > On Fri, Feb 21, 2020 at 11:47:06AM +0100, Jack Wang wrote: > > > > > > > From: Jack Wang > > > > > > > > > > > > > > This is main functionality of rtrs-server module, which accepts > > > > > > > set of RDMA connections (so called rtrs session), > > creates/destroys > > > > > > > sysfs entries associated with rtrs session and notifies upper > > layer > > > > > > > (user of RTRS API) about RDMA requests or link events. > > > > > > > > > > > > > > Signed-off-by: Danil Kipnis > > > > > > > Signed-off-by: Jack Wang > > > > > > > --- > > > > > > > drivers/infiniband/ulp/rtrs/rtrs-srv.c | 2164 > > ++++++++++++++++++++++++ > > > > > > > 1 file changed, 2164 insertions(+) > > > > > > > create mode 100644 drivers/infiniband/ulp/rtrs/rtrs-srv.c > > > > > > > > > > > > > > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c > > b/drivers/infiniband/ulp/rtrs/rtrs-srv.c > > > > > > > new file mode 100644 > > > > > > > index 000000000000..e60ee6dd675d > > > > > > > --- /dev/null > > > > > > > +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c > > > > > > > @@ -0,0 +1,2164 @@ > > > > > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > > > > > +/* > > > > > > > + * RDMA Transport Layer > > > > > > > + * > > > > > > > + * Copyright (c) 2014 - 2018 ProfitBricks GmbH. All rights > > reserved. > > > > > > > + * Copyright (c) 2018 - 2019 1&1 IONOS Cloud GmbH. All rights > > reserved. > > > > > > > + * Copyright (c) 2019 - 2020 1&1 IONOS SE. All rights reserved. > > > > > > > + */ > > > > > > > + > > > > > > > +#undef pr_fmt > > > > > > > +#define pr_fmt(fmt) KBUILD_MODNAME " L" __stringify(__LINE__) > > ": " fmt > > > > > > > + > > > > > > > +#include > > > > > > > +#include > > > > > > > + > > > > > > > +#include "rtrs-srv.h" > > > > > > > +#include "rtrs-log.h" > > > > > > > + > > > > > > > +MODULE_DESCRIPTION("RDMA Transport Server"); > > > > > > > +MODULE_LICENSE("GPL"); > > > > > > > + > > > > > > > +/* Must be power of 2, see mask from mr->page_size in > > ib_sg_to_pages() */ > > > > > > > +#define DEFAULT_MAX_CHUNK_SIZE (128 << 10) > > > > > > > +#define DEFAULT_SESS_QUEUE_DEPTH 512 > > > > > > > +#define MAX_HDR_SIZE PAGE_SIZE > > > > > > > +#define MAX_SG_COUNT ((MAX_HDR_SIZE - sizeof(struct > > rtrs_msg_rdma_read)) \ > > > > > > > + / sizeof(struct rtrs_sg_desc)) > > > > > > > + > > > > > > > +/* We guarantee to serve 10 paths at least */ > > > > > > > +#define CHUNK_POOL_SZ 10 > > > > > > > + > > > > > > > +static struct rtrs_rdma_dev_pd dev_pd; > > > > > > > +static mempool_t *chunk_pool; > > > > > > > +struct class *rtrs_dev_class; > > > > > > > + > > > > > > > +static int __read_mostly max_chunk_size = > > DEFAULT_MAX_CHUNK_SIZE; > > > > > > > +static int __read_mostly sess_queue_depth = > > DEFAULT_SESS_QUEUE_DEPTH; > > > > > > > + > > > > > > > +static bool always_invalidate = true; > > > > > > > +module_param(always_invalidate, bool, 0444); > > > > > > > +MODULE_PARM_DESC(always_invalidate, > > > > > > > + "Invalidate memory registration for contiguous > > memory regions before accessing."); > > > > > > > + > > > > > > > +module_param_named(max_chunk_size, max_chunk_size, int, 0444); > > > > > > > +MODULE_PARM_DESC(max_chunk_size, > > > > > > > + "Max size for each IO request, when change the > > unit is in byte (default: " > > > > > > > + __stringify(DEFAULT_MAX_CHUNK_SIZE) "KB)"); > > > > > > > + > > > > > > > +module_param_named(sess_queue_depth, sess_queue_depth, int, > > 0444); > > > > > > > +MODULE_PARM_DESC(sess_queue_depth, > > > > > > > + "Number of buffers for pending I/O requests to > > allocate per session. Maximum: " > > > > > > > + __stringify(MAX_SESS_QUEUE_DEPTH) " (default: " > > > > > > > + __stringify(DEFAULT_SESS_QUEUE_DEPTH) ")"); > > > > > > > > > > > > We don't like module parameters in the RDMA. > > > > > Hi Leon, > > > > > > > > > > These paramters are affecting resouce usage/performance, I think > > would > > > > > be good to have them as module parameters, > > > > > so admin could choose based their needs. > > > > > > > > It is premature optimization before second user comes, also it is > > > > based on the assumption that everyone uses modules, which is not true. > > > The idea to have module parameters is to cover more use cases, IMHO. > > > > > > Even you builtin the module to the kernel, you can still change the > > > module parameters > > > by passing the "moduls_name.paramters" in kernel command line, eg: > > > kvm.nx_huge_pages=true > > > > I know about that, but it doesn't make them helpful. > > > > Thanks > > > Hi Leon, > > Queue_depth and max_chunksize parameters control the tradeoff between > throuput performance and memory consumption. We do use them to set > different values for storages equipped with SSDs (fast) and on storages > equipped with HDDs (slow). The last parameter always_invaldate enforces the > invalidation of an rdma buffer before its hand over to the block layer. We > set it to no in our datacenters, since they are closed and malicious > clients are not a threat in our scenario. In general case it defaults to > yes, as requested by Jason. Our admins need to have control over those > control knobs somehow... We could make sysfs entries out of them or > something, but would it really make sense? blk_queue_nonrot() inside your code? > > Thank you, > Danil > > > > > > > > Thanks > > > Thanks > >