All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Dongli Zhang <dongli.zhang@oracle.com>
Cc: bijan.mottahedeh@oracle.com, hch@lst.de,
	linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCHv2 2/3] nvme-pci: Remove two-pass completions
Date: Fri, 6 Mar 2020 00:15:23 +0900	[thread overview]
Message-ID: <20200305151523.GA28317@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <b25de82c-115f-50d3-6752-f4f91a5623ae@oracle.com>

On Thu, Mar 05, 2020 at 01:50:58AM -0800, Dongli Zhang wrote:
> Hi Keith,
> 
> On 3/4/20 10:12 AM, Keith Busch wrote:
> > Completion handling had been done in two steps: find all new completions
> > under a lock, then handle those completions outside the lock. This was
> > done to make the locked section as short as possible so that other
> > threads using the same lock wait less time.
> > 
> > The driver no longer shares locks during completion, and is in fact
> > lockless for interrupt driven queues, so the optimization no longer
> 
> About "no longer shares locks", would you mind share is it a specific nvme
> driver commit, or the transition from sq to mq?

They're all nvme specific commits. For the record, nvme never
transitioned from 'sq' to 'mq'. We were bio-based before 'mq'
existed.

Commit splitting locks: 1ab0cd6966fc4a7e9dfbd7c6eda917ae9c977f42

Commit removing cq lock: 3a7afd8ee42a68d4f24ab9c947a4ef82d4d52375

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-03-05 15:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 18:12 [PATCHv2 0/3] nvme-pci: process cq improvements Keith Busch
2020-03-04 18:12 ` [PATCHv2 1/3] nvme-pci: Remove tag from process cq Keith Busch
2020-03-05 20:53   ` Sagi Grimberg
2020-03-10 16:56   ` Christoph Hellwig
2020-03-04 18:12 ` [PATCHv2 2/3] nvme-pci: Remove two-pass completions Keith Busch
2020-03-05  9:50   ` Dongli Zhang
2020-03-05 15:15     ` Keith Busch [this message]
2020-03-05 20:53   ` Sagi Grimberg
2020-03-10 16:57   ` Christoph Hellwig
2020-03-04 18:12 ` [PATCHv2 3/3] nvme-pci: Simplify nvme_poll_irqdisable Keith Busch
2020-03-05 20:55   ` Sagi Grimberg
2020-03-10 17:02   ` Christoph Hellwig
2020-03-10 19:16     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200305151523.GA28317@redsun51.ssa.fujisawa.hgst.com \
    --to=kbusch@kernel.org \
    --cc=bijan.mottahedeh@oracle.com \
    --cc=dongli.zhang@oracle.com \
    --cc=hch@lst.de \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.