From: Peter Xu <peterx@redhat.com>
To: linmiaohe <linmiaohe@huawei.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: Drop gfn_to_pfn_atomic()
Date: Thu, 5 Mar 2020 10:49:14 -0500 [thread overview]
Message-ID: <20200305154914.GE7146@xz-x1> (raw)
In-Reply-To: <2256821e496c45f5baf97f3f8f884d59@huawei.com>
On Thu, Mar 05, 2020 at 01:52:24AM +0000, linmiaohe wrote:
> Peter Xu <peterx@redhat.com> writes:
> >It's never used anywhere now.
> >
> >Signed-off-by: Peter Xu <peterx@redhat.com>
> >---
> > include/linux/kvm_host.h | 1 -
> > virt/kvm/kvm_main.c | 6 ------
> > 2 files changed, 7 deletions(-)
>
> It seems we prefer to use kvm_vcpu_gfn_to_pfn_atomic instead now. :)
> Patch looks good, but maybe we should update Documentation/virt/kvm/locking.rst too:
> In locking.rst:
> For direct sp, we can easily avoid it since the spte of direct sp is fixed
> to gfn. For indirect sp, before we do cmpxchg, we call gfn_to_pfn_atomic()
> to pin gfn to pfn, because after gfn_to_pfn_atomic()
>
> Thanks.
> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Yes we should update the document, however instead of replacing with
the vcpu helper, I'd rather reorganize the locking doc for a bit more
because the fast page fault is not enabled for indirect sp at all,
afaict...
I'll add a pre-requisite patch to refine the document, and keep your
r-b for this patch.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2020-03-05 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 1:52 [PATCH] KVM: Drop gfn_to_pfn_atomic() linmiaohe
2020-03-05 15:49 ` Peter Xu [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-04 17:51 Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305154914.GE7146@xz-x1 \
--to=peterx@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.