From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7846BC10F25 for ; Fri, 6 Mar 2020 11:44:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 508012072A for ; Fri, 6 Mar 2020 11:44:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726957AbgCFLn5 (ORCPT ); Fri, 6 Mar 2020 06:43:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:39220 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725827AbgCFLn5 (ORCPT ); Fri, 6 Mar 2020 06:43:57 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1C4D0AC23; Fri, 6 Mar 2020 11:43:55 +0000 (UTC) From: Nicolas Saenz Julienne To: linux-kernel@vger.kernel.org Cc: linux-usb@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com, gregkh@linuxfoundation.org, tim.gover@raspberrypi.org, linux-pci@vger.kernel.org, wahrenst@gmx.net, Nicolas Saenz Julienne , Andrew Murray Subject: [PATCH v4 0/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Date: Fri, 6 Mar 2020 12:43:44 +0100 Message-Id: <20200306114348.5172-1-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be loaded directly from an EEPROM or, if not present, by the SoC's VideCore. This series adds support for the later. Note that there are a set of constraints we have to consider (some of them I missed on v1): - We need to make sure the VideoCore firmware interface is up and running before running the VL805 firmware load call. - There is no way to discern RPi4's VL805 chip from other platforms', so we need the firmware load to happen *before* running quirk_usb_handoff_xhci(). Failure to do so results in an unwarranted 5 second wait while the fixup code polls xHC's unexisting state. As per Stefan Wahren's comments I tested the behaviour on outdated firmware. Boards dependent on this will not boot if firmware is not up-to-date. Older boards with outdated firmware will fail to execute the VideoCore firmware call, but xHCI will perform reliably. I added a warning printout in case of failure. I'm aware that Florian Fianelli noted on the previous revision that waiting on the VideoCore firmware interface during PCIe's probe is far from ideal. But this was before taking into account the second constraint mentioned above. Impact on non RPi4 boards is minimal. --- Changes since v3: - Addressed Greg's comments There was no v2, my bad. Changes since v1: - Addressed Floarians comments Nicolas Saenz Julienne (4): soc: bcm2835: Sync xHCI reset firmware property with downstream firmware: raspberrypi: Introduce vl805 init routine PCI: brcmstb: Wait for Raspberry Pi's firmware when present USB: pci-quirks: Add Raspberry Pi 4 quirk drivers/firmware/Kconfig | 1 + drivers/firmware/raspberrypi.c | 38 ++++++++++++++++++++++ drivers/pci/controller/pcie-brcmstb.c | 15 +++++++++ drivers/usb/host/pci-quirks.c | 16 +++++++++ include/soc/bcm2835/raspberrypi-firmware.h | 9 ++++- 5 files changed, 78 insertions(+), 1 deletion(-) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4774EC10F00 for ; Fri, 6 Mar 2020 11:44:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19A442072A for ; Fri, 6 Mar 2020 11:44:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Llyk9nNj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19A442072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=GBRqY+ZlG9OubVSKnDeYLCVruZ7J7nz5KtdbtEvy1HQ=; b=Llyk9nNjISHUkT K4Ku8ivAfJAFq8EtCWmNU5Vfm/GB9CiAfeVWDjzO1adIX8LZWq6ETkoy6jMVp61Q+6Iooroz7ZXHm feW2+eKYdhYcGhzKOBQX7Ia2dM0TG/dNkRTDX7Gf6WeBWVsNpUR01Mxt2D/8bEYsGgmezccZziOcj 7Bm8D2QK+Mf4RAyRJW7NZxNu1mozJHQyOuAe6kMF5lnQ2edUlA1aLWjwVXTxigyUC9jfOkAC0Wsq0 5IeRyQzPbTzjrJ675bZndXZNpapvVspYZ+TiOEpAnUFCQoZU+MmNjDDAOTdr83Jelpa0WthvuAFPy 6EW/RQVfzNzRfdobIgVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jABOn-0005GK-Gs; Fri, 06 Mar 2020 11:44:13 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jABOY-00051D-03; Fri, 06 Mar 2020 11:43:59 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1C4D0AC23; Fri, 6 Mar 2020 11:43:55 +0000 (UTC) From: Nicolas Saenz Julienne To: linux-kernel@vger.kernel.org Subject: [PATCH v4 0/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Date: Fri, 6 Mar 2020 12:43:44 +0100 Message-Id: <20200306114348.5172-1-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200306_034358_187453_F65C5942 X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f.fainelli@gmail.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, Nicolas Saenz Julienne , tim.gover@raspberrypi.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Andrew Murray , linux-arm-kernel@lists.infradead.org, wahrenst@gmx.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be loaded directly from an EEPROM or, if not present, by the SoC's VideCore. This series adds support for the later. Note that there are a set of constraints we have to consider (some of them I missed on v1): - We need to make sure the VideoCore firmware interface is up and running before running the VL805 firmware load call. - There is no way to discern RPi4's VL805 chip from other platforms', so we need the firmware load to happen *before* running quirk_usb_handoff_xhci(). Failure to do so results in an unwarranted 5 second wait while the fixup code polls xHC's unexisting state. As per Stefan Wahren's comments I tested the behaviour on outdated firmware. Boards dependent on this will not boot if firmware is not up-to-date. Older boards with outdated firmware will fail to execute the VideoCore firmware call, but xHCI will perform reliably. I added a warning printout in case of failure. I'm aware that Florian Fianelli noted on the previous revision that waiting on the VideoCore firmware interface during PCIe's probe is far from ideal. But this was before taking into account the second constraint mentioned above. Impact on non RPi4 boards is minimal. --- Changes since v3: - Addressed Greg's comments There was no v2, my bad. Changes since v1: - Addressed Floarians comments Nicolas Saenz Julienne (4): soc: bcm2835: Sync xHCI reset firmware property with downstream firmware: raspberrypi: Introduce vl805 init routine PCI: brcmstb: Wait for Raspberry Pi's firmware when present USB: pci-quirks: Add Raspberry Pi 4 quirk drivers/firmware/Kconfig | 1 + drivers/firmware/raspberrypi.c | 38 ++++++++++++++++++++++ drivers/pci/controller/pcie-brcmstb.c | 15 +++++++++ drivers/usb/host/pci-quirks.c | 16 +++++++++ include/soc/bcm2835/raspberrypi-firmware.h | 9 ++++- 5 files changed, 78 insertions(+), 1 deletion(-) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel