Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on next-20200305] [also build test ERROR on v5.6-rc4] [cannot apply to rockchip/for-next shawnguo/for-next sunxi/sunxi/for-next tegra/for-next linus/master v5.6-rc4 v5.6-rc3 v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Convert-drivers-to-drm_simple_encoder_init/20200306-045931 base: 47466dcf84ee66a973ea7d2fca7e582fe9328932 config: arm64-defconfig (attached as .config) compiler: clang version 11.0.0 (git://gitmirror/llvm_project a0cd413426479abb207381bdbab862f3dfb3ce7d) reproduce: # FIXME the reproduce steps for clang is not ready yet If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): >> drivers/gpu/drm/exynos/exynos_drm_dsi.c:1705:2: error: implicit declaration of function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); ^ drivers/gpu/drm/exynos/exynos_drm_dsi.c:1705:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. -- >> drivers/gpu/drm/exynos/exynos_hdmi.c:1851:2: error: implicit declaration of function 'drm_simple_encoder_init' [-Werror,-Wimplicit-function-declaration] drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); ^ drivers/gpu/drm/exynos/exynos_hdmi.c:1851:2: note: did you mean 'drm_encoder_init'? include/drm/drm_encoder.h:189:5: note: 'drm_encoder_init' declared here int drm_encoder_init(struct drm_device *dev, ^ 1 error generated. vim +/drm_simple_encoder_init +1705 drivers/gpu/drm/exynos/exynos_drm_dsi.c 1695 1696 static int exynos_dsi_bind(struct device *dev, struct device *master, 1697 void *data) 1698 { 1699 struct drm_encoder *encoder = dev_get_drvdata(dev); 1700 struct exynos_dsi *dsi = encoder_to_dsi(encoder); 1701 struct drm_device *drm_dev = data; 1702 struct drm_bridge *in_bridge; 1703 int ret; 1704 > 1705 drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); 1706 1707 drm_encoder_helper_add(encoder, &exynos_dsi_encoder_helper_funcs); 1708 1709 ret = exynos_drm_set_possible_crtcs(encoder, EXYNOS_DISPLAY_TYPE_LCD); 1710 if (ret < 0) 1711 return ret; 1712 1713 if (dsi->in_bridge_node) { 1714 in_bridge = of_drm_find_bridge(dsi->in_bridge_node); 1715 if (in_bridge) 1716 drm_bridge_attach(encoder, in_bridge, NULL, 0); 1717 } 1718 1719 return mipi_dsi_host_register(&dsi->dsi_host); 1720 } 1721 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org