All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs_parse: Remove pr_notice() about each validation
@ 2020-03-07  0:20 Kees Cook
  2020-03-11 17:20 ` Kees Cook
  2020-03-11 18:03 ` Seth Arnold
  0 siblings, 2 replies; 3+ messages in thread
From: Kees Cook @ 2020-03-07  0:20 UTC (permalink / raw)
  To: Alexander Viro; +Cc: Andrew Morton, linux-fsdevel, linux-kernel

This notice fills my boot logs with scary-looking asterisks but doesn't
really tell me anything. Let's just remove it; validation errors
are already reported separately, so this is just a redundant list of
filesystems.

$ dmesg | grep VALIDATE
[    0.306256] *** VALIDATE tmpfs ***
[    0.307422] *** VALIDATE proc ***
[    0.308355] *** VALIDATE cgroup ***
[    0.308741] *** VALIDATE cgroup2 ***
[    0.813256] *** VALIDATE bpf ***
[    0.815272] *** VALIDATE ramfs ***
[    0.815665] *** VALIDATE hugetlbfs ***
[    0.876970] *** VALIDATE nfs ***
[    0.877383] *** VALIDATE nfs4 ***

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 fs/fs_parser.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/fs_parser.c b/fs/fs_parser.c
index 7e6fb43f9541..ab53e42a874a 100644
--- a/fs/fs_parser.c
+++ b/fs/fs_parser.c
@@ -368,8 +368,6 @@ bool fs_validate_description(const char *name,
 	const struct fs_parameter_spec *param, *p2;
 	bool good = true;
 
-	pr_notice("*** VALIDATE %s ***\n", name);
-
 	for (param = desc; param->name; param++) {
 		/* Check for duplicate parameter names */
 		for (p2 = desc; p2 < param; p2++) {
-- 
2.20.1


-- 
Kees Cook

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fs_parse: Remove pr_notice() about each validation
  2020-03-07  0:20 [PATCH] fs_parse: Remove pr_notice() about each validation Kees Cook
@ 2020-03-11 17:20 ` Kees Cook
  2020-03-11 18:03 ` Seth Arnold
  1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2020-03-11 17:20 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Alexander Viro, linux-fsdevel, linux-kernel

Hi Andrew,

Can you pick this up in -mm?

Thanks!

-Kees

On Fri, Mar 06, 2020 at 04:20:02PM -0800, Kees Cook wrote:
> This notice fills my boot logs with scary-looking asterisks but doesn't
> really tell me anything. Let's just remove it; validation errors
> are already reported separately, so this is just a redundant list of
> filesystems.
> 
> $ dmesg | grep VALIDATE
> [    0.306256] *** VALIDATE tmpfs ***
> [    0.307422] *** VALIDATE proc ***
> [    0.308355] *** VALIDATE cgroup ***
> [    0.308741] *** VALIDATE cgroup2 ***
> [    0.813256] *** VALIDATE bpf ***
> [    0.815272] *** VALIDATE ramfs ***
> [    0.815665] *** VALIDATE hugetlbfs ***
> [    0.876970] *** VALIDATE nfs ***
> [    0.877383] *** VALIDATE nfs4 ***
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  fs/fs_parser.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/fs_parser.c b/fs/fs_parser.c
> index 7e6fb43f9541..ab53e42a874a 100644
> --- a/fs/fs_parser.c
> +++ b/fs/fs_parser.c
> @@ -368,8 +368,6 @@ bool fs_validate_description(const char *name,
>  	const struct fs_parameter_spec *param, *p2;
>  	bool good = true;
>  
> -	pr_notice("*** VALIDATE %s ***\n", name);
> -
>  	for (param = desc; param->name; param++) {
>  		/* Check for duplicate parameter names */
>  		for (p2 = desc; p2 < param; p2++) {
> -- 
> 2.20.1
> 
> 
> -- 
> Kees Cook

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fs_parse: Remove pr_notice() about each validation
  2020-03-07  0:20 [PATCH] fs_parse: Remove pr_notice() about each validation Kees Cook
  2020-03-11 17:20 ` Kees Cook
@ 2020-03-11 18:03 ` Seth Arnold
  1 sibling, 0 replies; 3+ messages in thread
From: Seth Arnold @ 2020-03-11 18:03 UTC (permalink / raw)
  To: Kees Cook; +Cc: Alexander Viro, Andrew Morton, linux-fsdevel, linux-kernel

On Fri, Mar 06, 2020 at 04:20:02PM -0800, Kees Cook wrote:
> This notice fills my boot logs with scary-looking asterisks but doesn't
> really tell me anything. Let's just remove it; validation errors
> are already reported separately, so this is just a redundant list of
> filesystems.
> 
> $ dmesg | grep VALIDATE
> [    0.306256] *** VALIDATE tmpfs ***
> [    0.307422] *** VALIDATE proc ***
> [    0.308355] *** VALIDATE cgroup ***
> [    0.308741] *** VALIDATE cgroup2 ***
> [    0.813256] *** VALIDATE bpf ***
> [    0.815272] *** VALIDATE ramfs ***
> [    0.815665] *** VALIDATE hugetlbfs ***
> [    0.876970] *** VALIDATE nfs ***
> [    0.877383] *** VALIDATE nfs4 ***
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>

Excellent, these messages haven't been useful in helping users diagnose
problems and they look quite noisy considering how mundane they are.

Reviewed-by: Seth Arnold <seth.arnold@canonical.com>

Thanks

> ---
>  fs/fs_parser.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/fs_parser.c b/fs/fs_parser.c
> index 7e6fb43f9541..ab53e42a874a 100644
> --- a/fs/fs_parser.c
> +++ b/fs/fs_parser.c
> @@ -368,8 +368,6 @@ bool fs_validate_description(const char *name,
>  	const struct fs_parameter_spec *param, *p2;
>  	bool good = true;
>  
> -	pr_notice("*** VALIDATE %s ***\n", name);
> -
>  	for (param = desc; param->name; param++) {
>  		/* Check for duplicate parameter names */
>  		for (p2 = desc; p2 < param; p2++) {
> -- 
> 2.20.1
> 
> 
> -- 
> Kees Cook

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-11 18:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-07  0:20 [PATCH] fs_parse: Remove pr_notice() about each validation Kees Cook
2020-03-11 17:20 ` Kees Cook
2020-03-11 18:03 ` Seth Arnold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.