From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47022C10DCE for ; Fri, 6 Mar 2020 18:39:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 218BE20637 for ; Fri, 6 Mar 2020 18:39:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 218BE20637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 495F06E4DD; Fri, 6 Mar 2020 18:39:40 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E8AB6E4DD; Fri, 6 Mar 2020 18:39:38 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2020 10:39:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,523,1574150400"; d="scan'208";a="241246419" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.165.21.211]) by orsmga003.jf.intel.com with ESMTP; 06 Mar 2020 10:39:37 -0800 Date: Fri, 6 Mar 2020 10:40:48 -0800 From: Manasi Navare To: Jani Nikula Subject: Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags Message-ID: <20200306184048.GA25133@intel.com> References: <20200306014220.20029-1-manasi.d.navare@intel.com> <87mu8tojvt.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87mu8tojvt.fsf@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Kazlauskas Nicholas , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote: > On Thu, 05 Mar 2020, Manasi Navare wrote: > > This patch adds defines for the detailed monitor > > range flags as per the EDID specification. > > > > Suggested-by: Ville Syrj=E4l=E4 > > Cc: Ville Syrj=E4l=E4 > > Cc: Harry Wentland > > Cc: Clinton A Taylor > > Cc: Kazlauskas Nicholas > > Signed-off-by: Manasi Navare > > --- > > include/drm/drm_edid.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > > index f0b03d401c27..f89c97623845 100644 > > --- a/include/drm/drm_edid.h > > +++ b/include/drm/drm_edid.h > > @@ -91,6 +91,11 @@ struct detailed_data_string { > > u8 str[13]; > > } __attribute__((packed)); > > = > > +#define EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 > > +#define EDID_RANGE_LIMITS_ONLY_FLAG 0x01 > > +#define EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 > > +#define EDID_CVT_SUPPORT_FLAG 0x04 > = > Bikeshed for consideration: > = > drm_edid.h has some macros with DRM_EDID_ prefix, some with EDID_ > prefix, and then some with no prefix at all really. Should we start > consolidating on something when we add more? > Yes Jani I did notice the same thing and didnt know which convention to continue to follow but I noticed that majority of the defines were just EDID_ so just used that for these new defines. Is there a particular way you wish to consolidate this and use a specific convention for #defines? I can atleast change these new defines based on a preferred convention and = then separate patches to change the rest in .h and corresponding usages in .c fi= les. Regards Manasi = > BR, > Jani. > = > = > > + > > struct detailed_data_monitor_range { > > u8 min_vfreq; > > u8 max_vfreq; > = > -- = > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 710BAC10DCE for ; Fri, 6 Mar 2020 18:39:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50A6B20637 for ; Fri, 6 Mar 2020 18:39:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50A6B20637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 99F686EC18; Fri, 6 Mar 2020 18:39:40 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E8AB6E4DD; Fri, 6 Mar 2020 18:39:38 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2020 10:39:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,523,1574150400"; d="scan'208";a="241246419" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.165.21.211]) by orsmga003.jf.intel.com with ESMTP; 06 Mar 2020 10:39:37 -0800 Date: Fri, 6 Mar 2020 10:40:48 -0800 From: Manasi Navare To: Jani Nikula Message-ID: <20200306184048.GA25133@intel.com> References: <20200306014220.20029-1-manasi.d.navare@intel.com> <87mu8tojvt.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87mu8tojvt.fsf@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Harry Wentland , Kazlauskas Nicholas , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote: > On Thu, 05 Mar 2020, Manasi Navare wrote: > > This patch adds defines for the detailed monitor > > range flags as per the EDID specification. > > > > Suggested-by: Ville Syrj=E4l=E4 > > Cc: Ville Syrj=E4l=E4 > > Cc: Harry Wentland > > Cc: Clinton A Taylor > > Cc: Kazlauskas Nicholas > > Signed-off-by: Manasi Navare > > --- > > include/drm/drm_edid.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > > index f0b03d401c27..f89c97623845 100644 > > --- a/include/drm/drm_edid.h > > +++ b/include/drm/drm_edid.h > > @@ -91,6 +91,11 @@ struct detailed_data_string { > > u8 str[13]; > > } __attribute__((packed)); > > = > > +#define EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 > > +#define EDID_RANGE_LIMITS_ONLY_FLAG 0x01 > > +#define EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 > > +#define EDID_CVT_SUPPORT_FLAG 0x04 > = > Bikeshed for consideration: > = > drm_edid.h has some macros with DRM_EDID_ prefix, some with EDID_ > prefix, and then some with no prefix at all really. Should we start > consolidating on something when we add more? > Yes Jani I did notice the same thing and didnt know which convention to continue to follow but I noticed that majority of the defines were just EDID_ so just used that for these new defines. Is there a particular way you wish to consolidate this and use a specific convention for #defines? I can atleast change these new defines based on a preferred convention and = then separate patches to change the rest in .h and corresponding usages in .c fi= les. Regards Manasi = > BR, > Jani. > = > = > > + > > struct detailed_data_monitor_range { > > u8 min_vfreq; > > u8 max_vfreq; > = > -- = > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx