From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1513CC10F00 for ; Sat, 7 Mar 2020 09:39:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDB9C2070A for ; Sat, 7 Mar 2020 09:39:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Z6Qq6/1B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726193AbgCGJjZ (ORCPT ); Sat, 7 Mar 2020 04:39:25 -0500 Received: from mail-pf1-f175.google.com ([209.85.210.175]:44124 "EHLO mail-pf1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725909AbgCGJjZ (ORCPT ); Sat, 7 Mar 2020 04:39:25 -0500 Received: by mail-pf1-f175.google.com with SMTP id y26so2352533pfn.11 for ; Sat, 07 Mar 2020 01:39:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7a3AAdOd9aTW9nDmpj4pfI4b0wQoKltwVVKhvV6YEWo=; b=Z6Qq6/1BqFIylyqfS6Pv05Y6BNWVpCBFW7z4NRcvmpUbx0CCBnp383iDE0xtThbgF0 CvlCohuP6bRjR/9CaLi7X6m7p+Jg1DeaBU4v/ZyAPTkswwjFbMxm9jQgiH78PNSTFbqC sOBuUr21Ll7e8Ep/vSwax0azbtJntHQOFwbMY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7a3AAdOd9aTW9nDmpj4pfI4b0wQoKltwVVKhvV6YEWo=; b=O2asKjFywyAbHTPKfg7P5YHmP2NyJfCx9GiR+9xPumngzJu240W2HXxt4RjcXRjsoH cnA53zdPAu3vf0y2pfEAc3kI0jAQaDtgWXutf3jDHkbm4vxkv4HkM2rB9I9fG5iV102t 6pwieHiOHLyaONipZuHYg/qyxTu2O8s5rQ6DTOkkmj4S6wza2dslBQ4MCcBxnuOZH14M 2BOPO9dxR6KGK4dpAuZfi55M5YHuo8XlvY/8ucV1hufqJcChUSzYuALgsm/Gph3PdJmd aQe9PAA0lkAI9DdleaAlXLs1Z8+eI8wlSR5TPJrjgKpw7fYr5PDWZnf6uMlQX2H9QQRy 8pqw== X-Gm-Message-State: ANhLgQ2lbKrMArAfTdx65gzawGHVOa79ZDRFAGAFiTzaFiQq0SGgW0VE ieA2QvsN9YYlbuct+IhYnZe3yw== X-Google-Smtp-Source: ADFU+vvn+Juchn8PjjSyhg0i99Mf32mKkqJVst/dcmMctSpXzE9UH+SIP0x31txil9XG5a1Hj4flwg== X-Received: by 2002:a63:1e44:: with SMTP id p4mr7242868pgm.367.1583573964284; Sat, 07 Mar 2020 01:39:24 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:5bbb:c872:f2b1:f53b]) by smtp.gmail.com with ESMTPSA id x197sm23115196pfd.74.2020.03.07.01.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2020 01:39:23 -0800 (PST) Date: Sat, 7 Mar 2020 18:39:22 +0900 From: Sergey Senozhatsky To: Hans Verkuil Cc: Sergey Senozhatsky , Hans Verkuil , Tomasz Figa , Mauro Carvalho Chehab , Kyungmin Park , Marek Szyprowski , Sakari Ailus , Laurent Pinchart , Pawel Osciak , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 10/11] videobuf2: add begin/end cpu_access callbacks to dma-sg Message-ID: <20200307093922.GA29464@google.com> References: <20200302041213.27662-1-senozhatsky@chromium.org> <20200302041213.27662-11-senozhatsky@chromium.org> <20200307052628.GB176460@google.com> <8150bc6c-f6a4-fa2c-4e2e-552dcb168df0@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8150bc6c-f6a4-fa2c-4e2e-552dcb168df0@xs4all.nl> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (20/03/07 10:32), Hans Verkuil wrote: > >>> +static int vb2_dma_sg_dmabuf_ops_begin_cpu_access(struct dma_buf *dbuf, > >>> + enum dma_data_direction direction) > >> > >> I suggest you use this style to avoid checkpatch warnings: > >> > >> static int > >> vb2_dma_sg_dmabuf_ops_begin_cpu_access(struct dma_buf *dbuf, > >> enum dma_data_direction direction) > > > > OK, will do. > > > > Just for information, my checkpatch doesn't warn me: > > > > $ ./scripts/checkpatch.pl outgoing/0010-videobuf2-add-begin-end-cpu_access-callbacks-to-dma-.patch > > We use the --strict option to checkpatch. Got it. -ss