All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] slub: Improve bit diffusion for freelist ptr obfuscation
Date: Mon, 9 Mar 2020 09:41:19 -0700	[thread overview]
Message-ID: <202003090941.1F1FEE75@keescook> (raw)
In-Reply-To: <20200309005112.GU21491@sasha-vm>

On Sun, Mar 08, 2020 at 08:51:12PM -0400, Sasha Levin wrote:
> On Sun, Mar 08, 2020 at 02:51:27PM -0700, Kees Cook wrote:
> > On Sat, Mar 07, 2020 at 11:20:37PM +0000, Sasha Levin wrote:
> > > Hi
> > > 
> > > [This is an automated email]
> > > 
> > > This commit has been processed because it contains a "Fixes:" tag
> > > fixing commit: 2482ddec670f ("mm: add SLUB free list pointer obfuscation").
> > > 
> > > The bot has tested the following trees: v5.5.8, v5.4.24, v4.19.108, v4.14.172.
> > > 
> > > v5.5.8: Build failed! Errors:
> > >     mm/slub.c:262:4: error: implicit declaration of function ‘swab’; did you mean ‘swap’? [-Werror=implicit-function-declaration]
> > > 
> > 
> > Eek; this must be missing an include that is implicit from something
> > recent? I will investigate...
> 
> swab() didn't exist "back then" :) It was introduced by d5767057c9a7
> ("uapi: rename ext2_swab() to swab() and share globally in swab.h"). I
> can just take that patch to stable kernels.

Ah, perfect. Yes, that would be very nice.

-- 
Kees Cook

      reply	other threads:[~2020-03-09 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06  0:24 [PATCH] slub: Improve bit diffusion for freelist ptr obfuscation Kees Cook
2020-03-07 23:20 ` Sasha Levin
2020-03-08 21:51   ` Kees Cook
2020-03-09  0:51     ` Sasha Levin
2020-03-09 16:41       ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202003090941.1F1FEE75@keescook \
    --to=keescook@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=penberg@kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.