From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7604DC10F27 for ; Mon, 9 Mar 2020 13:00:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44E0B20675 for ; Mon, 9 Mar 2020 13:00:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44E0B20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5EEC6E438; Mon, 9 Mar 2020 13:00:40 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6329089F07 for ; Mon, 9 Mar 2020 13:00:39 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2020 06:00:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,533,1574150400"; d="scan'208";a="245336534" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 09 Mar 2020 06:00:35 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 09 Mar 2020 15:00:35 +0200 Date: Mon, 9 Mar 2020 15:00:35 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "H. Nikolaus Schaller" Subject: Re: [PATCH 24/33] drm/panel-simple: Fix dotclock for Ortustech COM37H3M Message-ID: <20200309130035.GV13686@intel.com> References: <20200302203452.17977-1-ville.syrjala@linux.intel.com> <20200302203452.17977-25-ville.syrjala@linux.intel.com> <4320E187-FAA1-4033-A02C-7DA1F9B68A52@goldelico.com> <20200303150336.GZ13686@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Discussions about the Letux Kernel , Sam Ravnborg , "open list:DRM PANEL DRIVERS" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Mar 05, 2020 at 08:41:43PM +0100, H. Nikolaus Schaller wrote: > = > > Am 03.03.2020 um 16:49 schrieb H. Nikolaus Schaller : > > = > > Hi, > > = > >> Am 03.03.2020 um 16:03 schrieb Ville Syrj=E4l=E4 : > >> = > >>> I haven't looked into the driver code, but would it be > >>> possible to specify .clock =3D 0 (or leave it out) to > >>> calculate it bottom up? This would avoid such inconsistencies. > >> = > >> I'm going to remove .vrefresh entirely from the struct. > >> It'll just be calculated from the other timings as needed. > > = > > Ok! > > = > > Anyways we should fix the panel timings so that it is compatible to .vr= efresh =3D 60. > > = > > I'll give it a try and let you know. > = > Ok, here is a new parameter set within data sheet limits for both > panel variants: > = > static const struct drm_display_mode ortustech_com37h3m_mode =3D { > .clock =3D 22153, > .hdisplay =3D 480, > .hsync_start =3D 480 + 40, > .hsync_end =3D 480 + 40 + 10, > .htotal =3D 480 + 40 + 10 + 40, > .vdisplay =3D 640, > .vsync_start =3D 640 + 4, > .vsync_end =3D 640 + 4 + 2, > .vtotal =3D 640 + 4 + 2 + 4, > .vrefresh =3D 60, > .flags =3D DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, > }; > = > I have tested on our omap3 based board and didn't find an issue > so you can insert into your patch. Migth be better if you send that so we get proper attribution and you can explain the change properly in the commit message. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel