From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B55C10F27 for ; Mon, 9 Mar 2020 17:14:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FC89208C3 for ; Mon, 9 Mar 2020 17:14:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="sydw3DNL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727273AbgCIROS (ORCPT ); Mon, 9 Mar 2020 13:14:18 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53550 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727198AbgCIROR (ORCPT ); Mon, 9 Mar 2020 13:14:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CwSFcsr7HUwB0+SG3NfecvwPFIxrrFqaamNRSJhEx7Q=; b=sydw3DNLseHbaZT/EsNigrcvx9 hJse2Wrqva+aolZTXuD6GT9QtHYisXijO/wFsYPx2Fwfx6oNBZlLUAXssNKGoFZgaC5T8NBPR4AC5 Mrg/1cn64UqH44ksvAgLBfr9G/QDvla9+rkstXKwmei2NRQ4TY2OY3Tbx2ZXc7Cl2cxQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jBLyn-0003l2-Jn; Mon, 09 Mar 2020 18:14:13 +0100 Date: Mon, 9 Mar 2020 18:14:13 +0100 From: Andrew Lunn To: Oleksij Rempel Cc: Florian Fainelli , Heiner Kallweit , Pengutronix Kernel Team , linux-kernel@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, Marek Vasut , David Jander Subject: Re: [PATCH v2 1/2] net: phy: tja11xx: add TJA1102 support Message-ID: <20200309171413.GA14181@lunn.ch> References: <20200309074044.21399-1-o.rempel@pengutronix.de> <20200309074044.21399-2-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309074044.21399-2-o.rempel@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2020 at 08:40:43AM +0100, Oleksij Rempel wrote: > TJA1102 is an dual T1 PHY chip. Both PHYs are separately addressable. > PHY 0 can be identified by PHY ID. PHY 1 has no PHY ID and can be > configured in device tree by setting compatible = "ethernet-phy-id0180.dc81". Hi Oleksij Given what the second patch does, there is no need to set the compatible. So please reword this. Andrew