From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A45C10F29 for ; Mon, 9 Mar 2020 18:19:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44B7A21927 for ; Mon, 9 Mar 2020 18:19:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sNlPIoM2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727624AbgCISTb (ORCPT ); Mon, 9 Mar 2020 14:19:31 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:33991 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727604AbgCIST2 (ORCPT ); Mon, 9 Mar 2020 14:19:28 -0400 Received: by mail-pg1-f196.google.com with SMTP id t3so5093953pgn.1; Mon, 09 Mar 2020 11:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZUgRxVNWWI4/X6MpRA1miIl6BKxEX3f9Er1YPxkTvvw=; b=sNlPIoM2gt3GGdSuObomrqoffsAtxhxZft2ETl+N3lZ3JSsCVtomAdJeaNPkTfheFa dzxMu8ssE23gZE1OxWJNZ+9Hf25JLpasSBaBdGGq+lY4kZHw/HCniVudCE2Aaozjad7L A8AQC+hDjh+vOvWgARydrt917tpg7seq13OcylBlfc0LT86PMepy+F+tkYc9mzbybEOn S/jxBlUMHRG5Lu//z3iUZDoUrnAQtczHnWp8BBBzHs/avjK67sKc/0ROBmcZUg4IzzUx 2O0ctvHZor8KZ5oNC0Uxta9UOSkSJaY7BP1zdgX3G/b5qyfWyeLiYL9t5K4YNuB60gSk vKtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ZUgRxVNWWI4/X6MpRA1miIl6BKxEX3f9Er1YPxkTvvw=; b=sbSThMvcRuPzgi5//HM3Y1XVqmAMxwttBRIUMTHkbgQNHEZ2yd9BXBsy0LIcSr5tPZ w8/ln1HgYB5saCmtGge7Qfevf1f6g5QsisgWgifUsnP1MYq6M0x1nj4M6Dc3nvwIGW+o 0v6K9+aHQUPjFo9iEULC93mG8lZm1TOsrNakOcvGswN5uWMm++KLCqlBTTg5SoYzxXbx KHmZ+L0aMUS/5q+2F69cdDGJ9RlUdayhUPra99wFGlscNw+3mLJ5965z/NYqxCxfiZuk +xG1u9Z+dxaQ1xWlJvj/jGc2zIa2qL2pOsCnCCjQxcEnt+FkQ/UScwRYy7hulZwnzkve riOw== X-Gm-Message-State: ANhLgQ3WzHe1AF+iE2Gx53KOHRe+Du2E+6wRUpt5bQfErSPncHi4f8Yi RlZDGr0MBwaHUYkDXrZBlS0= X-Google-Smtp-Source: ADFU+vuOgWAHVSJ7870Wsdc6jp9jt1VM/hwbVvbgrPsGlhP3zO4qktaIEgcY6kj2q1SiRmCkNaL7zA== X-Received: by 2002:a63:6841:: with SMTP id d62mr16700934pgc.86.1583777967062; Mon, 09 Mar 2020 11:19:27 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id c190sm1023630pga.35.2020.03.09.11.19.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Mar 2020 11:19:25 -0700 (PDT) Date: Mon, 9 Mar 2020 11:19:24 -0700 From: Guenter Roeck To: Alexandre Belloni Cc: Anson Huang , shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, dmitry.torokhov@gmail.com, a.zummo@towertech.it, rui.zhang@intel.com, daniel.lezcano@linaro.org, amit.kucheria@verdurent.com, wim@linux-watchdog.org, daniel.baluta@nxp.com, gregkh@linuxfoundation.org, linux@rempel-privat.de, tglx@linutronix.de, m.felsch@pengutronix.de, andriy.shevchenko@linux.intel.com, arnd@arndb.de, ronald@innovation.ch, krzk@kernel.org, robh@kernel.org, leonard.crestez@nxp.com, aisheng.dong@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org, linux-watchdog@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Message-ID: <20200309181924.GA27218@roeck-us.net> References: <1583714300-19085-1-git-send-email-Anson.Huang@nxp.com> <20200309110609.GE3563@piout.net> <1ad38cdb-bf0d-1c19-b233-15a5857bd6fa@roeck-us.net> <20200309164705.GG3563@piout.net> <20200309171012.GA24802@roeck-us.net> <20200309171556.GH3563@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309171556.GH3563@piout.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2020 at 06:30:54PM +0100, Alexandre Belloni wrote: > On 09/03/2020 10:10:12-0700, Guenter Roeck wrote: > > On Mon, Mar 09, 2020 at 05:47:05PM +0100, Alexandre Belloni wrote: > > > On 09/03/2020 06:27:06-0700, Guenter Roeck wrote: > > > > On 3/9/20 4:06 AM, Alexandre Belloni wrote: > > > > > On 09/03/2020 08:38:14+0800, Anson Huang wrote: > > > > >> Add stubs for those i.MX SCU APIs to make those modules depending > > > > >> on IMX_SCU can pass build when COMPILE_TEST is enabled. > > > > >> > > > > >> Signed-off-by: Anson Huang > > > > >> --- > > > > >> Changes since V2: > > > > >> - return error for stubs. > > > > > > > > > > I'm not sure why you are sending v3 with the stubs as we determined that > > > > > 2/7 is enough to compile all the drivers with COMPILE_TEST. > > > > > > > > > > > > > > 2/7 alone is not sufficient. With only 2/7, one can explicitly configure > > > > IMX_SCU=n, COMPILE_TEST=y, and get lots of compile failures. Granted, > > > > one should not do that, but 0day does (I don't know if that is the result > > > > of RANDCONFIG), and I am not looking forward having to deal with the > > > > fallout. > > > > > > > > > > How would that be possible if the drivers all depend on IMX_SCU? > > > > > That dependency is being changed to IMX_SCU || COMPILE_TEST > > as part of the series. > > > > Yes, my point is that those patches should not be applied at all, only > 2/7. Ah, now I get it. Sorry, I missed that part. You are correct, that would be sufficient, and I would very much prefer that approach. Thanks, Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC147C10F29 for ; Mon, 9 Mar 2020 18:23:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7379D24655 for ; Mon, 9 Mar 2020 18:23:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mVkXdKAW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sNlPIoM2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7379D24655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aYhHp71bAtEoEzGsymRfeQKtTyLZy3sgumYJLYjeSvo=; b=mVkXdKAWoJljQ0 iIGmL/DtpxFs0OOeEsbX7hE2MiL3Vc532QjGOrHB5Cx21NX0SgJSXmZ+KvXAxOdzbn8WTwxtfMhM6 uFyr2y6ubpeZTNm5vL6YRl+DKaUycUvlAfQXKBbgeucSMWsheGwke5fWPY8UlfDbtUCxZQ9O9UJgM 9g7XGYEOk0KELrg0Qj2PNvTPpqzb+2Yoh/AhNbtXfXyLQMsqW8et3lQuM1Xe2FUwRum4IAGFIy1Ib 8GUQgflrBKCW14mrQqcvu7D6eB5hHnl1jAtAlkQC9Intp2FcBTbFGQuMTooyNR1XrbISiNZiaL6Ro p/nKteY/2qG/z8tkrTfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBN3s-0006vA-Be; Mon, 09 Mar 2020 18:23:32 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBMzw-00024Z-Gu for linux-arm-kernel@lists.infradead.org; Mon, 09 Mar 2020 18:19:30 +0000 Received: by mail-pf1-x443.google.com with SMTP id 2so5175441pfg.12 for ; Mon, 09 Mar 2020 11:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZUgRxVNWWI4/X6MpRA1miIl6BKxEX3f9Er1YPxkTvvw=; b=sNlPIoM2gt3GGdSuObomrqoffsAtxhxZft2ETl+N3lZ3JSsCVtomAdJeaNPkTfheFa dzxMu8ssE23gZE1OxWJNZ+9Hf25JLpasSBaBdGGq+lY4kZHw/HCniVudCE2Aaozjad7L A8AQC+hDjh+vOvWgARydrt917tpg7seq13OcylBlfc0LT86PMepy+F+tkYc9mzbybEOn S/jxBlUMHRG5Lu//z3iUZDoUrnAQtczHnWp8BBBzHs/avjK67sKc/0ROBmcZUg4IzzUx 2O0ctvHZor8KZ5oNC0Uxta9UOSkSJaY7BP1zdgX3G/b5qyfWyeLiYL9t5K4YNuB60gSk vKtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ZUgRxVNWWI4/X6MpRA1miIl6BKxEX3f9Er1YPxkTvvw=; b=EFBRfNJ0N9GrznYXiASPXNIT4EaiPGvQ/jvYhP/5/Hio04R8SHiBNi9Bv/3pNseKMY dTyeGSh+BEPCTbiKux0I8K8wTYFMkNM74300Boj43zTwJkLtJ+cZXsq4CqHNAQvAs+mk hTuksK11DBS2frZMVMNhEeJTVNnhyCziyrajc8WmiN+Nzj5mlDbO4iYIZq9p7V0GKHik I8s1SrNidwH+YphthjhWy0XcJGK1GbFQUVGE3dbXDvRgvAm2dCNFpZZp2Tf50+KuCNPB ICDdKwrZt49EhqV7azMML0I+j4wJ5BhCQ2c6Y61QO8XO26E0M4/qXn5woPwGKQduLPKy 0lEw== X-Gm-Message-State: ANhLgQ2qxUzQWUO9YYzUW2CQxxLEYQolG5uU6/1T2yFXIgosMdZtbR61 2Zlj53qLgE0uRbhcElTwqJ/syz9Q X-Google-Smtp-Source: ADFU+vuOgWAHVSJ7870Wsdc6jp9jt1VM/hwbVvbgrPsGlhP3zO4qktaIEgcY6kj2q1SiRmCkNaL7zA== X-Received: by 2002:a63:6841:: with SMTP id d62mr16700934pgc.86.1583777967062; Mon, 09 Mar 2020 11:19:27 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id c190sm1023630pga.35.2020.03.09.11.19.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Mar 2020 11:19:25 -0700 (PDT) Date: Mon, 9 Mar 2020 11:19:24 -0700 From: Guenter Roeck To: Alexandre Belloni Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Message-ID: <20200309181924.GA27218@roeck-us.net> References: <1583714300-19085-1-git-send-email-Anson.Huang@nxp.com> <20200309110609.GE3563@piout.net> <1ad38cdb-bf0d-1c19-b233-15a5857bd6fa@roeck-us.net> <20200309164705.GG3563@piout.net> <20200309171012.GA24802@roeck-us.net> <20200309171556.GH3563@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200309171556.GH3563@piout.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200309_111928_579647_CB57A7D4 X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: m.felsch@pengutronix.de, leonard.crestez@nxp.com, festevam@gmail.com, linux-rtc@vger.kernel.org, robh@kernel.org, amit.kucheria@verdurent.com, wim@linux-watchdog.org, Anson Huang , daniel.lezcano@linaro.org, krzk@kernel.org, Linux-imx@nxp.com, linux-input@vger.kernel.org, rui.zhang@intel.com, ronald@innovation.ch, linux-watchdog@vger.kernel.org, arnd@arndb.de, linux-pm@vger.kernel.org, s.hauer@pengutronix.de, tglx@linutronix.de, andriy.shevchenko@linux.intel.com, daniel.baluta@nxp.com, linux-arm-kernel@lists.infradead.org, aisheng.dong@nxp.com, a.zummo@towertech.it, gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, linux@rempel-privat.de, kernel@pengutronix.de, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 09, 2020 at 06:30:54PM +0100, Alexandre Belloni wrote: > On 09/03/2020 10:10:12-0700, Guenter Roeck wrote: > > On Mon, Mar 09, 2020 at 05:47:05PM +0100, Alexandre Belloni wrote: > > > On 09/03/2020 06:27:06-0700, Guenter Roeck wrote: > > > > On 3/9/20 4:06 AM, Alexandre Belloni wrote: > > > > > On 09/03/2020 08:38:14+0800, Anson Huang wrote: > > > > >> Add stubs for those i.MX SCU APIs to make those modules depending > > > > >> on IMX_SCU can pass build when COMPILE_TEST is enabled. > > > > >> > > > > >> Signed-off-by: Anson Huang > > > > >> --- > > > > >> Changes since V2: > > > > >> - return error for stubs. > > > > > > > > > > I'm not sure why you are sending v3 with the stubs as we determined that > > > > > 2/7 is enough to compile all the drivers with COMPILE_TEST. > > > > > > > > > > > > > > 2/7 alone is not sufficient. With only 2/7, one can explicitly configure > > > > IMX_SCU=n, COMPILE_TEST=y, and get lots of compile failures. Granted, > > > > one should not do that, but 0day does (I don't know if that is the result > > > > of RANDCONFIG), and I am not looking forward having to deal with the > > > > fallout. > > > > > > > > > > How would that be possible if the drivers all depend on IMX_SCU? > > > > > That dependency is being changed to IMX_SCU || COMPILE_TEST > > as part of the series. > > > > Yes, my point is that those patches should not be applied at all, only > 2/7. Ah, now I get it. Sorry, I missed that part. You are correct, that would be sufficient, and I would very much prefer that approach. Thanks, Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel