From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Robert Walker <robert.walker@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Coresight ML <coresight@lists.linaro.org>
Subject: Re: [PATCH v5 0/5] perf cs-etm: Fix synthesizing instruction samples
Date: Tue, 10 Mar 2020 08:45:03 -0300 [thread overview]
Message-ID: <20200310114503.GA25299@kernel.org> (raw)
In-Reply-To: <20200310054305.GA21545@leoy-ThinkPad-X240s>
Em Tue, Mar 10, 2020 at 01:43:05PM +0800, Leo Yan escreveu:
> Hi Arnaldo,
>
> On Wed, Feb 19, 2020 at 10:18:06AM +0800, Leo Yan wrote:
> > This patch series is to address issues for synthesizing instruction
> > samples, especially when the instruction sample period is small enough,
> > the current logic cannot synthesize multiple instruction samples within
> > one instruction range packet.
> >
> > Patch 0001 is to swap packets for instruction samples, so this allow
> > option '--itrace=iNNN' can work well.
> >
> > Patch 0002 avoids to reset the last branches for every instruction
> > sample; if reset the last branches for every time generating sample, the
> > later samples in the same range packet cannot use the last branches
> > anymore.
> >
> > Patch 0003 is the fixing for handling different instruction periods,
> > especially for small sample period.
> >
> > Patch 0004 is an optimization for copying last branches; it only copies
> > last branches once if the instruction samples share the same last
> > branches.
> >
> > Patch 0005 is a minor fix for unsigned variable comparison to zero.
> >
> > This patch set has been rebased on the latest perf/core branch; and
> > verified on Juno board with below commands:
> >
> > # perf script --itrace=i2
> > # perf script --itrace=i2il16
> > # perf inject --itrace=i2il16 -i perf.data -o perf.data.new
> > # perf inject --itrace=i100il16 -i perf.data -o perf.data.new
>
> Could you pick up this patch set? I confirmed this patch set can
> cleanly apply on top of the latest mainline kernel (5.6-rc5).
>
> Or if you want me to resend this patch set, please feel free let me
> know. Thanks!
Thanks, all build tested on x86 and arm64 (with CORESIGHT=1, etc), applied.
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Coresight ML <coresight@lists.linaro.org>,
linux-kernel@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Robert Walker <robert.walker@arm.com>,
Jiri Olsa <jolsa@redhat.com>,
linux-arm-kernel@lists.infradead.org,
Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH v5 0/5] perf cs-etm: Fix synthesizing instruction samples
Date: Tue, 10 Mar 2020 08:45:03 -0300 [thread overview]
Message-ID: <20200310114503.GA25299@kernel.org> (raw)
In-Reply-To: <20200310054305.GA21545@leoy-ThinkPad-X240s>
Em Tue, Mar 10, 2020 at 01:43:05PM +0800, Leo Yan escreveu:
> Hi Arnaldo,
>
> On Wed, Feb 19, 2020 at 10:18:06AM +0800, Leo Yan wrote:
> > This patch series is to address issues for synthesizing instruction
> > samples, especially when the instruction sample period is small enough,
> > the current logic cannot synthesize multiple instruction samples within
> > one instruction range packet.
> >
> > Patch 0001 is to swap packets for instruction samples, so this allow
> > option '--itrace=iNNN' can work well.
> >
> > Patch 0002 avoids to reset the last branches for every instruction
> > sample; if reset the last branches for every time generating sample, the
> > later samples in the same range packet cannot use the last branches
> > anymore.
> >
> > Patch 0003 is the fixing for handling different instruction periods,
> > especially for small sample period.
> >
> > Patch 0004 is an optimization for copying last branches; it only copies
> > last branches once if the instruction samples share the same last
> > branches.
> >
> > Patch 0005 is a minor fix for unsigned variable comparison to zero.
> >
> > This patch set has been rebased on the latest perf/core branch; and
> > verified on Juno board with below commands:
> >
> > # perf script --itrace=i2
> > # perf script --itrace=i2il16
> > # perf inject --itrace=i2il16 -i perf.data -o perf.data.new
> > # perf inject --itrace=i100il16 -i perf.data -o perf.data.new
>
> Could you pick up this patch set? I confirmed this patch set can
> cleanly apply on top of the latest mainline kernel (5.6-rc5).
>
> Or if you want me to resend this patch set, please feel free let me
> know. Thanks!
Thanks, all build tested on x86 and arm64 (with CORESIGHT=1, etc), applied.
- Arnaldo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-10 11:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 2:18 [PATCH v5 0/5] perf cs-etm: Fix synthesizing instruction samples Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-02-19 2:18 ` [PATCH v5 1/5] perf cs-etm: Swap packets for " Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-03-19 14:10 ` [tip: perf/core] " tip-bot2 for Leo Yan
2020-02-19 2:18 ` [PATCH v5 2/5] perf cs-etm: Continuously record last branch Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-03-19 14:10 ` [tip: perf/core] " tip-bot2 for Leo Yan
2020-02-19 2:18 ` [PATCH v5 3/5] perf cs-etm: Correct synthesizing instruction samples Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-03-19 14:10 ` [tip: perf/core] " tip-bot2 for Leo Yan
2020-02-19 2:18 ` [PATCH v5 4/5] perf cs-etm: Optimize copying last branches Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-03-19 14:10 ` [tip: perf/core] " tip-bot2 for Leo Yan
2020-02-19 2:18 ` [PATCH v5 5/5] perf cs-etm: Fix unsigned variable comparison to zero Leo Yan
2020-02-19 2:18 ` Leo Yan
2020-03-19 14:10 ` [tip: perf/core] " tip-bot2 for Leo Yan
2020-03-10 5:43 ` [PATCH v5 0/5] perf cs-etm: Fix synthesizing instruction samples Leo Yan
2020-03-10 5:43 ` Leo Yan
2020-03-10 11:45 ` Arnaldo Carvalho de Melo [this message]
2020-03-10 11:45 ` Arnaldo Carvalho de Melo
2020-03-10 12:01 ` Leo Yan
2020-03-10 12:01 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310114503.GA25299@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robert.walker@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.