From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 10 Mar 2020 08:37:43 -0400 Subject: [PATCH 1/1 v1] cmd: gpio: Correct do_gpio() return value In-Reply-To: References: <20200105191056.12571-1-luka.kovacic@sartura.hr> <20200105191056.12571-2-luka.kovacic@sartura.hr> <20200208000558.GM13379@bill-the-cat> Message-ID: <20200310123743.GZ12423@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Mar 10, 2020 at 09:47:33AM +0000, Alex Kiernan wrote: > On Sat, Feb 8, 2020 at 12:06 AM Tom Rini wrote: > > > > On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote: > > > > > Use the correct return value in function do_gpio() and update > > > commands documentation with the return values from command_ret_t enum. > > > > > > CMD_RET_SUCCESS is returned on command success and CMD_RET_FAILURE is > > > returned on command failure. > > > > > > The command was returning the pin value, which caused confusion when > > > debugging (#define DEBUG). > > > > > > Signed-off-by: Luka Kovacic > > > Tested-by: Robert Marko > > > > Applied to u-boot/master, thanks! > > > > I just pulled in HEAD for a test build and our boot scripts are broken > with this gpio change - I don't see a way to get the value of a gpio > pin in a script now? > > Whilst I agree what's there was wrong, I'm really not sure we can > change an existing interface like this. Sigh, this is what I was worried about. If folks don't have a suggestion on how to correct things again I'm going to revert this change, sorry for the noise, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: