From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D63AAC18E5A for ; Tue, 10 Mar 2020 13:18:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F45E222D9 for ; Tue, 10 Mar 2020 13:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583846313; bh=dJeKi+R32ZhJSaKkqRgirh033mtVSJyG7ZWIYC80IkU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oLhDd24VOlMmfqVHIpgUkt1w0GCASOKSgNf1ucpT6lsN6Q99xCbxF75txrgEiXvl/ +G1o5wkRRo/pPpIZJMnL65Rsu1rN/jpkJivcA4wjwdgXWX7qTWTLfzbcIV3ZaM55Lp Ql8VR7bR+WW6f2zKlTxDiSNyiWe+wPBUIXJExyjI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731343AbgCJNKm (ORCPT ); Tue, 10 Mar 2020 09:10:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:60022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730821AbgCJNKg (ORCPT ); Tue, 10 Mar 2020 09:10:36 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 055432468D; Tue, 10 Mar 2020 13:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845835; bh=dJeKi+R32ZhJSaKkqRgirh033mtVSJyG7ZWIYC80IkU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZUOuUexbqCQWq5bVdYVFpC/0p8s8peCc3/qEWqvPevTH9nOaRT9TCp+KVflPor55b 9ujBvPLZopLELXLSXrfRNkuHRLIzGaheRvjL+x3pLXaYndk5OY4xw2h1utbqa74yJP FHU4wUP6jbwB1ZNAaExRkkyGhEXZ+ns797Ag9gTI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+cb0c054eabfba4342146@syzkaller.appspotmail.com, Bernard Metzler , Jason Gunthorpe Subject: [PATCH 4.14 117/126] RDMA/iwcm: Fix iwcm work deallocation Date: Tue, 10 Mar 2020 13:42:18 +0100 Message-Id: <20200310124210.964531891@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310124203.704193207@linuxfoundation.org> References: <20200310124203.704193207@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bernard Metzler commit 810dbc69087b08fd53e1cdd6c709f385bc2921ad upstream. The dealloc_work_entries() function must update the work_free_list pointer while freeing its entries, since potentially called again on same list. A second iteration of the work list caused system crash. This happens, if work allocation fails during cma_iw_listen() and free_cm_id() tries to free the list again during cleanup. Fixes: 922a8e9fb2e0 ("RDMA: iWARP Connection Manager.") Link: https://lore.kernel.org/r/20200302181614.17042-1-bmt@zurich.ibm.com Reported-by: syzbot+cb0c054eabfba4342146@syzkaller.appspotmail.com Signed-off-by: Bernard Metzler Reviewed-by: Jason Gunthorpe Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/core/iwcm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/infiniband/core/iwcm.c +++ b/drivers/infiniband/core/iwcm.c @@ -158,8 +158,10 @@ static void dealloc_work_entries(struct { struct list_head *e, *tmp; - list_for_each_safe(e, tmp, &cm_id_priv->work_free_list) + list_for_each_safe(e, tmp, &cm_id_priv->work_free_list) { + list_del(e); kfree(list_entry(e, struct iwcm_work, free_list)); + } } static int alloc_work_entries(struct iwcm_id_private *cm_id_priv, int count)