From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 904A4C18E5C for ; Tue, 10 Mar 2020 13:11:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A8E224649 for ; Tue, 10 Mar 2020 13:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845911; bh=779UrS+LZsp9ln83dBobbCiQunNu96RYkBFUGMEeamE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PgR8ItfTaw1VtOzA4uam/e5bOBwR8ub6/K3FsZmdZ0lrCPJ/NMDIYugWAXajPjjIg grihdPqwki4NHNq+RijEGFTyJdpogBh/1XvS9mUZuEnUInZtnyHb2uxTRu9mktT3te 1QN1P8jB7nAnccrY0InqsAlA0sZvOcj9Vgk4Fl3c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731474AbgCJNLu (ORCPT ); Tue, 10 Mar 2020 09:11:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:33488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731453AbgCJNLq (ORCPT ); Tue, 10 Mar 2020 09:11:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C559208E4; Tue, 10 Mar 2020 13:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845905; bh=779UrS+LZsp9ln83dBobbCiQunNu96RYkBFUGMEeamE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xORkKF3v8VUHTCavb86cW5fRtzT9UdkVs4QdyC+Im/w5BIwUfAY3DPQnyL5pVkgiR DUfYDbWrDuVzqaxW5vvFQFFdCNz2s1Kc9yfNgew85r198Tn7HZubo3ZONhLMGiUbGY 37+V6iBdWsOKOVWKhkFDHZWDs6lejZ+qJBeuW+Jk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Harigovindan P , Jeffrey Hugo , Rob Clark , Sasha Levin Subject: [PATCH 4.19 17/86] drm/msm/dsi/pll: call vco set rate explicitly Date: Tue, 10 Mar 2020 13:44:41 +0100 Message-Id: <20200310124531.716585538@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310124530.808338541@linuxfoundation.org> References: <20200310124530.808338541@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Harigovindan P [ Upstream commit c6659785dfb3f8d75f1fe637e4222ff8178f5280 ] For a given byte clock, if VCO recalc value is exactly same as vco set rate value, vco_set_rate does not get called assuming VCO is already set to required value. But Due to GDSC toggle, VCO values are erased in the HW. To make sure VCO is programmed correctly, we forcefully call set_rate from vco_prepare. Signed-off-by: Harigovindan P Reviewed-by: Jeffrey Hugo Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c index 31205625c7346..21a69b046625a 100644 --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c @@ -406,6 +406,12 @@ static int dsi_pll_10nm_vco_prepare(struct clk_hw *hw) if (pll_10nm->slave) dsi_pll_enable_pll_bias(pll_10nm->slave); + rc = dsi_pll_10nm_vco_set_rate(hw,pll_10nm->vco_current_rate, 0); + if (rc) { + pr_err("vco_set_rate failed, rc=%d\n", rc); + return rc; + } + /* Start PLL */ pll_write(pll_10nm->phy_cmn_mmio + REG_DSI_10nm_PHY_CMN_PLL_CNTRL, 0x01); -- 2.20.1