From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ABACC10F27 for ; Tue, 10 Mar 2020 13:13:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69160208E4 for ; Tue, 10 Mar 2020 13:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845995; bh=KrMwgO/rsL9tgq2geO//BwD15z8GpKy0HuXoaGwIrug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ICe/tVf+CtNwbPNIDOyS1T6BUBiiudw6fXLmwyA+BJQXXBiOQ/v6O9dE2WPAp4PfA Gtw7JpuQSpsE9U8uI+k4RatLa56t4hEa9T4XJX9iLz9tyg+JCyBUhQjOiZngnv7aMK SiRDJyijAMCj20CiPjXcCidkJ4g0DYd1isbAy3sE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731283AbgCJNNN (ORCPT ); Tue, 10 Mar 2020 09:13:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:35696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731660AbgCJNNI (ORCPT ); Tue, 10 Mar 2020 09:13:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 899BF24649; Tue, 10 Mar 2020 13:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845988; bh=KrMwgO/rsL9tgq2geO//BwD15z8GpKy0HuXoaGwIrug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DcIdMRwQVUgy2U+WvwN8xFjmrcYLEEowSnXOBVLgeJS3w4u2vBwoMTTZsT2V8Wf6P VmZ8CVXAy3rNqbphnYIqR5cu4DWLbOV3OSN/O2CR4cRp1kGbTXBQ5y+Mp3CrPEbhTM hsAlmR3M68AJPRwLCB9kaOCNpu7yjUxCziN5DEkA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, tangbin , Jiri Slaby Subject: [PATCH 4.19 46/86] tty:serial:mvebu-uart:fix a wrong return Date: Tue, 10 Mar 2020 13:45:10 +0100 Message-Id: <20200310124533.290908144@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310124530.808338541@linuxfoundation.org> References: <20200310124530.808338541@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: tangbin commit 4a3e208474204e879d22a310b244cb2f39e5b1f8 upstream. in this place, the function should return a negative value and the PTR_ERR already returns a negative,so return -PTR_ERR() is wrong. Signed-off-by: tangbin Cc: stable Acked-by: Jiri Slaby Link: https://lore.kernel.org/r/20200305013823.20976-1-tangbin@cmss.chinamobile.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/mvebu-uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -840,7 +840,7 @@ static int mvebu_uart_probe(struct platf port->membase = devm_ioremap_resource(&pdev->dev, reg); if (IS_ERR(port->membase)) - return -PTR_ERR(port->membase); + return PTR_ERR(port->membase); mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart), GFP_KERNEL);