From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED39C10F27 for ; Tue, 10 Mar 2020 13:31:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCC0720675 for ; Tue, 10 Mar 2020 13:31:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dg7L82DW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729365AbgCJNbu (ORCPT ); Tue, 10 Mar 2020 09:31:50 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39097 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727231AbgCJNbr (ORCPT ); Tue, 10 Mar 2020 09:31:47 -0400 Received: by mail-wr1-f65.google.com with SMTP id r15so10835299wrx.6 for ; Tue, 10 Mar 2020 06:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SGZgsH+padUygQ4Cia7cE9IFr+EvRgTaa32npdrtzWc=; b=dg7L82DWEiw0rdSwNr2DyRTaCTid+TPApdVxlafYq4AipWASzO9UjWBGoMzbQJU6Zn FcVLsljOgCFtV5tGCTDxvDcuENshSrjaqclQu4DLXYnyd8VwAbcmXaWptQDIIYRw0Mvk GfnIfAsgFE5LdRwk/p4NdBb6D+Uq0KG6pshRkMgRIvf6pPtcA8H2C1Ld55MdENrIXKZu mkPa1OnuzhVbyD5tQK6tLNKfwzIiV3aSe9+2HBqE759pdILSJw5zeVMxsZck4Utc0qZ+ C6UhWibz+kjEltkkuyRd9QtNDvhPDu8h1CTszvI2gctrxNmY3IxCfDWcM8Y3KUJM5hWP 6ysg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SGZgsH+padUygQ4Cia7cE9IFr+EvRgTaa32npdrtzWc=; b=b2SI+1kQ67yITQ4b8NHt6pTbKnH/xBZ09U2DIhSADVw2aHl3hB5o17VPx/J88AtYQo kIXO01KX8/FvYU+hHW9PWk9wDxO8KWhiLFEkCwhngD5kCNkG4nwG1y4gtRhFGsUze48d yMVqc8EI0E6K8CZ4tU9E+MtDS59K3c0aBCiw4Xgklk6uJYjixCwa3YuWMawGnhxygVvR Ll7IeAA96LnQ0kPgTAaBB4T2ZvQ0EbCy9PuGeLrSFb8b2cz4UYDpYRYxPP/917AksTu6 FBcBRhQ0EtsplViF5jVOQsK4pFwgOWqrcvFrTjB4xcSglpwI0tsJq8LOqElMLwId8m1u GYJg== X-Gm-Message-State: ANhLgQ0lc96i0wOzsFKEHHOClgGoiYION52DLRElUfWh3atZIhgf05IH kMp71yDfiIwkRe2IHbqCB9Y= X-Google-Smtp-Source: ADFU+vuTm8NKlxrWVPle4ZIU7qSC/syjzXhDqkYplHXSPQAFccyI2BA7t9nw37f8vOWSAuPKPa5K7Q== X-Received: by 2002:adf:e74e:: with SMTP id c14mr28701764wrn.128.1583847105552; Tue, 10 Mar 2020 06:31:45 -0700 (PDT) Received: from localhost.localdomain ([197.248.222.210]) by smtp.googlemail.com with ESMTPSA id o7sm14047141wrx.60.2020.03.10.06.31.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 06:31:44 -0700 (PDT) From: Wambui Karuga To: airlied@linux.ie, daniel@ffwll.ch, Lucas Stach , Russell King , Christian Gmeiner Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, etnaviv@lists.freedesktop.org Subject: [PATCH v2 07/17] drm/etnaviv: remove check for return value of drm_debugfs_create_files() Date: Tue, 10 Mar 2020 16:31:11 +0300 Message-Id: <20200310133121.27913-8-wambui.karugax@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310133121.27913-1-wambui.karugax@gmail.com> References: <20200310133121.27913-1-wambui.karugax@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and only returns 0. Therefore, remove the unnecessary check of its return value and error handling in etnaviv_debugfs_init() and have the function return 0 directly. v2: have etnaviv_debugfs_init() return 0 instead of void to ensure individual compilation and avoid build breakage. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 6b43c1c94e8f..a65d30a48a9d 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c @@ -233,19 +233,11 @@ static struct drm_info_list etnaviv_debugfs_list[] = { static int etnaviv_debugfs_init(struct drm_minor *minor) { - struct drm_device *dev = minor->dev; - int ret; - - ret = drm_debugfs_create_files(etnaviv_debugfs_list, - ARRAY_SIZE(etnaviv_debugfs_list), - minor->debugfs_root, minor); + drm_debugfs_create_files(etnaviv_debugfs_list, + ARRAY_SIZE(etnaviv_debugfs_list), + minor->debugfs_root, minor); - if (ret) { - dev_err(dev->dev, "could not install etnaviv_debugfs_list\n"); - return ret; - } - - return ret; + return 0; } #endif -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C5A8C10F27 for ; Tue, 10 Mar 2020 23:36:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 067EE21927 for ; Tue, 10 Mar 2020 23:36:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dg7L82DW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 067EE21927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C8CB86E8EB; Tue, 10 Mar 2020 23:36:14 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id E8CC66E2DD; Tue, 10 Mar 2020 13:31:46 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id s14so2231329wrt.8; Tue, 10 Mar 2020 06:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SGZgsH+padUygQ4Cia7cE9IFr+EvRgTaa32npdrtzWc=; b=dg7L82DWEiw0rdSwNr2DyRTaCTid+TPApdVxlafYq4AipWASzO9UjWBGoMzbQJU6Zn FcVLsljOgCFtV5tGCTDxvDcuENshSrjaqclQu4DLXYnyd8VwAbcmXaWptQDIIYRw0Mvk GfnIfAsgFE5LdRwk/p4NdBb6D+Uq0KG6pshRkMgRIvf6pPtcA8H2C1Ld55MdENrIXKZu mkPa1OnuzhVbyD5tQK6tLNKfwzIiV3aSe9+2HBqE759pdILSJw5zeVMxsZck4Utc0qZ+ C6UhWibz+kjEltkkuyRd9QtNDvhPDu8h1CTszvI2gctrxNmY3IxCfDWcM8Y3KUJM5hWP 6ysg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SGZgsH+padUygQ4Cia7cE9IFr+EvRgTaa32npdrtzWc=; b=VWY2grKFAV07r3nLBG5mUF+FnuNbbIIbbgKPu5J6A/avzwYSshGlf15dRvmrIo31ob 4+Xah1r1Xwf3tOPoINNakLrdUe2jNDuRd4ZcSDc+Z6yajIWiP1kC+g/gzMqev+TCV6SX TCxOooz2fQMf5CVcqeFOU3Z5iNiqXOi+AAhzCC3vDFEVsPN5MqGE+/BsJGAOBCQ1g/De t2KUs9/gXr6+Uku28S+cstDnJ9u6hz5f8qtlOou0m2O96HDL4Rd1yzlWkaI+2dUC73gM 1LHAd0mmID3+kki1mPQYNzuNbhi0cf0x8+pa6f2Uaa2GknOui66lfT/ncDmALm39+yID uWvg== X-Gm-Message-State: ANhLgQ2aDK7DNit0iQoNnuaT0CYYsKyJCU9Ms/Pq8A9gquAiMxzTYKG7 oPeJh85+foJDHCa52qxLL90= X-Google-Smtp-Source: ADFU+vuTm8NKlxrWVPle4ZIU7qSC/syjzXhDqkYplHXSPQAFccyI2BA7t9nw37f8vOWSAuPKPa5K7Q== X-Received: by 2002:adf:e74e:: with SMTP id c14mr28701764wrn.128.1583847105552; Tue, 10 Mar 2020 06:31:45 -0700 (PDT) Received: from localhost.localdomain ([197.248.222.210]) by smtp.googlemail.com with ESMTPSA id o7sm14047141wrx.60.2020.03.10.06.31.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 06:31:44 -0700 (PDT) From: Wambui Karuga To: airlied@linux.ie, daniel@ffwll.ch, Lucas Stach , Russell King , Christian Gmeiner Subject: [PATCH v2 07/17] drm/etnaviv: remove check for return value of drm_debugfs_create_files() Date: Tue, 10 Mar 2020 16:31:11 +0300 Message-Id: <20200310133121.27913-8-wambui.karugax@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310133121.27913-1-wambui.karugax@gmail.com> References: <20200310133121.27913-1-wambui.karugax@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 10 Mar 2020 23:36:13 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and only returns 0. Therefore, remove the unnecessary check of its return value and error handling in etnaviv_debugfs_init() and have the function return 0 directly. v2: have etnaviv_debugfs_init() return 0 instead of void to ensure individual compilation and avoid build breakage. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 6b43c1c94e8f..a65d30a48a9d 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c @@ -233,19 +233,11 @@ static struct drm_info_list etnaviv_debugfs_list[] = { static int etnaviv_debugfs_init(struct drm_minor *minor) { - struct drm_device *dev = minor->dev; - int ret; - - ret = drm_debugfs_create_files(etnaviv_debugfs_list, - ARRAY_SIZE(etnaviv_debugfs_list), - minor->debugfs_root, minor); + drm_debugfs_create_files(etnaviv_debugfs_list, + ARRAY_SIZE(etnaviv_debugfs_list), + minor->debugfs_root, minor); - if (ret) { - dev_err(dev->dev, "could not install etnaviv_debugfs_list\n"); - return ret; - } - - return ret; + return 0; } #endif -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel