From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A553CC18E5A for ; Tue, 10 Mar 2020 15:43:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81B1E20675 for ; Tue, 10 Mar 2020 15:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726443AbgCJPnc (ORCPT ); Tue, 10 Mar 2020 11:43:32 -0400 Received: from foss.arm.com ([217.140.110.172]:38744 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbgCJPnc (ORCPT ); Tue, 10 Mar 2020 11:43:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CBB4B1FB; Tue, 10 Mar 2020 08:43:29 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A7A353F534; Tue, 10 Mar 2020 08:43:29 -0700 (PDT) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id 5585B682F35; Tue, 10 Mar 2020 15:43:28 +0000 (GMT) Date: Tue, 10 Mar 2020 15:43:28 +0000 From: Liviu Dudau To: Wambui Karuga Cc: airlied@linux.ie, daniel@ffwll.ch, Brian Starkey , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v2 06/17] drm/arm: make hdlcd_debugfs_init() return 0 Message-ID: <20200310154328.GO364558@e110455-lin.cambridge.arm.com> References: <20200310133121.27913-1-wambui.karugax@gmail.com> <20200310133121.27913-7-wambui.karugax@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200310133121.27913-7-wambui.karugax@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 04:31:10PM +0300, Wambui Karuga wrote: > Since commit 987d65d01356 (drm: debugfs: make > drm_debugfs_create_files() never fail), drm_debugfs_create_files() never > fails and should return void. Therefore, remove its use as the > return value of hdlcd_debugfs_init() and have the latter function return > 0 directly. > > v2: make hdlcd_debugfs_init() return 0 instead of void to ensure that > each patch compiles individually. > > References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html > Signed-off-by: Wambui Karuga Acked-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index 2e053815b54a..bd0ad6f46a97 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -226,8 +226,10 @@ static struct drm_info_list hdlcd_debugfs_list[] = { > > static int hdlcd_debugfs_init(struct drm_minor *minor) > { > - return drm_debugfs_create_files(hdlcd_debugfs_list, > - ARRAY_SIZE(hdlcd_debugfs_list), minor->debugfs_root, minor); > + drm_debugfs_create_files(hdlcd_debugfs_list, > + ARRAY_SIZE(hdlcd_debugfs_list), > + minor->debugfs_root, minor); > + return 0; > } > #endif > > -- > 2.25.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E432C3F2C6 for ; Tue, 10 Mar 2020 15:43:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42AA2215A4 for ; Tue, 10 Mar 2020 15:43:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42AA2215A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D8676E332; Tue, 10 Mar 2020 15:43:31 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DA636E332 for ; Tue, 10 Mar 2020 15:43:30 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CBB4B1FB; Tue, 10 Mar 2020 08:43:29 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A7A353F534; Tue, 10 Mar 2020 08:43:29 -0700 (PDT) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id 5585B682F35; Tue, 10 Mar 2020 15:43:28 +0000 (GMT) Date: Tue, 10 Mar 2020 15:43:28 +0000 From: Liviu Dudau To: Wambui Karuga Subject: Re: [PATCH v2 06/17] drm/arm: make hdlcd_debugfs_init() return 0 Message-ID: <20200310154328.GO364558@e110455-lin.cambridge.arm.com> References: <20200310133121.27913-1-wambui.karugax@gmail.com> <20200310133121.27913-7-wambui.karugax@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200310133121.27913-7-wambui.karugax@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBNYXIgMTAsIDIwMjAgYXQgMDQ6MzE6MTBQTSArMDMwMCwgV2FtYnVpIEthcnVnYSB3 cm90ZToKPiBTaW5jZSBjb21taXQgOTg3ZDY1ZDAxMzU2IChkcm06IGRlYnVnZnM6IG1ha2UKPiBk cm1fZGVidWdmc19jcmVhdGVfZmlsZXMoKSBuZXZlciBmYWlsKSwgZHJtX2RlYnVnZnNfY3JlYXRl X2ZpbGVzKCkgbmV2ZXIKPiBmYWlscyBhbmQgc2hvdWxkIHJldHVybiB2b2lkLiBUaGVyZWZvcmUs IHJlbW92ZSBpdHMgdXNlIGFzIHRoZQo+IHJldHVybiB2YWx1ZSBvZiBoZGxjZF9kZWJ1Z2ZzX2lu aXQoKSBhbmQgaGF2ZSB0aGUgbGF0dGVyIGZ1bmN0aW9uIHJldHVybgo+IDAgZGlyZWN0bHkuCj4g Cj4gdjI6IG1ha2UgaGRsY2RfZGVidWdmc19pbml0KCkgcmV0dXJuIDAgaW5zdGVhZCBvZiB2b2lk IHRvIGVuc3VyZSB0aGF0Cj4gZWFjaCBwYXRjaCBjb21waWxlcyBpbmRpdmlkdWFsbHkuCj4gCj4g UmVmZXJlbmNlczogaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRl dmVsLzIwMjAtRmVicnVhcnkvMjU3MTgzLmh0bWwKPiBTaWduZWQtb2ZmLWJ5OiBXYW1idWkgS2Fy dWdhIDx3YW1idWkua2FydWdheEBnbWFpbC5jb20+CgpBY2tlZC1ieTogTGl2aXUgRHVkYXUgPGxp dml1LmR1ZGF1QGFybS5jb20+CgpCZXN0IHJlZ2FyZHMsCkxpdml1Cgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vYXJtL2hkbGNkX2Rydi5jIHwgNiArKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2FybS9oZGxjZF9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vaGRsY2RfZHJ2LmMK PiBpbmRleCAyZTA1MzgxNWI1NGEuLmJkMGFkNmY0NmE5NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYXJtL2hkbGNkX2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FybS9oZGxj ZF9kcnYuYwo+IEBAIC0yMjYsOCArMjI2LDEwIEBAIHN0YXRpYyBzdHJ1Y3QgZHJtX2luZm9fbGlz dCBoZGxjZF9kZWJ1Z2ZzX2xpc3RbXSA9IHsKPiAgCj4gIHN0YXRpYyBpbnQgaGRsY2RfZGVidWdm c19pbml0KHN0cnVjdCBkcm1fbWlub3IgKm1pbm9yKQo+ICB7Cj4gLQlyZXR1cm4gZHJtX2RlYnVn ZnNfY3JlYXRlX2ZpbGVzKGhkbGNkX2RlYnVnZnNfbGlzdCwKPiAtCQlBUlJBWV9TSVpFKGhkbGNk X2RlYnVnZnNfbGlzdCksCW1pbm9yLT5kZWJ1Z2ZzX3Jvb3QsIG1pbm9yKTsKPiArCWRybV9kZWJ1 Z2ZzX2NyZWF0ZV9maWxlcyhoZGxjZF9kZWJ1Z2ZzX2xpc3QsCj4gKwkJCQkgQVJSQVlfU0laRSho ZGxjZF9kZWJ1Z2ZzX2xpc3QpLAo+ICsJCQkJIG1pbm9yLT5kZWJ1Z2ZzX3Jvb3QsIG1pbm9yKTsK PiArCXJldHVybiAwOwo+ICB9Cj4gICNlbmRpZgo+ICAKPiAtLSAKPiAyLjI1LjEKPiAKCi0tIAo9 PT09PT09PT09PT09PT09PT09PQp8IEkgd291bGQgbGlrZSB0byB8CnwgZml4IHRoZSB3b3JsZCwg IHwKfCBidXQgdGhleSdyZSBub3QgfAp8IGdpdmluZyBtZSB0aGUgICB8CiBcIHNvdXJjZSBjb2Rl ISAgLwogIC0tLS0tLS0tLS0tLS0tLQogICAgwq9cXyjjg4QpXy/CrwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK