All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Bruce Allan <bruce.w.allan@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	Andrew Bowers <andrewx.bowers@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 11/15] ice: fix use of deprecated strlcpy()
Date: Tue, 10 Mar 2020 13:45:30 -0700	[thread overview]
Message-ID: <20200310204534.2071912-12-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20200310204534.2071912-1-jeffrey.t.kirsher@intel.com>

From: Bruce Allan <bruce.w.allan@intel.com>

checkpatch complains "CHECK:DEPRECATED_API: Deprecated use of 'strlcpy',
prefer 'stracpy or strscpy' instead"; use strscpy.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_ethtool.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
index 03d4ecf47e3f..e3d148f12aac 100644
--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
@@ -173,8 +173,8 @@ ice_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo)
 	struct ice_hw *hw = &pf->hw;
 	u16 oem_build;
 
-	strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
-	strlcpy(drvinfo->version, ice_drv_ver, sizeof(drvinfo->version));
+	strscpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
+	strscpy(drvinfo->version, ice_drv_ver, sizeof(drvinfo->version));
 
 	/* Display NVM version (from which the firmware version can be
 	 * determined) which contains more pertinent information.
@@ -185,7 +185,7 @@ ice_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo)
 		 "%x.%02x 0x%x %d.%d.%d", nvm_ver_hi, nvm_ver_lo,
 		 hw->nvm.eetrack, oem_ver, oem_build, oem_patch);
 
-	strlcpy(drvinfo->bus_info, pci_name(pf->pdev),
+	strscpy(drvinfo->bus_info, pci_name(pf->pdev),
 		sizeof(drvinfo->bus_info));
 	drvinfo->n_priv_flags = ICE_PRIV_FLAG_ARRAY_SIZE;
 }
-- 
2.24.1


  parent reply	other threads:[~2020-03-10 20:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 20:45 [net-next v2 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-03-10 Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 01/15] ice: Cleanup unneeded parenthesis Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 02/15] iavf: Enable support for up to 16 queues Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 03/15] ice: allow bigger VFs Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 04/15] ice: Improve clarity of prints and variables Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 05/15] ice: Fix removing driver while bare-metal VFs pass traffic Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 06/15] ice: Display Link detected via Ethtool in safe mode Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 07/15] ice: Fix corner case when switching from IEEE to CEE Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 08/15] ice: renegotiate link after FW DCB on Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 09/15] ice: Correct setting VLAN pruning Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 10/15] ice: Increase mailbox receive queue length to maximum Jeff Kirsher
2020-03-10 20:45 ` Jeff Kirsher [this message]
2020-03-10 20:45 ` [net-next v2 12/15] ice: Fix format specifier Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 13/15] ice: Use EOPNOTSUPP instead of ENOTSUPP Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 14/15] ice: use variable name more descriptive than type Jeff Kirsher
2020-03-10 20:45 ` [net-next v2 15/15] ice: fix incorrect size description of ice_get_nvm_version Jeff Kirsher
2020-03-10 21:51 ` [net-next v2 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-03-10 Jakub Kicinski
2020-03-10 23:21   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310204534.2071912-12-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=andrewx.bowers@intel.com \
    --cc=bruce.w.allan@intel.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.