All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lourdes Pedrajas <lu@pplo.net>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8192u: r8192U_wx: use pr_warn instead() of printk()
Date: Tue, 10 Mar 2020 22:34:36 +0100	[thread overview]
Message-ID: <20200310213436.GA2925@supernova> (raw)
In-Reply-To: <alpine.DEB.2.21.2003102141390.2313@hadrien>

On Tue, Mar 10, 2020 at 09:42:50PM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 10 Mar 2020, Lourdes Pedrajas wrote:
> 
> > printk() is deprecated, use pr_warn() instead. Change suggested by
> > checkpatch.
> >
> > Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> > ---
> >  drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> > index 0118edb0b9ab..09ab68865934 100644
> > --- a/drivers/staging/rtl8192u/r8192U_wx.c
> > +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> > @@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
> >  				hwkey);                 /* KeyContent */
> >
> >  		} else {
> > -			printk("wrong type in WEP, not WEP40 and WEP104\n");
> > +			pr_warn("wrong type in WEP, not WEP40 and WEP104\n");
> 
> There is a specific message printing function for network device drivers.
> 
> To find out what it is, you can probably go to drivers/net and do a git
> grep for warn, or something like that.
> 
> julia
> 
I agree, thank you for the hint!

Lourdes


      reply	other threads:[~2020-03-10 21:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 20:32 [PATCH] staging: rtl8192u: r8192U_wx: use pr_warn instead() of printk() Lourdes Pedrajas
2020-03-10 20:42 ` [Outreachy kernel] " Julia Lawall
2020-03-10 21:34   ` Lourdes Pedrajas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310213436.GA2925@supernova \
    --to=lu@pplo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@inria.fr \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.